New issue
Advanced search Search tips

Issue 844932 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 773295



Sign in to add a comment

Migrate components/feedback/feedback_uploader.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
 Issue 840405  has been merged into this issue.
Blocking: 773295
Owner: ----
Status: Available (was: Started)
Owner: rmcelrath@chromium.org
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d956f867578f34f99d408298f50c10862b24715e

commit d956f867578f34f99d408298f50c10862b24715e
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Mon Jul 09 22:01:02 2018

Migrate FeedbackUploader to SimpleURLLoader.

This is a copy of https://crrev.com/c/1067424 but with tests fixed.

Bug:  844932 
Change-Id: I77239bf76a673b33d56b8b7fe584a78ec319bc24
Reviewed-on: https://chromium-review.googlesource.com/1114253
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573467}
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/chrome/browser/feedback/feedback_uploader_chrome.cc
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/chrome/browser/feedback/feedback_uploader_chrome.h
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/chrome/browser/feedback/feedback_uploader_factory_chrome.cc
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/components/feedback/BUILD.gn
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/components/feedback/DEPS
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/components/feedback/feedback_data_unittest.cc
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/components/feedback/feedback_uploader.cc
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/components/feedback/feedback_uploader.h
[delete] https://crrev.com/f23252dc4223cee242215d8d573dcedcec10fa87/components/feedback/feedback_uploader_delegate.cc
[delete] https://crrev.com/f23252dc4223cee242215d8d573dcedcec10fa87/components/feedback/feedback_uploader_delegate.h
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/components/feedback/feedback_uploader_dispatch_unittest.cc
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/components/feedback/feedback_uploader_factory.cc
[modify] https://crrev.com/d956f867578f34f99d408298f50c10862b24715e/components/feedback/feedback_uploader_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment