New issue
Advanced search Search tips

Issue 844929 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----



Sign in to add a comment

Migrate components/autofill/core/browser/autofill_download_manager.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0dd4756772fdcba62f68ed8e5bbcd341fd25649

commit c0dd4756772fdcba62f68ed8e5bbcd341fd25649
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Jul 03 15:55:08 2018

Move away from using base::Clock in AutofillDownloadManager tests

This is a preparation CL to move AutofillDownloadManager from URLFetcher
to SimpleURLLoader et al. Specifically, it moves some autofill tests away
from using base::Clock, for testing whether a autofill query request is
properly cached/fetched. Still, both CACHE_HIT and CACHE_MISS functionalities
are exercised.

Basically, instead of setting the base::Clock instance with manually configured
valid and expired dates, the following was changed:

- the original test (AutofillQueryTest.CacheableResponse) was spun off into
another test: AutofillQueryTest.ExpiredCacheInResponse.

- The former sets a Cache-Control max-age value to some time in the future
(100 seconds), so that its cached content is valid/reached.

- The later sets a Cache-Control max-age value to 0, and delay execution in
a few milliseconds to ensure the cache content is already expired, and never
hit.

BUG=837830, 844929 

Change-Id: Ib82ca230fb0169b9e6847d90019574eb571e4c97
Reviewed-on: https://chromium-review.googlesource.com/1122456
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#572238}
[modify] https://crrev.com/c0dd4756772fdcba62f68ed8e5bbcd341fd25649/components/autofill/core/browser/autofill_download_manager_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3328d5c434b366bf9c6ddd344867be2c7f209a5e

commit 3328d5c434b366bf9c6ddd344867be2c7f209a5e
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Jul 16 15:09:28 2018

Migrate AutofillDownloadManager to SimpleURLLoader

This CL migrates AutofillDownloadManager away from URLFetcher, to
SimpleURLLoader.

As a notorious remark, the CL introduces a public method to
SimpleURLLoader, LoadedFromCache. It allows to verify whether
some specific content are served from the cache, as expected.

BUG=773295, 844929 

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I92a36bc032b7c0e182ae83f367eefd605ad888ca
Reviewed-on: https://chromium-review.googlesource.com/1114998
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#575269}
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/DEPS
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/autofill_download_manager.cc
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/autofill_download_manager.h
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/autofill_download_manager_unittest.cc
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/test_autofill_driver.cc
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/test_autofill_driver.h
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/services/network/public/cpp/simple_url_loader.cc
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/services/network/public/cpp/simple_url_loader.h

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf24acda79f4d576bd09127a2cb2b97207b6a8e2

commit bf24acda79f4d576bd09127a2cb2b97207b6a8e2
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Sep 19 18:18:09 2018

fixup! Migrate AutofillDownloadManager to SimpleURLLoader

Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest.

TBR=rogerm@chromium.org

[1] https://crrev.com/c/1234133

BUG= 844929 

Change-Id: I055fb12f77ec3b1511595d7ad111a8cc2091242d
Reviewed-on: https://chromium-review.googlesource.com/1234653
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#592481}
[modify] https://crrev.com/bf24acda79f4d576bd09127a2cb2b97207b6a8e2/components/autofill/core/browser/autofill_download_manager_unittest.cc

Sign in to add a comment