Migrate extensions/browser/updater/extension_downloader.cc |
|||||
Issue description
,
May 21 2018
WIP https://chromium-review.googlesource.com/c/chromium/src/+/1066370
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb02821074ba14de3d6a503ef204b694b25017a4 commit cb02821074ba14de3d6a503ef204b694b25017a4 Author: Matt Menke <mmenke@chromium.org> Date: Tue Jun 19 15:40:30 2018 Annotate many of the browser_tests disabled under the NetworkService. Also remove a couple that either no longer exist, have been disabled generally due to flakiness, or are now passing. BUG= 844950 , 844951 , 844952 , 853251 , 844928 , BUG= 843205 , 844949 , 844925 , 844939 , 821021, BUG=853798, 844973 , 844927 , 844926 , 844950 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I094a012fe2076c7badf86a094140c7d74db183be Reviewed-on: https://chromium-review.googlesource.com/1104802 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#568464} [modify] https://crrev.com/cb02821074ba14de3d6a503ef204b694b25017a4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1a0219ccafe50725ed73b5cce2ee5cc8dfc8211 commit e1a0219ccafe50725ed73b5cce2ee5cc8dfc8211 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Wed Aug 01 15:39:44 2018 Allow non-content code use FileURLLoaderFactory This CL exposes a method that allows the creation of FileURLLoaderFactory instances. through the content/browser public API. This is a preparation for CL https://crrev.com/c/1066370. BUG=773295, 844928 Change-Id: I89c9cd2e82ee54f4dae1c121d5e0f7b5c0597fb1 Reviewed-on: https://chromium-review.googlesource.com/1156885 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#579818} [modify] https://crrev.com/e1a0219ccafe50725ed73b5cce2ee5cc8dfc8211/content/browser/file_url_loader_factory.cc [modify] https://crrev.com/e1a0219ccafe50725ed73b5cce2ee5cc8dfc8211/content/public/browser/file_url_loader.h
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/402dbf5a71ebb19797dec03f63640ec17aff8c6f commit 402dbf5a71ebb19797dec03f63640ec17aff8c6f Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Aug 02 11:06:41 2018 Set more URLLoaderCompletionStatus data for successful FileURLLoaderFactory loads This CL allows SimpleURLLoader's to successfully load file:// URLs, ie when using FileURLLoaderFactory. Prior to this CL, even on the file specified in the file:// URL is written successfully, the URLLoaderCompletionStatus instance is passed to the URLLoaderClient from FileURLLoader::OnFileWritten, had only with the |error_code| set. SimpleURLLoader checks other URLLoaderCompletionStatus class members, (eg |decoded_body_length|) in order to consider the load actually successful. BUG=773295, 844928 Change-Id: I1040775fad2af7f0eb88f81e48bb355d48e5fc31 Reviewed-on: https://chromium-review.googlesource.com/1159042 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#580130} [modify] https://crrev.com/402dbf5a71ebb19797dec03f63640ec17aff8c6f/content/browser/file_url_loader_factory.cc
,
Aug 6
,
Aug 7
This landed in https://chromium-review.googlesource.com/c/chromium/src/+/1066370
,
Aug 8
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93ad3608cb3a3a2d3fbb264541cde6b2d735afcc commit 93ad3608cb3a3a2d3fbb264541cde6b2d735afcc Author: Antonio Gomes <tonikitoo@igalia.com> Date: Fri Sep 14 02:19:48 2018 Remove left over blacklist extension logic from ExtensionDownloader While working on [1], it was noticed that the ExtensionDownloader class (extensions/browser/updater/extension_downloader.cc|h) had some orphan logic that used to handle blacklist'ed Extensions loads in-memory. After a bit of git archaeology, I could found [2], which seems to have nuked out the "in memory" blacklist download handling code, but missed out some bits (eg ExtensionDownloader::StartBlacklistUpdate that has no callers). This CL removes the left over extension blacklist code in ExtensionDownloader. [1] https://crrev.com/c/1066370 [2] https://chromiumcodereview.appspot.com/23591050/diff/133001/chrome/browser/extensions/updater/extension_downloader.cc BUG= 844928 Change-Id: I8abc9a9924a4621926ebe1604c7191dce8e25494 Reviewed-on: https://chromium-review.googlesource.com/1219231 Reviewed-by: Minh Nguyen <mxnguyen@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#591268} [modify] https://crrev.com/93ad3608cb3a3a2d3fbb264541cde6b2d735afcc/extensions/browser/updater/extension_downloader.cc [modify] https://crrev.com/93ad3608cb3a3a2d3fbb264541cde6b2d735afcc/extensions/browser/updater/extension_downloader.h
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2360dd4c5901ce56d1f3322db5e8dfb6b5e03a20 commit 2360dd4c5901ce56d1f3322db5e8dfb6b5e03a20 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Wed Sep 19 18:04:34 2018 fixup! Migrate ExtensionDownloader to SimpleURLLoader Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest. TBR=rdevlin.cronin@chromium.org (straightforward switch after [1]). [1] https://crrev.com/c/1234133 BUG= 844928 Change-Id: If14f43964ddc21616cccadc337a8335099567c23 Reviewed-on: https://chromium-review.googlesource.com/1234633 Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#592469} [modify] https://crrev.com/2360dd4c5901ce56d1f3322db5e8dfb6b5e03a20/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dxie@google.com
, May 20 2018Status: Available (was: Untriaged)