New issue
Advanced search Search tips

Issue 844927 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Migrate extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)

Comment 2 by mmenke@chromium.org, Jun 18 2018

Components: Internals>Services>Network
Labels: Pri-1 Type-Bug
This code uses URLFetcher to fetch chrome:// URLs, which the network service can't do, so this is more than a simple switch to using SimpleURLLoader.

Comment 3 by jam@chromium.org, Jun 18 2018

web_ui_url_loader_factory.cc has a URLLoaderFactory that can load chrome:// urls, which we can allow embedders to use (similar to how we do things with FileURLLoaderFactory).
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb02821074ba14de3d6a503ef204b694b25017a4

commit cb02821074ba14de3d6a503ef204b694b25017a4
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Jun 19 15:40:30 2018

Annotate many of the browser_tests disabled under the NetworkService.

Also remove a couple that either no longer exist, have been disabled
generally due to flakiness, or are now passing.

BUG= 844950 ,  844951 ,  844952 ,  853251 ,  844928 ,
BUG= 843205 ,  844949 ,  844925 ,  844939 , 821021,
BUG=853798,  844973 ,  844927 ,  844926 ,  844950 

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I094a012fe2076c7badf86a094140c7d74db183be
Reviewed-on: https://chromium-review.googlesource.com/1104802
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568464}
[modify] https://crrev.com/cb02821074ba14de3d6a503ef204b694b25017a4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 5 by jam@chromium.org, Jun 21 2018

Owner: jam@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/788008660f92f0e668166c2b3d4c97a8ea2c3e9a

commit 788008660f92f0e668166c2b3d4c97a8ea2c3e9a
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Jun 25 20:49:50 2018

Convert WebUIURLFetcher to use SimpleURLLoader so that it can work with the network service.

Bug:  844927 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib0b437f76822800bc393253250ed2660527f276b
Reviewed-on: https://chromium-review.googlesource.com/1110666
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570169}
[modify] https://crrev.com/788008660f92f0e668166c2b3d4c97a8ea2c3e9a/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/788008660f92f0e668166c2b3d4c97a8ea2c3e9a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
[modify] https://crrev.com/788008660f92f0e668166c2b3d4c97a8ea2c3e9a/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc
[modify] https://crrev.com/788008660f92f0e668166c2b3d4c97a8ea2c3e9a/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h
[modify] https://crrev.com/788008660f92f0e668166c2b3d4c97a8ea2c3e9a/extensions/browser/web_ui_user_script_loader.cc
[modify] https://crrev.com/788008660f92f0e668166c2b3d4c97a8ea2c3e9a/extensions/browser/web_ui_user_script_loader.h
[modify] https://crrev.com/788008660f92f0e668166c2b3d4c97a8ea2c3e9a/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 7 by jam@chromium.org, Jun 25 2018

Status: Fixed (was: Started)

Sign in to add a comment