I'll work on this
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad5740ede50e7452a9613b1e32c5e41231553e84 commit ad5740ede50e7452a9613b1e32c5e41231553e84 Author: Sergio Villar Senin <svillar@igalia.com> Date: Tue Aug 07 15:41:12 2018 Migrate crash_service_uploader.cc to SimpleURLLoader This CL moves crash_service_uploader.cc away from URLFetcher replacing it by SimpleURLLoader as part of the network servicification project. A new API was added to SimpleURLLoader to support upload progress reporting during uploads. SimpleURLLoader already had an empty implementation of the URLLoaderClient::OnUploadProgress. From now on, it instead calls the callback set by the user of the API if any. This allowed us to find a bug in SimpleURLLoader::OnUploadProgress, it was not calling the ACK method resulting in assertion failures. Bug: 844919 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If9d63b9aadd0c2ac58bf86fa92691bd30cfacf10 Reviewed-on: https://chromium-review.googlesource.com/1154971 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581234} [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/android_webview/browser/tracing/aw_tracing_delegate.cc [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/android_webview/browser/tracing/aw_tracing_delegate.h [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/chrome/browser/profiling_host/profiling_process_host.cc [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/chrome/browser/tracing/background_tracing_field_trial.cc [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/chrome/browser/tracing/chrome_tracing_delegate.cc [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/chrome/browser/tracing/chrome_tracing_delegate.h [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/chrome/browser/tracing/crash_service_uploader.cc [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/chrome/browser/tracing/crash_service_uploader.h [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/chrome/browser/tracing/navigation_tracing.cc [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/content/browser/tracing/tracing_controller_browsertest.cc [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/content/browser/tracing/tracing_ui.cc [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/content/public/browser/tracing_delegate.h [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/services/network/public/cpp/simple_url_loader.cc [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/services/network/public/cpp/simple_url_loader.h [modify] https://crrev.com/ad5740ede50e7452a9613b1e32c5e41231553e84/services/network/public/cpp/simple_url_loader_unittest.cc
Comment 1 by dxie@google.com
, May 20 2018Status: Available (was: Untriaged)