New issue
Advanced search Search tips

Issue 844918 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocked on:
issue 789657

Blocking:
issue 773295



Sign in to add a comment

Migrate chrome/browser/profiles/profile_browsertest.cc to network::SimpleURLLoader

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Blocking: 773295
Components: UI>Browser>Profiles
Summary: Migrate chrome/browser/profiles/profile_browsertest.cc to network::SimpleURLLoader (was: Migrate chrome/browser/profiles/profile_browsertest.cc)
Status: Assigned (was: Available)
Taking this
Status: Available (was: Assigned)
Making it available again as it relies on StoragePartition::GetMediaURLRequestContext which is planned for removal altogether in the future.
Labels: -Proj-Servicification-Canary
Labels: Proj-Servicification-VendorBug
Status: Assigned (was: Available)
Taking this
Blockedon: 789657
Adding a dependency. The unittest requires a separate network context for media (as it uses a different cache)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22fe0139de05411c5da47ad5c43b09623f662ef3

commit 22fe0139de05411c5da47ad5c43b09623f662ef3
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Aug 21 18:11:51 2018

Migrate profile_browsertest.cc to SimpleURLLoader

It was using URLFetcher. In order to make it eventually work with the
future network service we need to transition it to SimpleURLLoader
API.

The tests was extensively using the URLFetcher* naming so I decided to
replace them all by references to SimpleURLLoader instead.

Bug:  844918 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I9f0412bcc4b5731a50e691602fa93d5ef06fba8e
Reviewed-on: https://chromium-review.googlesource.com/1177385
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584824}
[modify] https://crrev.com/22fe0139de05411c5da47ad5c43b09623f662ef3/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/22fe0139de05411c5da47ad5c43b09623f662ef3/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Fixed (was: Assigned)
closing...

Sign in to add a comment