New issue
Advanced search Search tips

Issue 844915 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 773295



Sign in to add a comment

Migrate chrome/browser/net/proxy_browsertest.cc to network::SimpleURLLoader

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Blocking: 773295
Components: Internals>Network>Proxy
Summary: Migrate chrome/browser/net/proxy_browsertest.cc to network::SimpleURLLoader (was: Migrate chrome/browser/net/proxy_browsertest.cc)
Status: Assigned (was: Available)
Working on this
Some of these tests may be somewhat redundant with new tests I added to NetworkContextBrowsertests.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4f55f716ef3513c76ae67498d00c156fa554abc

commit c4f55f716ef3513c76ae67498d00c156fa554abc
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Thu Jul 19 07:49:15 2018

Migrate chrome/browser/net/proxy_browsertest.cc to SimpleURLLoader

This CL moves proxy_browsertest.cc away from URLFetcher, replacing it by
SimpleURLLoader.

Bug:  844915 
Change-Id: Id0fd3ec4168f8b1c272906e6620c11b5418d2f54
Reviewed-on: https://chromium-review.googlesource.com/1141948
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576413}
[modify] https://crrev.com/c4f55f716ef3513c76ae67498d00c156fa554abc/chrome/browser/net/proxy_browsertest.cc

Owner: svil...@igalia.com
We can close this now
Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa6d8593a3ff0cbede6f25317704576bebe84654

commit aa6d8593a3ff0cbede6f25317704576bebe84654
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Aug 08 15:57:07 2018

Enable now passing browser_tests with network service.

Bug:  769401 , 865350 , 844915 ,773295
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie7c87877597686927a401b64120c444c79a8912c
Reviewed-on: https://chromium-review.googlesource.com/1166593
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581577}
[modify] https://crrev.com/aa6d8593a3ff0cbede6f25317704576bebe84654/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Sign in to add a comment