A lot of bots are hitting this: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20(AMD)/1241 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20(NVIDIA)/1013 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20x64%20Release%20(NVIDIA)/1071 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20(Intel)/3022 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Experimental%20Retina%20Release%20(AMD)/1728 It's all different tests depending on the bot. Here is a sample of some of the failing tests: WebglConformance_conformance2_textures_canvas_tex_2d_rgba4_rgba_unsigned_short_4_4_4_4 WebglConformance_conformance2_textures_canvas_tex_2d_rgb5_a1_rgba_unsigned_byte WebglConformance_conformance_rendering_scissor_rect_repeated_rendering WebglConformance_conformance_textures_canvas_tex_2d_rgb_rgb_unsigned_byte WebglConformance_conformance2_textures_webgl_canvas_tex_2d_rgba16f_rgba_float I'm running a few revert tryjobs to see if I can figure out which change to blame.
Based on tryjob results I suspect https://chromium-review.googlesource.com/c/chromium/src/+/1062585. Revert pending: https://chromium-review.googlesource.com/c/chromium/src/+/1067142
Issue 845013 has been merged into this issue.
Unfortunately I can't TBR things as I'm not a committer. Someone needs to approve my change.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9921a22f4af4a87db15b22996df66b19b79b328f commit 9921a22f4af4a87db15b22996df66b19b79b328f Author: James Darpinian <jdarpinian@chromium.org> Date: Mon May 21 02:29:01 2018 Revert "viz: Draw and swap after primary surface is available" This reverts commit bdc9b10b813d29194165c72c0587ed1e5d556654. Originally reviewed at: https://chromium-review.googlesource.com/c/chromium/src/+/1062585 Suspected of breaking WebGL conformance tests on FYI waterfall: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20(AMD)/1241 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20(NVIDIA)/1013 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20x64%20Release%20(NVIDIA)/1071 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20(Intel)/3022 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Experimental%20Retina%20Release%20(AMD)/1728 Bug: 844897 , 843290 No-Try: true Tbr: fsamuel@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I7994694e057a08f2a27d4aedcfa369fd350f32b2 Reviewed-on: https://chromium-review.googlesource.com/1067142 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#560218} [modify] https://crrev.com/9921a22f4af4a87db15b22996df66b19b79b328f/components/viz/service/display/display.cc [modify] https://crrev.com/9921a22f4af4a87db15b22996df66b19b79b328f/components/viz/service/display/surface_aggregator.cc [modify] https://crrev.com/9921a22f4af4a87db15b22996df66b19b79b328f/components/viz/service/display/surface_aggregator.h [modify] https://crrev.com/9921a22f4af4a87db15b22996df66b19b79b328f/components/viz/service/display/surface_aggregator_unittest.cc
Thanks for the approval! The revert seems to have fixed the bots.
Great! Thanks for pinpointing the error.
Comment 1 by jdarpinian@chromium.org
, May 20 2018