New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844865 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 850731
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 850731

Blocking:
issue 843511



Sign in to add a comment

js_devtools_bindings_test depends on java, fails to build on msan bot when adding headless tests to test list

Project Member Reported by thakis@chromium.org, May 19 2018

Issue description

We don't depend on Java except in Android and iOS builds. The test fails to build e.g. on msan: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_MSan_Builder%2F11941%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

The test either needs to use a better check than `if (is_linux)` or needs to be deleted, or rewritten without java dependency.
 
Blocking: 843511
Owner: pfeldman@chromium.org
Pavel can you please triage this?
Owner: kvitekp@chromium.org
Happened again today: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/12405

[462/7287] ACTION //headless:js_devtools_bindings_test(//build/toolchain/linux:clang_x64)
FAILED: gen/headless/devtools_bindings_test.js 
python ../../third_party/closure_compiler/js_binary.py --compiler ../../third_party/closure_compiler/compiler/compiler.jar --output gen/headless/devtools_bindings_test.js --deps gen/headless/js_devtools_bindings_lib.js_library --sources ../../headless/test/bindings_test.js --config --flags jscomp_error=checkTypes dependency_mode=STRICT compilation_level=SIMPLE language_out=ES5_STRICT entry_point=chromium.BindingsTest --externs ../../third_party/closure_compiler/externs/chrome.js ../../third_party/closure_compiler/externs/polymer-1.0.js ../../headless/lib/tab_socket_externs.js
Exception in thread "main" java.lang.UnsupportedClassVersionError: com/google/javascript/jscomp/CommandLineRunner : Unsupported major.minor version 52.0
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:803)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:442)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:64)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:354)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:348)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:347)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
	at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:482)

When I landed https://chromium-review.googlesource.com/c/chromium/src/+/1088754 (I had forgotten that adding the headless tests triggers this)
Summary: js_devtools_bindings_test depends on java, fails to build on msan bot when adding headless tests to test list (was: js_devtools_bindings_test depends on java)
Blockedon: 850731
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c149502277c1441eec693c3ec160462e150000b

commit 1c149502277c1441eec693c3ec160462e150000b
Author: Nico Weber <thakis@chromium.org>
Date: Sat Jun 09 04:10:45 2018

Run headless tests on memory waterfall.

Relands the last missing bit of https://chromium-review.googlesource.com/1088754
This got reverted the last time because the msan bot had a too-old version of
Java.  This should now be fixed.

TBR=kbr

Bug: 843511, 850731 , 844865 , 843732 , 843734 
Change-Id: I2359e6e721fa603117dd2a0a2f11f459ee2a2ddf
Reviewed-on: https://chromium-review.googlesource.com/1094036
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565841}
[modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/test_suites.pyl

Mergedinto: 850731
Status: Duplicate (was: Assigned)
Resolved for now by fixing  issue 850731 . If devtools tests could not depend on java that'd be better though imo.

Sign in to add a comment