New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844860 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Syntax error within Data Saver onboarding flow

Reported by madha...@gmail.com, May 19 2018

Issue description

Steps to reproduce the problem:
1. Force Data Saver onboarding flow
2. Open new tab after initial onboarding period
3. 

What is the expected behavior?
Blurb saying "See how much data you've saved"

What went wrong?
Blurb saying "See how much data that you've saved"

Did this work before? No 

Chrome version: 66.0.3359.158  Channel: stable
OS Version: 8.0.8
Flash Version: 

Applicable to translation ID:
3341058695485821946
3157842584138209013
 
photo_2018-05-19_07-17-29.jpg
37.7 KB View Download
Labels: Needs-triage-Mobile
Cc: sandeepkumars@chromium.org
Components: -UI Internals>Network>DataUse
Labels: M-68 Triaged-Mobile FoundIn-68 Target-68
Status: Untriaged (was: Unconfirmed)
Observed "See how much data that you've saved" notification on Customize and control google chrome menu.

Adding Internals>Network>DataUse component for further triaging of the issue as this is a new feature introduced recently.

Thanks!!
Owner: bengr@chromium.org
Status: Available (was: Untriaged)
bengr@ can you find an owner for this to address the translation issue?

This is a translation error specific to en-GB. The source string is the correct one, but the output of grit for en-rGB seems off.

https://cs.chromium.org/search/?q=%22see+how+much+data%22&sq=package:chromium&type=cs

Comment 4 by bengr@chromium.org, May 22 2018

Cc: srahim@chromium.org
Owner: dougarnett@chromium.org
Dougarnett, any updates?

This string is still being mistranslated from english to english-GB I believe. Can we confirm with a British language expert that "See how much data that you've  saved" is incorrect? It certainly sounds wrong to me, but I don't know why this would have gotten incorrectly translated unless there is some subtle language difference.
Cc: -srahim@chromium.org dougarnett@chromium.org
Owner: srahim@chromium.org
Status: Assigned (was: Available)
As Ryan points out, this seems to be a translation issue since the string is specific to the english-GB strings:

src/out/android-Debug/gen/chrome/android/chrome_strings_grd_grit_output/values-en-rGB/android_chrome_strings.xml has:
<string name="iph_data_saver_detail_text">"See how much data that you\'ve saved"</string>

while the baseline strings.xml has:
<string name="iph_data_saver_detail_text">"See how much data you\'ve saved"</string>



Since this is a linguistic issue, I've filed a bug for the translation team (https://b.corp.google.com/issues/111933877) requesting a linguistic review. You can keep this assigned to me until we have a resolution. 
Cc: melliem@google.com
Components: -Internals>Network>DataUse UI>Localization
Owner: jdignos@chromium.org
Hi,

We appreciate for reporting this bug, i have forwarded this issue to the locale POC for TC editing. I'll update you once it is done.

b/111933877

Regards!


Status: Fixed (was: Assigned)
Hi,

The following bug was fixed already.

Regards!

Sign in to add a comment