New issue
Advanced search Search tips

Issue 844835 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 844301
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue 776656



Sign in to add a comment

Bad-cast to blink::LayoutObject from invalid vptr in blink::TextOffsetMapping::InlineContents::NextOf

Project Member Reported by ClusterFuzz, May 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5508919674535936

Fuzzer: bj_broddelwerk
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x3a640da1cba0
Crash State:
  Bad-cast to blink::LayoutObject from invalid vptr
  blink::TextOffsetMapping::InlineContents::NextOf
  blink::TextOffsetMapping::ForwardRange::Iterator::operator++
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=559423:559424

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5508919674535936

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 19 2018

Components: Blink>Editing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 19 2018

Labels: Test-Predator-Auto-Owner
Owner: hayato@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/b6ec484f7d3153135b9640117a89252ff45829b8 (Launch Incremental Shadow DOM).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, May 19 2018

Labels: M-68
Project Member

Comment 4 by sheriffbot@chromium.org, May 19 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, May 19 2018

Labels: Pri-1

Comment 6 by hayato@chromium.org, May 21 2018

Mergedinto: 844301
Status: Duplicate (was: Assigned)
Let me merge this into 844301.
I confirmed that the WIP CL there fixed this.
Project Member

Comment 7 by ClusterFuzz, May 21 2018

ClusterFuzz has detected this issue as fixed in range 560220:560221.

Detailed report: https://clusterfuzz.com/testcase?key=5508919674535936

Fuzzer: bj_broddelwerk
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x3a640da1cba0
Crash State:
  Bad-cast to blink::LayoutObject from invalid vptr
  blink::TextOffsetMapping::InlineContents::NextOf
  blink::TextOffsetMapping::ForwardRange::Iterator::operator++
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=559423:559424
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=560220:560221

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5508919674535936

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 8 by hayato@chromium.org, May 25 2018

Blocking: 776656
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 28

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment