New issue
Advanced search Search tips

Issue 844816 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::ToCSSProperty

Project Member Reported by ClusterFuzz, May 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5217903293759488

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::ToCSSProperty
  blink::CSSProperty::Get
  blink::CSSComputedStyleDeclaration::SetPropertyInternal
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=559838:559850

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5217903293759488

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 19 2018

Components: Blink>CSS
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 19 2018

Labels: Test-Predator-Auto-Owner
Owner: andruud@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/aae947a01acaf7bce18c309244b64c8ef110a349 (Enumerate aliases on CSSPropertyDeclaration.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b53a6c3a60b195e6a43f56c6de3abc68dec05c7a

commit b53a6c3a60b195e6a43f56c6de3abc68dec05c7a
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Tue May 22 12:24:47 2018

Fix crash when setting aliases on computed style.

The incoming CSSPropertyID may be an unresolved property, therefore
CSSUnresolvedProperty::Get must be used rather than CSSProperty::Get.

This bug exists in Chrome stable as well, but it was pretty hard to
discover (by e.g. ClusterFuzz) because aliases were not enumerated until
recently.

R=futhark@chromium.org

Bug:  844816 
Change-Id: I97c81764d2027f86004d3b02316cac44412ef0ea
Reviewed-on: https://chromium-review.googlesource.com/1065993
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560540}
[add] https://crrev.com/b53a6c3a60b195e6a43f56c6de3abc68dec05c7a/third_party/WebKit/LayoutTests/external/wpt/css/cssom/computed-style-set-property.html
[delete] https://crrev.com/ea4720443119c7d510dcd8d570b0f7565583e1b9/third_party/WebKit/LayoutTests/fast/dom/computed-style-set-property-expected.txt
[delete] https://crrev.com/ea4720443119c7d510dcd8d570b0f7565583e1b9/third_party/WebKit/LayoutTests/fast/dom/computed-style-set-property.html
[modify] https://crrev.com/b53a6c3a60b195e6a43f56c6de3abc68dec05c7a/third_party/blink/renderer/core/css/css_computed_style_declaration.cc

Project Member

Comment 4 by ClusterFuzz, May 23 2018

ClusterFuzz has detected this issue as fixed in range 560539:560551.

Detailed report: https://clusterfuzz.com/testcase?key=5217903293759488

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::ToCSSProperty
  blink::CSSProperty::Get
  blink::CSSComputedStyleDeclaration::SetPropertyInternal
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=559838:559850
Fixed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=560539:560551

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5217903293759488

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, May 23 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5217903293759488 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment