New issue
Advanced search Search tips

Issue 844779 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----

Blocked on:
issue 843755



Sign in to add a comment

Selection highlight does not reset after a context menu is shown on a suggested app.

Project Member Reported by newcomer@chromium.org, May 18 2018

Issue description

After showing a context menu on a suggested app, the highlight does not go away.

In addition to this, there can be two selection highlights if the keyboard selection was active on a different app.
 
Owner: newcomer@chromium.org
Labels: Touch-Friendly-Launcher-Urgent
Labels: M-68 Pri-1
Blockedon: 843755
Fix this in M-68 branch.

Wait for the context menu refactoring to land.
Labels: -M-68 M-69
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d775506241f1de12775567de4f153e736c73b72

commit 0d775506241f1de12775567de4f153e736c73b72
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Jun 14 23:53:33 2018

cros: Show selection highlight on shelf when a menu shows

Per UX Request:
For all MenuShowSource types, show a highlight when a menu is shown.

This was already working for touch menus.

This also fixes the bug where the ink drop bubble was "Bursting"
regardless of the prior ink drop state.

Bug:  844779 
Change-Id: I715300a7447ad099b6a610b34e8a30a2170d6e4c
Reviewed-on: https://chromium-review.googlesource.com/1095637
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567488}
[modify] https://crrev.com/0d775506241f1de12775567de4f153e736c73b72/ash/shelf/shelf_button.cc
[modify] https://crrev.com/0d775506241f1de12775567de4f153e736c73b72/ash/shelf/shelf_view.cc
[modify] https://crrev.com/0d775506241f1de12775567de4f153e736c73b72/ash/shelf/shelf_view_unittest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment