New issue
Advanced search Search tips

Issue 844776 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

Shelf and Shelf Button user journey metrics are not being recorded properly

Project Member Reported by newcomer@chromium.org, May 18 2018

Issue description

All in the title.
Apps.ContextMenuUserJourneyTime.Shelf(Button)
 
Cc: omrilio@chromium.org
Owner: newcomer@chromium.org
Labels: Touch-Friendly-Launcher-Urgent
Labels: M-68 Pri-1
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a1c14104a765e1e1a9114a2287791bfd8fc4c27

commit 8a1c14104a765e1e1a9114a2287791bfd8fc4c27
Author: Alex Newcomer <newcomer@chromium.org>
Date: Wed Jun 20 17:26:36 2018

cros: Record shelf context menu user journey time.

Adressing an old TODO, and fixing a bug which recorded shelf menus as
app menus.

Bug: 845273
Bug:  844776 
Change-Id: Ia6156ae597f724631b60909cde68067a9a49ced9
Reviewed-on: https://chromium-review.googlesource.com/1102906
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568895}
[modify] https://crrev.com/8a1c14104a765e1e1a9114a2287791bfd8fc4c27/ash/shelf/shelf_menu_model_adapter.cc

Labels: Merge-Request-68
This CL is a metrics bug fix. 
Labels: -Merge-Request-68 Merge-Approved-68
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 25 2018

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-68
No need to merge this after all.
Status: Fixed (was: Untriaged)

Sign in to add a comment