New issue
Advanced search Search tips

Issue 844769 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Differences in UI for Mac, Linux, and Windows

Project Member Reported by jdicroce@google.com, May 18 2018

Issue description

Chrome Version:
OS: Latest versions of Mac, Windows, Linux

Hi Shimi,

See screenshot for the differences in "Reset your browser settings" UI across Mac, Linux, and Windows. https://screenshot.googleplex.com/E7DEBUgdvHC

It would be great if the instructions here could be consistent for every platform. It seems like with Windows it might not be possible given the clean up tool.

HC Article: https://support.google.com/chrome/answer/2765944?hl=en

Let me know if you have any questions. Thanks!

 
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Owner: ftirelo@chromium.org
Fabio, could you take a look at the screenshot in c#1? It looks like the help instructions are incorrect. Based on the strings I see, I think we should show:

-a set of instructions for Win and Chrome OS, where Chrome cleanup tool is available
-a set of instructions for Mac and Linux, which don't have Chrome cleanup tool

Strings:
<!-- Reset Settings Page -->
  <message name="IDS_SETTINGS_RESET" desc="Title for an item in the 'Reset and clean up' section of Chrome Settings. If the user clicks this option, browser settings will be returned to their default values, after a confirmation by the user." meaning="Chrome Cleanup feature. Try to use the same translation for 'Reset' in 'Reset and cleanup' string.">
    Reset settings
  </message>
  <message name="IDS_SETTINGS_RESET_SETTINGS_TRIGGER" desc="The label describing the 'reset profile setting' feature">
    Restore settings to their original defaults
  </message>
  <message name="IDS_SETTINGS_RESET_AUTOMATED_DIALOG_TITLE" desc="The title of the dialog informing the user that automated resetting of some settings occurred.">
    Some settings were reset
  </message>
  <message name="IDS_SETTINGS_RESET_BANNER_TEXT" desc="The text to show in a banner at the top of the chrome://settings page. The banner is displayed when Chrome detects that some settings have been tampered with and were reset to factory defaults.">
    Chrome detected that some of your settings were corrupted by another program and reset them to their original defaults.
  </message>
  <message name="IDS_SETTINGS_RESET_BANNER_RESET_BUTTON_TEXT" desc="The text on the reset button in the Automatic Settings Reset Banner suggesting to reset ALL settings after an automatic reset of SOME settings.">
    Reset all settings
  </message>

  <!-- Reset card title and Chrome Cleanup item on Windows -->
  <if expr="is_win and _google_chrome">
    <message name="IDS_SETTINGS_RESET_AND_CLEANUP" desc="Title of a section in Chrome Settings. Imperative. 'Reset' refers to resetting settings to defaults. 'Clean up' refers to cleaning up harmful software on the user's computer.">
      Reset and clean up
    </message>
    <message name="IDS_SETTINGS_RESET_CLEAN_UP_COMPUTER_TRIGGER" desc="Title for an item in the 'Reset and clean up' section of Chrome Settings. 'Clean up' refers to cleaning up harmful software on the user's computer. Imperative.">
      Clean up computer
    </message>
  </if>
Cc: srahim@chromium.org
Cc: ftirelo@chromium.org
Owner: csharp@chromium.org
+csharp@ for triage

The Chrome Cleanup Tool is only available on Windows. The condition you see in the grdp file ("is_win and _google_chrome") means that the string only exists on Windows for official Google Chrome builds (not ChromeOS).

On Windows, users will see both "Restore settings to their original defaults" and "Clean up computer". On all other platforms, only the former will be shown.

The HC article needs to be updated to reflect this. For some reason I didn't notice the inconsistency when we launched this.
Components: UI>Browser>Preferences>Protector
Components: -UI>Browser>Preferences>Protector Services>Safebrowsing>ChromeCleanup
Labels: SafeBrowsing-Triaged
It looks like the strings for non-Windows platforms are all the same, so I think the HC article should say:

Windows: Under "Reset and cleanup", click Restore settings to their original defaults
Mac, Linux or Chromebook: Under "Reset", click Restore settings to their original defaults

So I think this just requires a small change to the HC article.

The HC is out of date now because this bug was created in May when the UI strings used to look like the screenshot in the request I originally submitted.

I will update the HC article and this bug can be closed.

Thanks!

Sign in to add a comment