New issue
Advanced search Search tips

Issue 844764 link

Starred by 3 users
Status: Assigned
Owner:
rockot@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 2
Type: Bug

Blocked on:
issue 822034
issue 844231
Blocking:
issue 844766



Sign in to add a comment

Port non-chromium code away from EDK usage

Project Member Reported by roc...@chromium.org, May 18 2018 
Once we have a working invitation API and libchrome is uprevved past it, we should migrate all EDK consumers outside of the chromium tree to use the public initialization and invitation APIs instead of direct EDK calls.

Finally, we should remove mojo/edk from libchrome.

Comment 1 by roc...@chromium.org, May 18 2018

Blocking: 844766
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f10d746929edc6c5afb0d513f5340bf50e1cce4f

commit f10d746929edc6c5afb0d513f5340bf50e1cce4f
Author: Ken Rockot <rockot@chromium.org>
Date: Tue May 22 03:40:05 2018

Mojo: Rename EDK PlatformHandle -> InternalPlatformHandle

This is in preparation for introducing a public PlatformHandle API in
mojo/public/cpp/platform.

Purely symbol renames. No header move because all header references
outside of mojo/edk are going to change soon anyway. No functional
changes.

The public API will be cleaner than the EDK one, but the EDK one is
pretty well entrenched at this point. We'll split the two for now,
and relegate InternalPlatformHandle/ScopedInternalPlatformHandle to
internal EDK usage only, once the public API lands.

TBR=jcivelli@chromium.org
TBR=sky@chromium.org
TBR=miu@chromium.org

Bug: 844764
Change-Id: I206602f1a6966367f19159fda29aa4337b9470d6
Reviewed-on: https://chromium-review.googlesource.com/1068265
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560475}
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/apps/app_shim/app_shim_host_mac.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/apps/app_shim/app_shim_host_mac.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/apps/app_shim/app_shim_host_manager_mac.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/chromeos/arc/print/arc_print_service.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/chromeos/arc/video/gpu_arc_video_service_host.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/browser/service_process/service_process_control.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/common/service_process_util.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/common/service_process_util_mac.mm
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/service/service_process.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/service/service_process.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/service/service_utility_process_host.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/chromeos/components/drivefs/drivefs_host.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/arc/arc_session_impl.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/arc/crash_collector/arc_crash_collector_bridge.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/arc/midis/arc_midis_bridge.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/arc/test/fake_file_system_instance.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/arc/usb/usb_host_bridge.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/nacl/broker/nacl_broker_listener.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/nacl/common/nacl_service.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/connection_manager.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/public/cpp/sender_pipe.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/public/cpp/sender_pipe_posix.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/public/cpp/sender_pipe_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/public/cpp/sender_pipe_win.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/receiver_pipe.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/receiver_pipe.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/receiver_pipe_posix.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/receiver_pipe_posix.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/receiver_pipe_win.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/components/services/heap_profiling/receiver_pipe_win.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/content/browser/child_process_launcher_helper_fuchsia.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/content/browser/child_process_launcher_helper_linux.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/content/browser/child_process_launcher_helper_posix.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/content/browser/child_process_launcher_helper_posix.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/content/browser/child_process_launcher_helper_win.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/content/child/child_thread_impl.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/media/capture/video/chromeos/camera_hal_dispatcher_impl.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/media/capture/video/chromeos/camera_hal_dispatcher_impl.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/media/capture/video/chromeos/stream_buffer_manager.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/README.md
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/connection_params.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/connection_params.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/embedder.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/embedder.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/embedder_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/entrypoints.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/incoming_broker_client_invitation.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/named_platform_channel_pair.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/named_platform_channel_pair_win.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/named_platform_handle_utils.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/named_platform_handle_utils_fuchsia.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/named_platform_handle_utils_posix.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/named_platform_handle_utils_win.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_channel_pair.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_channel_pair.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_channel_pair_fuchsia.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_channel_pair_posix.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_channel_pair_posix_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_channel_pair_win.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_channel_utils_posix.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_channel_utils_posix.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_handle.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_handle.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_handle_utils.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_handle_utils.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_handle_utils_fuchsia.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_handle_utils_posix.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/platform_handle_utils_win.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/embedder/scoped_platform_handle.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/broker.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/broker_host.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/broker_host.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/broker_posix.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/broker_win.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/channel.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/channel.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/channel_fuchsia.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/channel_posix.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/channel_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/channel_win.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/core.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/core.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/data_pipe_consumer_dispatcher.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/data_pipe_consumer_dispatcher.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/data_pipe_producer_dispatcher.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/data_pipe_producer_dispatcher.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/dispatcher.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/dispatcher.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/invitation_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/mach_port_relay.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/mach_port_relay.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/message_pipe_dispatcher.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/message_pipe_dispatcher.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/message_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/multiprocess_message_pipe_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/node_channel.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/node_channel.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/node_controller.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/node_controller.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/platform_handle_dispatcher.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/platform_handle_dispatcher.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/platform_handle_dispatcher_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/platform_wrapper_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/shared_buffer_dispatcher.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/shared_buffer_dispatcher.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/system/user_message_impl.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/test/multiprocess_test_helper.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/test/multiprocess_test_helper_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/test/test_utils.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/test/test_utils_fuchsia.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/test/test_utils_posix.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/mojo/edk/test/test_utils_win.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/remoting/host/desktop_process_main.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/remoting/host/security_key/fake_security_key_ipc_client.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/remoting/host/security_key/security_key_ipc_client.h
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/remoting/host/security_key/security_key_ipc_server_unittest.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/remoting/host/win/wts_session_process_delegate.cc
[modify] https://crrev.com/f10d746929edc6c5afb0d513f5340bf50e1cce4f/tools/ipc_fuzzer/message_replay/replay_process.cc
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/956b32c065e79b9389ac392dea0cc6bc27df8ce2

commit 956b32c065e79b9389ac392dea0cc6bc27df8ce2
Author: Ken Rockot <rockot@chromium.org>
Date: Tue May 22 16:21:48 2018

Mojo: Support named pipes for invitation transport

Adds a CHANNEL_SERVER invitation transport type allowing public API
consumers to use connection-based primitives (e.g. domain socket
servers) as invitation transport endpoints.

This corresponds to current usaged of the EDK's NamedPlatformChannelPair
and related utilities, which will soon be moved into the public library.

Bug: 844764
Change-Id: Ib11913735e7ca2a138aa534edbb1b7dcb6111216
Reviewed-on: https://chromium-review.googlesource.com/1067938
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560635}
[modify] https://crrev.com/956b32c065e79b9389ac392dea0cc6bc27df8ce2/mojo/edk/BUILD.gn
[rename] https://crrev.com/956b32c065e79b9389ac392dea0cc6bc27df8ce2/mojo/edk/embedder/named_platform_channel_pair.cc
[modify] https://crrev.com/956b32c065e79b9389ac392dea0cc6bc27df8ce2/mojo/edk/embedder/named_platform_channel_pair.h
[modify] https://crrev.com/956b32c065e79b9389ac392dea0cc6bc27df8ce2/mojo/edk/system/core.cc
[modify] https://crrev.com/956b32c065e79b9389ac392dea0cc6bc27df8ce2/mojo/edk/system/invitation_unittest.cc
[modify] https://crrev.com/956b32c065e79b9389ac392dea0cc6bc27df8ce2/mojo/public/c/system/invitation.h
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1

commit 1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1
Author: Ken Rockot <rockot@chromium.org>
Date: Wed May 23 01:02:40 2018

Introduce public PlatformHandle type

Adds mojo/public/cpp/platform to the public library. This includes
a new PlatformHandle type, a thin C++ abstraction for platform-specific
scoped handle values.

This is a precursor to moving platform channel C++ types out of the EDK
and into the public library, and ultimately introducing a public C++
invitation API to replace the EDK invitation API.

Bug: 844764
Change-Id: I317decc1deb8cc47eb1000a6a19022465c392d7b
Reviewed-on: https://chromium-review.googlesource.com/1068688
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560866}
[modify] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/BUILD.gn
[modify] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/edk/BUILD.gn
[modify] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/edk/embedder/platform_handle_utils.h
[modify] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/DEPS
[add] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/cpp/platform/BUILD.gn
[add] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/cpp/platform/DEPS
[add] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/cpp/platform/platform_handle.cc
[add] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/cpp/platform/platform_handle.h
[add] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/cpp/platform/tests/BUILD.gn
[add] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/cpp/platform/tests/DEPS
[add] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/cpp/platform/tests/platform_handle_unittest.cc
[modify] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/cpp/system/BUILD.gn
[modify] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/cpp/system/platform_handle.cc
[modify] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/cpp/system/platform_handle.h
[add] https://crrev.com/1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1/mojo/public/tools/fuzzers/DEPS
Project Member

Comment 5 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdc9eaea916f94b89d876cc66dc70e200c7a854b

commit bdc9eaea916f94b89d876cc66dc70e200c7a854b
Author: Ken Rockot <rockot@chromium.org>
Date: Wed May 23 01:24:08 2018

Revert "Introduce public PlatformHandle type"

This reverts commit 1bdfba5826e27ff0812b0a6011c4bca6ff3a73c1.

Reason for revert: broke fuchsia
Original change's description:
> Introduce public PlatformHandle type
> 
> Adds mojo/public/cpp/platform to the public library. This includes
> a new PlatformHandle type, a thin C++ abstraction for platform-specific
> scoped handle values.
> 
> This is a precursor to moving platform channel C++ types out of the EDK
> and into the public library, and ultimately introducing a public C++
> invitation API to replace the EDK invitation API.
> 
> Bug: 844764
> Change-Id: I317decc1deb8cc47eb1000a6a19022465c392d7b
> Reviewed-on: https://chromium-review.googlesource.com/1068688
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560866}

TBR=jcivelli@chromium.org,rockot@chromium.org

Change-Id: If401afe09a2e91d5e2a0035a75db5490a41259ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 844764
Reviewed-on: https://chromium-review.googlesource.com/1068219
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560876}
[modify] https://crrev.com/bdc9eaea916f94b89d876cc66dc70e200c7a854b/mojo/BUILD.gn
[modify] https://crrev.com/bdc9eaea916f94b89d876cc66dc70e200c7a854b/mojo/edk/BUILD.gn
[modify] https://crrev.com/bdc9eaea916f94b89d876cc66dc70e200c7a854b/mojo/edk/embedder/platform_handle_utils.h
[modify] https://crrev.com/bdc9eaea916f94b89d876cc66dc70e200c7a854b/mojo/public/DEPS
[delete] https://crrev.com/4563ced33ec2270253404a107b43652b0b1c4207/mojo/public/cpp/platform/BUILD.gn
[delete] https://crrev.com/4563ced33ec2270253404a107b43652b0b1c4207/mojo/public/cpp/platform/DEPS
[delete] https://crrev.com/4563ced33ec2270253404a107b43652b0b1c4207/mojo/public/cpp/platform/platform_handle.cc
[delete] https://crrev.com/4563ced33ec2270253404a107b43652b0b1c4207/mojo/public/cpp/platform/platform_handle.h
[delete] https://crrev.com/4563ced33ec2270253404a107b43652b0b1c4207/mojo/public/cpp/platform/tests/BUILD.gn
[delete] https://crrev.com/4563ced33ec2270253404a107b43652b0b1c4207/mojo/public/cpp/platform/tests/DEPS
[delete] https://crrev.com/4563ced33ec2270253404a107b43652b0b1c4207/mojo/public/cpp/platform/tests/platform_handle_unittest.cc
[modify] https://crrev.com/bdc9eaea916f94b89d876cc66dc70e200c7a854b/mojo/public/cpp/system/BUILD.gn
[modify] https://crrev.com/bdc9eaea916f94b89d876cc66dc70e200c7a854b/mojo/public/cpp/system/platform_handle.cc
[modify] https://crrev.com/bdc9eaea916f94b89d876cc66dc70e200c7a854b/mojo/public/cpp/system/platform_handle.h
[delete] https://crrev.com/4563ced33ec2270253404a107b43652b0b1c4207/mojo/public/tools/fuzzers/DEPS
Project Member

Comment 6 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e33a6b0896afe2992c8e86dff4aef56ff4e76b12

commit e33a6b0896afe2992c8e86dff4aef56ff4e76b12
Author: Ken Rockot <rockot@chromium.org>
Date: Wed May 23 03:13:26 2018

[reland] Mojo: Introduce public PlatformHandle type

Reland of r560866, which was missing an include for Fuchsia in some
configs.

Adds mojo/public/cpp/platform to the public library. This includes
a new PlatformHandle type, a thin C++ abstraction for platform-specific
scoped handle values.

This is a precursor to moving platform channel C++ types out of the EDK
and into the public library, and ultimately introducing a public C++
invitation API to replace the EDK invitation API.

TBR=jcivelli@chromium.org

Bug: 844764
Change-Id: I86a04e27afd1c7ec7a3c1d419f10239d4b78c850
Reviewed-on: https://chromium-review.googlesource.com/1069839
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560915}
[modify] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/BUILD.gn
[modify] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/edk/BUILD.gn
[modify] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/edk/embedder/platform_handle_utils.h
[modify] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/DEPS
[add] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/cpp/platform/BUILD.gn
[add] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/cpp/platform/DEPS
[add] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/cpp/platform/platform_handle.cc
[add] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/cpp/platform/platform_handle.h
[add] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/cpp/platform/tests/BUILD.gn
[add] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/cpp/platform/tests/DEPS
[add] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/cpp/platform/tests/platform_handle_unittest.cc
[modify] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/cpp/system/BUILD.gn
[modify] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/cpp/system/platform_handle.cc
[modify] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/cpp/system/platform_handle.h
[add] https://crrev.com/e33a6b0896afe2992c8e86dff4aef56ff4e76b12/mojo/public/tools/fuzzers/DEPS
Project Member

Comment 7 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6

commit 60f9ae4d892022f021c9d740dca8e2dd9efe1fc6
Author: Ken Rockot <rockot@chromium.org>
Date: Thu May 24 20:58:49 2018

Introduce public PlatformChannel and NamedPlatformChannel

These are cleaned-up versions of the EDK's PlatformChannelPair and
NamedPlatformChannelPair, which will be removed but remain untouched for
the moment. Most of the logic is duplicated verbatim, modulo cleanup.

For test coverage, since actual I/O operations are not being ported to
the public library, the new types are used in place of EDK types within
the invitation API tests.

Bug: 844764
Change-Id: Ieeea396370e37d4fa3a0e9a65b6f9b71855b85fc
Reviewed-on: https://chromium-review.googlesource.com/1068652
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561624}
[modify] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/edk/system/invitation_unittest.cc
[modify] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/BUILD.gn
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/named_platform_channel.cc
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/named_platform_channel.h
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/named_platform_channel_fuchsia.cc
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/named_platform_channel_posix.cc
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/named_platform_channel_win.cc
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/platform_channel.cc
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/platform_channel.h
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/platform_channel_endpoint.cc
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/platform_channel_endpoint.h
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/platform_channel_server_endpoint.cc
[add] https://crrev.com/60f9ae4d892022f021c9d740dca8e2dd9efe1fc6/mojo/public/cpp/platform/platform_channel_server_endpoint.h
Project Member

Comment 9 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/756098194b7c43be9940edd0bd556f90f05b9029

commit 756098194b7c43be9940edd0bd556f90f05b9029
Author: Ken Rockot <rockot@chromium.org>
Date: Fri May 25 16:13:07 2018

Migrate Service Manager to public invitation API

Migrates Service Manager away from the EDK invitation API and over to
the new public API.

Mostly a PoC CL for porting the old stuff to the new stuff, but this
also means that Service Manager now only depends on EDK for
initialization.

Bug:  844763 ,844764
Change-Id: I10e40a95fdd4760cabd537b2a4ac4c56fb4e33e1
Reviewed-on: https://chromium-review.googlesource.com/1070533
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561898}
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/content/browser/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/public/cpp/standalone_service/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/public/cpp/standalone_service/standalone_service.cc
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/common/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/common/client_util.cc
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/common/client_util.h
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/host/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/host/service_process_launcher.cc
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/host/service_process_launcher.h
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/standalone/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/tests/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/tests/service_manager/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/tests/service_manager/service_manager_unittest.cc
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/tests/util.cc

Comment 10 by roc...@chromium.org, Oct 17

Owner: rockot@google.com
►

Sign in to add a comment