New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 844763 link

Starred by 4 users
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 844766



Sign in to add a comment

Move mojo/edk/embedder stuff to public API

Project Member Reported by roc...@chromium.org, May 18 2018 
A lot of stuff private to the EDK does not need to be private, and will be useful to consumers of the new Mojo invitation API once landed.

This is stuff like PlatformChannelPair, ScopedPlatformHandle, and various utility functions.

We should introduce mojo/public/cpp/platform_support for this stuff, and then we can also build a C++ invitation API in mojo/public/cpp/system, based on platform_support and the C invitation API.

All direct EDK calls apart from basic initialization can then be migrated over to public API calls.

Comment 1 by roc...@chromium.org, May 18 2018

Blocking: 844766
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/189566cde90c8b255de5c315a919a80a0e627cc4

commit 189566cde90c8b255de5c315a919a80a0e627cc4
Author: Ken Rockot <rockot@chromium.org>
Date: Thu May 24 21:04:17 2018

Mojo: Additions to invitation C API

Two new things:

  * It is probably infeasible (at least not worth the effort) to migrate
    some consumers away from using arbitrary strings as invitation
    attachment names. Reverts the Attach/Extract calls to supporting
    arbitrary byte strings as names rather than limiting names to
    64-bit ints.

  * Adds a disconnect indicator flag to MojoProcessErrorDetails to
    convey that no more invocations of the process error handler will
    occur for a given invitee. This allows more interesting uses of the
    provided context value, e.g. to have it represent an owned heap
    allocation, because there is now at least one guaranteed invocation
    of the handler and the final invocation will always set the
    disconnected flag.

Bug:  844763 
Change-Id: Ic8d951cb376c1ef746942bdef1de1856d74d6cbd
Reviewed-on: https://chromium-review.googlesource.com/1069571
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561629}
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/edk/embedder/entrypoints.cc
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/edk/system/core.cc
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/edk/system/core.h
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/edk/system/dispatcher.cc
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/edk/system/dispatcher.h
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/edk/system/invitation_dispatcher.cc
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/edk/system/invitation_dispatcher.h
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/edk/system/invitation_unittest.cc
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/public/c/system/invitation.h
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/public/c/system/thunks.cc
[modify] https://crrev.com/189566cde90c8b255de5c315a919a80a0e627cc4/mojo/public/c/system/thunks.h
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/756098194b7c43be9940edd0bd556f90f05b9029

commit 756098194b7c43be9940edd0bd556f90f05b9029
Author: Ken Rockot <rockot@chromium.org>
Date: Fri May 25 16:13:07 2018

Migrate Service Manager to public invitation API

Migrates Service Manager away from the EDK invitation API and over to
the new public API.

Mostly a PoC CL for porting the old stuff to the new stuff, but this
also means that Service Manager now only depends on EDK for
initialization.

Bug:  844763 ,844764
Change-Id: I10e40a95fdd4760cabd537b2a4ac4c56fb4e33e1
Reviewed-on: https://chromium-review.googlesource.com/1070533
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561898}
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/content/browser/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/public/cpp/standalone_service/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/public/cpp/standalone_service/standalone_service.cc
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/common/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/common/client_util.cc
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/common/client_util.h
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/host/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/host/service_process_launcher.cc
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/runner/host/service_process_launcher.h
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/standalone/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/tests/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/tests/service_manager/BUILD.gn
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/tests/service_manager/service_manager_unittest.cc
[modify] https://crrev.com/756098194b7c43be9940edd0bd556f90f05b9029/services/service_manager/tests/util.cc
Project Member

Comment 4 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/799bff0641ced34875e185c785133078db0170ca

commit 799bff0641ced34875e185c785133078db0170ca
Author: Ken Rockot <rockot@chromium.org>
Date: Wed May 30 14:23:53 2018

Mojo: Migrate code from EDK to public API

There are public platform support and invitation APIs available in Mojo
now, and they should be used exclusively in lieu of the old EDK APIs
where possible.

This converts most uses of the old APIs to the new ones.

Note that there should be no functional difference in any of these
components, and this does not change the underlying behavior of the
system, e.g. internal IPC protocol is unchanged.

Bug:  844763 
Change-Id: I878f103041758d130c34bde046fa054b984feb8c
Reviewed-on: https://chromium-review.googlesource.com/1070882
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562811}
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chrome/browser/chromeos/arc/video/gpu_arc_video_service_host.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_process_win.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chrome/service/BUILD.gn
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chrome/service/service_utility_process_host.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chrome/service/service_utility_process_host.h
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/chromeos/components/drivefs/drivefs_host.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/components/arc/BUILD.gn
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/components/arc/arc_session_impl.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/components/arc/midis/arc_midis_bridge.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/components/arc/timer/arc_timer_struct_traits.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/components/nacl/broker/nacl_broker_listener.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/media/capture/video/chromeos/camera_device_delegate.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/media/capture/video/chromeos/camera_hal_dispatcher_impl.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/media/capture/video/chromeos/camera_hal_dispatcher_impl.h
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/media/capture/video/chromeos/stream_buffer_manager.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/mojo/public/cpp/system/platform_handle.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/mojo/public/cpp/system/platform_handle.h
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/remoting/host/win/BUILD.gn
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/remoting/host/win/unprivileged_process_delegate.cc
[modify] https://crrev.com/799bff0641ced34875e185c785133078db0170ca/remoting/host/win/wts_session_process_delegate.cc
Project Member

Comment 5 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe962bac228f779fe156260dbf0bf28bfb208a30

commit fe962bac228f779fe156260dbf0bf28bfb208a30
Author: Ken Rockot <rockot@chromium.org>
Date: Wed May 30 16:32:42 2018

Mojo: Delete IncomingBrokerClientConnection

This is fully replaced by the public IncomingInvitation type.

Bug:  844763 
Change-Id: I7eb07f0c3ca04f5670d30ef0ce3631d0cc2a06c5
Reviewed-on: https://chromium-review.googlesource.com/1071228
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562862}
[modify] https://crrev.com/fe962bac228f779fe156260dbf0bf28bfb208a30/components/nacl/common/nacl_service.cc
[modify] https://crrev.com/fe962bac228f779fe156260dbf0bf28bfb208a30/content/child/child_thread_impl.cc
[modify] https://crrev.com/fe962bac228f779fe156260dbf0bf28bfb208a30/content/child/child_thread_impl.h
[modify] https://crrev.com/fe962bac228f779fe156260dbf0bf28bfb208a30/mojo/edk/BUILD.gn
[delete] https://crrev.com/081207b3e56e98b717c8f507b45a2a01a424904a/mojo/edk/embedder/incoming_broker_client_invitation.cc
[delete] https://crrev.com/081207b3e56e98b717c8f507b45a2a01a424904a/mojo/edk/embedder/incoming_broker_client_invitation.h
[modify] https://crrev.com/fe962bac228f779fe156260dbf0bf28bfb208a30/mojo/edk/test/multiprocess_test_helper.cc
[modify] https://crrev.com/fe962bac228f779fe156260dbf0bf28bfb208a30/remoting/host/desktop_process_main.cc
[modify] https://crrev.com/fe962bac228f779fe156260dbf0bf28bfb208a30/remoting/host/remoting_me2me_host.cc
[modify] https://crrev.com/fe962bac228f779fe156260dbf0bf28bfb208a30/tools/ipc_fuzzer/message_replay/DEPS
[modify] https://crrev.com/fe962bac228f779fe156260dbf0bf28bfb208a30/tools/ipc_fuzzer/message_replay/replay_process.cc
[modify] https://crrev.com/fe962bac228f779fe156260dbf0bf28bfb208a30/tools/ipc_fuzzer/message_replay/replay_process.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/026afc357b02f3b1d24f5113908f355d7d015174

commit 026afc357b02f3b1d24f5113908f355d7d015174
Author: Ken Rockot <rockot@chromium.org>
Date: Mon Jun 04 19:19:18 2018

Mojo: Delete OutgoingBrokerClientInvitation

This EDK type is replaced with OutgoingInvitation in the public API.
All remaining consumers of the EDK type are migrated to the public
API in this CL, and the EDK type is deleted.

Bug:  844763 
Change-Id: Ifc7bc48253bb725e7ce5e23fbb64c03d7c1ff74f
Reviewed-on: https://chromium-review.googlesource.com/1073079
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564180}
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/browser_child_process_host_impl.h
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher.h
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher_helper.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher_helper_fuchsia.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher_helper_linux.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher_helper_posix.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher_helper_posix.h
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/child_process_launcher_helper_win.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/browser/utility_process_host.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/child/child_thread_impl.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/child/child_thread_impl.h
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/common/in_process_child_thread_params.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/common/in_process_child_thread_params.h
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/common/service_manager/child_connection.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/common/service_manager/child_connection.h
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/edk/BUILD.gn
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/edk/embedder/embedder_unittest.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/edk/system/core.h
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/edk/system/handle_table.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/edk/system/multiprocess_message_pipe_unittest.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/edk/test/multiprocess_test_helper.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/public/cpp/platform/named_platform_channel.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/public/cpp/platform/named_platform_channel.h
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/public/cpp/platform/platform_channel.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/public/cpp/system/invitation.cc
[modify] https://crrev.com/026afc357b02f3b1d24f5113908f355d7d015174/mojo/public/cpp/system/tests/invitation_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7f7c2e1974bef481afcf7482dea902ff78ba4f5

commit f7f7c2e1974bef481afcf7482dea902ff78ba4f5
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Jun 06 23:21:02 2018

Mojo: Delete GenerateRandomToken()

There's no reason for Mojo to provide this API.

Bug:  844763 
Change-Id: I32e9e92f82e55564273961f3f59dd15677125e81
Reviewed-on: https://chromium-review.googlesource.com/1086035
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565088}
[modify] https://crrev.com/f7f7c2e1974bef481afcf7482dea902ff78ba4f5/components/arc/arc_session_impl.cc
[modify] https://crrev.com/f7f7c2e1974bef481afcf7482dea902ff78ba4f5/media/capture/video/chromeos/camera_hal_dispatcher_impl.cc
[modify] https://crrev.com/f7f7c2e1974bef481afcf7482dea902ff78ba4f5/mojo/edk/BUILD.gn
[modify] https://crrev.com/f7f7c2e1974bef481afcf7482dea902ff78ba4f5/mojo/edk/embedder/embedder.cc
[modify] https://crrev.com/f7f7c2e1974bef481afcf7482dea902ff78ba4f5/mojo/edk/embedder/embedder.h
[modify] https://crrev.com/f7f7c2e1974bef481afcf7482dea902ff78ba4f5/mojo/edk/embedder/embedder_unittest.cc
[modify] https://crrev.com/f7f7c2e1974bef481afcf7482dea902ff78ba4f5/mojo/edk/test/multiprocess_test_helper.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/277b84c78cf0305e815735da3c01217d1381d24a

commit 277b84c78cf0305e815735da3c01217d1381d24a
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Jun 08 09:39:48 2018

Mojo: Add support for isolated invitations

As a replacement for the EDK peer connection API, this CL adds a
notion of isolated Mojo invitations by supporting a new flag on
MojoSendInvitation and MojoAcceptInvitation. Isolated invitations
allow two processes to communicate via Mojo without joining each
others' process graph.

A follow-up change will convert all uses of PeerConnection to the
new API.

Bug:  844763 
Change-Id: I5966f83c4077da28bce8b2b3224d4f4efe9a4c3d
Reviewed-on: https://chromium-review.googlesource.com/1090233
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565595}
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/embedder/embedder_unittest.cc
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/embedder/peer_connection.cc
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/embedder/peer_connection.h
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/system/core.cc
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/system/core.h
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/system/invitation_unittest.cc
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/system/node_controller.cc
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/system/node_controller.h
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/test/mojo_test_base.cc
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/test/mojo_test_base.h
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/test/multiprocess_test_helper.cc
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/edk/test/multiprocess_test_helper.h
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/public/c/system/invitation.h
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/public/cpp/platform/platform_channel.cc
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/public/cpp/system/invitation.cc
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/public/cpp/system/invitation.h
[modify] https://crrev.com/277b84c78cf0305e815735da3c01217d1381d24a/mojo/public/cpp/system/tests/invitation_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb702254f4a838a7f00cfbf80db533fcbccb458

commit fbb702254f4a838a7f00cfbf80db533fcbccb458
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Jun 14 17:25:53 2018

mojo: edk::PeerConnection -> IsolatedConnection

Introduces a public IsolatedConnection helper as a replacement for the
EDK PeerConnection type. A follow-up C will convert existing uses.

Mojo multiprocess tests are converted to use the new type here,
removing the last remnants of EDK dependency from the test multiprocess
test support code.

This also deletes some dead test code and opportunistically converts a
few related uses of the internal EDK ScopedInternalPlatformHandle type
to the newer public PlatformHandle type.

Bug:  844763 
Change-Id: Icad97f51d320381483e474c16077ef7844cc2b9d
Reviewed-on: https://chromium-review.googlesource.com/1099269
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567323}
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/embedder/platform_channel_pair_posix_unittest.cc
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/system/multiprocess_message_pipe_unittest.cc
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/system/platform_handle_dispatcher_unittest.cc
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/test/BUILD.gn
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/test/mojo_test_base.cc
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/test/mojo_test_base.h
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/test/multiprocess_test_helper.cc
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/test/multiprocess_test_helper.h
[delete] https://crrev.com/20e467b2bb422370eb3447d7e9fa6aff40258d78/mojo/edk/test/multiprocess_test_helper_unittest.cc
[add] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/test/test_utils.cc
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/test/test_utils.h
[delete] https://crrev.com/20e467b2bb422370eb3447d7e9fa6aff40258d78/mojo/edk/test/test_utils_fuchsia.cc
[delete] https://crrev.com/20e467b2bb422370eb3447d7e9fa6aff40258d78/mojo/edk/test/test_utils_posix.cc
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/edk/test/test_utils_win.cc
[modify] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/public/cpp/system/BUILD.gn
[add] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/public/cpp/system/isolated_connection.cc
[add] https://crrev.com/fbb702254f4a838a7f00cfbf80db533fcbccb458/mojo/public/cpp/system/isolated_connection.h
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3bda16831ad4dff89fbf2317e194b70aad2b5ea

commit d3bda16831ad4dff89fbf2317e194b70aad2b5ea
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Jun 14 17:34:22 2018

Migrate assorted bits from Mojo EDK to public APIs

Migrates Mac app shim support and security key remoting code away
from internal EDK APIs and over to newer, functionally equivalent
public APIs.

No functional changes here, just swapping out old types for new ones
and updating dependencies appropriately.

Note that this also duplicates some internal EDK code into the public
Mojo platform library. This code is shared by a few unrelated
parts of Chrome and really has nothing to do with Mojo, but there's
not a better home for it yet.

Bug:  844763 
Change-Id: I40e7ff08f01d513fb046dc636ba3e4b1db1dbad2
Reviewed-on: https://chromium-review.googlesource.com/1099726
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567330}
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/chrome/app_shim/chrome_main_app_mode_mac.mm
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/chrome/browser/apps/app_shim/app_shim_host_mac.cc
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/chrome/browser/apps/app_shim/app_shim_host_mac.h
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/chrome/browser/apps/app_shim/app_shim_host_manager_mac.h
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.cc
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/mojo/public/cpp/platform/BUILD.gn
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/mojo/public/cpp/platform/named_platform_channel.cc
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/mojo/public/cpp/platform/named_platform_channel.h
[add] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/mojo/public/cpp/platform/socket_utils_posix.cc
[add] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/mojo/public/cpp/platform/socket_utils_posix.h
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/BUILD.gn
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/fake_security_key_ipc_client.cc
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/fake_security_key_ipc_client.h
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/fake_security_key_ipc_server.cc
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/fake_security_key_ipc_server.h
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/security_key_auth_handler_win_unittest.cc
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/security_key_ipc_client.cc
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/security_key_ipc_client.h
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/security_key_ipc_client_unittest.cc
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/security_key_ipc_constants.cc
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/security_key_ipc_constants.h
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/security_key_ipc_server.h
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/security_key_ipc_server_impl.cc
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/security_key_ipc_server_impl.h
[modify] https://crrev.com/d3bda16831ad4dff89fbf2317e194b70aad2b5ea/remoting/host/security_key/security_key_ipc_server_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8f79389880aa9a3412caebced337a42b98bf0b

commit fa8f79389880aa9a3412caebced337a42b98bf0b
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Jun 14 17:40:35 2018

Remove all ARC dependencies on Mojo EDK

Replaces all EDK usage for ARC-related components with public Mojo
API calls. No functional changes.

Also cleans up relevant DEPS and GN deps.

Bug:  844763 
Change-Id: I1cab5ed08bcb08049b4648e3fb4c28664fb04bf7
TBR: jcliang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1100041
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567334}
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/chrome/browser/chromeos/DEPS
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.cc
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/chrome/browser/chromeos/arc/print/arc_print_service.cc
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/components/arc/BUILD.gn
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/components/arc/arc_session_impl.cc
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/components/arc/crash_collector/arc_crash_collector_bridge.cc
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/components/arc/test/fake_file_system_instance.cc
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/components/arc/usb/usb_host_bridge.cc
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/components/arc/video_accelerator/DEPS
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/media/capture/BUILD.gn
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/media/capture/video/chromeos/DEPS
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/media/capture/video/chromeos/camera_hal_dispatcher_impl.cc
[modify] https://crrev.com/fa8f79389880aa9a3412caebced337a42b98bf0b/media/capture/video/chromeos/camera_hal_dispatcher_impl.h
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d6d080a41a17008fa0720df546673acacbc1d59

commit 0d6d080a41a17008fa0720df546673acacbc1d59
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Jun 14 17:40:58 2018

Migrate heap_profiling service away from Mojo EDK APIs

Switches all heap_profiling code to new public Mojo APIs which
are replacing their EDK equivalents. No functional changes.

This also includes appropriate DEPS and GN deps cleanup.

Bug:  844763 
Change-Id: Ica8969ae83d884e582025ddf92bf1f0104eb910e
Reviewed-on: https://chromium-review.googlesource.com/1100077
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567335}
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/BUILD.gn
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/DEPS
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/connection_manager.cc
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/connection_manager.h
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/public/cpp/BUILD.gn
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/public/cpp/DEPS
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/public/cpp/client.cc
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/public/cpp/controller.cc
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/public/cpp/sender_pipe.h
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/public/cpp/sender_pipe_posix.cc
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/public/cpp/sender_pipe_unittest.cc
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/public/cpp/sender_pipe_win.cc
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/receiver_pipe.cc
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/receiver_pipe.h
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/receiver_pipe_posix.cc
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/receiver_pipe_posix.h
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/receiver_pipe_win.cc
[modify] https://crrev.com/0d6d080a41a17008fa0720df546673acacbc1d59/components/services/heap_profiling/receiver_pipe_win.h
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6b80124edb16289756da9f852422b48206bebd6

commit c6b80124edb16289756da9f852422b48206bebd6
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Jun 14 19:48:32 2018

Migrate cloud print proxy code to public Mojo APIs

Moves cloud print proxy and service process code off of Mojo EDK
APIs and onto new equivalent public Mojo APIs. No functional changes.

Bug:  844763 
Change-Id: I8e0fe9cb0bf9a5daff1b63d7c7256e0929a5f540
Test: Build Chrome-branded official mini_installer on Windows and verify that when installed, the cloud print service can log in and manage cloud printers via the proxy.
Reviewed-on: https://chromium-review.googlesource.com/1100166
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567375}
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/browser/service_process/service_process_control.cc
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/browser/service_process/service_process_control.h
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/common/mac/mock_launchd.cc
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/common/service_process_util.cc
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/common/service_process_util.h
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/common/service_process_util_linux.cc
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/common/service_process_util_mac.mm
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/common/service_process_util_win.cc
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/service/service_process.cc
[modify] https://crrev.com/c6b80124edb16289756da9f852422b48206bebd6/chrome/service/service_process.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a417fdb6da57668806139045095df7afb37ed404

commit a417fdb6da57668806139045095df7afb37ed404
Author: Ken Rockot <rockot@chromium.org>
Date: Tue Jun 19 14:58:36 2018

Mojo: Limit exposure of EDK internals

Removes the last vestiges of non-Mojo targets depending on Mojo
internal types.

Changes the //mojo/edk target to only expose the bare minimum
API needed for embedders to initialize Mojo and IPC.

Deletes some now unused types, PeerConnection and
OutgoingBrokerClientInvitation.

Cleans up a few scattered dependencies.

TBR=dschuff@chromium.org

Bug:  844763 
Change-Id: I7f6ae2987b25fc2089608efea59bee52f15aec4b
Reviewed-on: https://chromium-review.googlesource.com/1102120
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568446}
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/chromeos/DEPS
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/chromeos/components/drivefs/BUILD.gn
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/chromeos/components/drivefs/DEPS
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/chromeos/components/drivefs/fake_drivefs_launcher_client.cc
[delete] https://crrev.com/67f777cbe66765b4f4cdee766f862df7c8cb20fe/chromeos/services/DEPS
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/components/arc/appfuse/arc_appfuse_bridge.cc
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/components/nacl/browser/nacl_broker_host_win.cc
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/ipc/ipc_mojo_perftest.cc
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/BUILD.gn
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/BUILD.gn
[delete] https://crrev.com/67f777cbe66765b4f4cdee766f862df7c8cb20fe/mojo/edk/embedder/BUILD.gn
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/embedder/embedder.cc
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/embedder/embedder.h
[delete] https://crrev.com/67f777cbe66765b4f4cdee766f862df7c8cb20fe/mojo/edk/embedder/outgoing_broker_client_invitation.cc
[delete] https://crrev.com/67f777cbe66765b4f4cdee766f862df7c8cb20fe/mojo/edk/embedder/outgoing_broker_client_invitation.h
[delete] https://crrev.com/67f777cbe66765b4f4cdee766f862df7c8cb20fe/mojo/edk/embedder/peer_connection.cc
[delete] https://crrev.com/67f777cbe66765b4f4cdee766f862df7c8cb20fe/mojo/edk/embedder/peer_connection.h
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/embedder/scoped_ipc_support.h
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/system/BUILD.gn
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/system/core.cc
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/system/core.h
[rename] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/system/embedder_unittest.cc
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/system/message_unittest.cc
[rename] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/system/platform_channel_pair_posix_unittest.cc
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/test/mojo_test_base.cc
[modify] https://crrev.com/a417fdb6da57668806139045095df7afb37ed404/mojo/edk/test/test_utils.h

Comment 15 by roc...@chromium.org, Jun 19 2018

Status: Fixed (was: Assigned)
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea

commit 7a41e6d847a89843a1dc341e55e1ae2cb78f9fea
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Jun 20 07:59:08 2018

Delete some stray dependencies on Mojo EDK

It's no longer used in these places, so wipe out any corresponding
DEPS and gn deps entries.

TBR=sky@chromium.org
TBR=dschuff@chromium.org
TBR=danakj@chromium.org
TBR=xhwang@chromium.org
TBR=nick@chromium.org

Bug:  844763 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ia2237301555ceba399dc63373ab13fab5f0ab02b
Reviewed-on: https://chromium-review.googlesource.com/1107105
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568761}
[delete] https://crrev.com/006d1d74e28a87db8ce60e7151830fc17c121188/chrome/browser/apps/app_shim/DEPS
[delete] https://crrev.com/006d1d74e28a87db8ce60e7151830fc17c121188/chrome/browser/profiling_host/DEPS
[delete] https://crrev.com/006d1d74e28a87db8ce60e7151830fc17c121188/chrome/browser/service_process/DEPS
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/chrome/common/BUILD.gn
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/chrome/common/DEPS
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/components/nacl/broker/DEPS
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/components/nacl/browser/DEPS
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/components/nacl/browser/nacl_broker_host_win.cc
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/components/viz/host/BUILD.gn
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/components/viz/service/BUILD.gn
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/components/viz/service/hit_test/DEPS
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/content/common/BUILD.gn
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/content/common/service_manager/DEPS
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/content/public/common/BUILD.gn
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/device/geolocation/BUILD.gn
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/extensions/renderer/DEPS
[delete] https://crrev.com/006d1d74e28a87db8ce60e7151830fc17c121188/mash/example/window_type_launcher/DEPS
[modify] https://crrev.com/7a41e6d847a89843a1dc341e55e1ae2cb78f9fea/services/ui/common/DEPS
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c05e3de0541182c88b4cdf143157679fbde7036

commit 7c05e3de0541182c88b4cdf143157679fbde7036
Author: Ken Rockot <rockot@chromium.org>
Date: Tue Jun 26 02:54:45 2018

Refresh Mojo documentation

Updates some stale system API references, adds new stuff for invitations
and platform APIs, and deletes a bunch of EDK crap.

Also adds a new convenience API to PlatformChannel and uses it in a few
places, because it makes example code in the documentation less ugly. :)

Bug:  844763 
Change-Id: I91fbff53659dc87fc6fd33a2e5a774c419ba87a7
Reviewed-on: https://chromium-review.googlesource.com/1110954
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570310}
[modify] https://crrev.com/7c05e3de0541182c88b4cdf143157679fbde7036/mojo/README.md
[modify] https://crrev.com/7c05e3de0541182c88b4cdf143157679fbde7036/mojo/edk/embedder/README.md
[modify] https://crrev.com/7c05e3de0541182c88b4cdf143157679fbde7036/mojo/edk/test/multiprocess_test_helper.cc
[modify] https://crrev.com/7c05e3de0541182c88b4cdf143157679fbde7036/mojo/public/c/system/README.md
[add] https://crrev.com/7c05e3de0541182c88b4cdf143157679fbde7036/mojo/public/cpp/platform/README.md
[modify] https://crrev.com/7c05e3de0541182c88b4cdf143157679fbde7036/mojo/public/cpp/platform/platform_channel.cc
[modify] https://crrev.com/7c05e3de0541182c88b4cdf143157679fbde7036/mojo/public/cpp/platform/platform_channel.h
[modify] https://crrev.com/7c05e3de0541182c88b4cdf143157679fbde7036/mojo/public/cpp/system/README.md
[modify] https://crrev.com/7c05e3de0541182c88b4cdf143157679fbde7036/mojo/public/cpp/system/tests/invitation_unittest.cc
[modify] https://crrev.com/7c05e3de0541182c88b4cdf143157679fbde7036/services/service_manager/tests/service_manager/service_manager_unittest.cc
►

Sign in to add a comment