New issue
Advanced search Search tips

Issue 844759 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add RSSI property to ConnectionMetadata

Project Member Reported by khorimoto@chromium.org, May 18 2018

Issue description

Currently, this is always set to kNoRssiAvailable.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79229df14f244c94d1cd74e27aee7103a6f2e16c

commit 79229df14f244c94d1cd74e27aee7103a6f2e16c
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Jun 21 16:38:06 2018

[CrOS MultiDevice] Add RSSI support.

This CL adds a current_rssi field to the mojom::ConnectionMetadata
struct and implements fetching this field throughout all classes
involved with returning the value.

Bug:  844759 , 824568,  752273 
Change-Id: I663326ceb7bb3c5113289f0b29a2ad9c26fcbfa9
Reviewed-on: https://chromium-review.googlesource.com/1106810
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569295}
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/authenticated_channel_impl.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/authenticated_channel_impl.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/authenticated_channel_impl_unittest.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/channel_impl.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/channel_impl.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/fake_channel.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/fake_channel.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/fake_single_client_message_proxy.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/fake_single_client_message_proxy.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/multiplexed_channel_impl.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/multiplexed_channel_impl.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/multiplexed_channel_impl_unittest.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/cpp/client/client_channel.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/cpp/client/client_channel.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/cpp/client/client_channel_impl.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/cpp/client/client_channel_impl.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/cpp/client/client_channel_impl_unittest.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/cpp/client/fake_client_channel.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/cpp/client/fake_client_channel.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/cpp/shared/authenticated_channel.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/cpp/shared/fake_authenticated_channel.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/cpp/shared/fake_authenticated_channel.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/public/mojom/secure_channel.mojom
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/single_client_message_proxy.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/single_client_message_proxy.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/single_client_message_proxy_impl.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/single_client_message_proxy_impl.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/chromeos/services/secure_channel/single_client_message_proxy_impl_unittest.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/connection.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/connection.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/connection_unittest.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/fake_connection.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/fake_connection.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/fake_secure_channel.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/fake_secure_channel.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/secure_channel.cc
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/secure_channel.h
[modify] https://crrev.com/79229df14f244c94d1cd74e27aee7103a6f2e16c/components/cryptauth/secure_channel_unittest.cc

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00f1b3b1985a28a75a4ef198d34a83fbd322a38f

commit 00f1b3b1985a28a75a4ef198d34a83fbd322a38f
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Tue Jun 26 19:21:07 2018

[CrOS Multidevice] Bubble up channel binding data in SecureChannel API.

This information is needed by Smart Lock to send to the host when trying
to sign in.

Bug:  844759 , 824568
Change-Id: Ieb1afce0ebe1dcdcbc014b55fa05871449fe71b9
Reviewed-on: https://chromium-review.googlesource.com/1112873
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570487}
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/chromeos/services/secure_channel/authenticated_channel_impl.cc
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/chromeos/services/secure_channel/authenticated_channel_impl_unittest.cc
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/chromeos/services/secure_channel/multiplexed_channel_impl_unittest.cc
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/chromeos/services/secure_channel/public/cpp/client/client_channel_impl_unittest.cc
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/chromeos/services/secure_channel/public/mojom/secure_channel.mojom
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/chromeos/services/secure_channel/single_client_message_proxy_impl_unittest.cc
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/components/cryptauth/fake_secure_channel.cc
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/components/cryptauth/fake_secure_channel.h
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/components/cryptauth/fake_secure_context.cc
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/components/cryptauth/fake_secure_context.h
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/components/cryptauth/secure_channel.cc
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/components/cryptauth/secure_channel.h
[modify] https://crrev.com/00f1b3b1985a28a75a4ef198d34a83fbd322a38f/components/cryptauth/secure_channel_unittest.cc

Sign in to add a comment