network_icon.cc triggers DCHECK |
||
Issue description
In network_icon.cc we have:
if (network->Matches(NetworkTypePattern::Ethernet())) {
DCHECK_NE(ICON_TYPE_TRAY, icon_type);
https://cs.chromium.org/chromium/src/ash/system/network/network_icon.cc?q=network_icon&sq=package:chromium&g=0&l=442
However we *do* show the Ethernet icon in the system tray if we are connecting to a VPN.
We need to support the icon on the system tray and remove the DCHECK.
,
May 22 2018
I believe so. We should probably make sure it looks correct also :) Currently (with DCHECK disabled), it looks grey. It can be tested by configuring a bogus VPN and connecting to it (you will need to install a certificate to create a valid configuration). I also just noticed that the "connecting" icon for WiFi or Cellular appears grey over dark grey instead of white over grey once connected.
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe1286b42460af10112b9667e33c17f1f92e257f commit fe1286b42460af10112b9667e33c17f1f92e257f Author: Evan Stade <estade@chromium.org> Date: Tue May 22 19:14:50 2018 Chrome OS: Remove DCHECK that asserts ethernet icon is not shown in tray Bug: 844754 Change-Id: If928477917cc9c71c3533793959a143abd34ca7a Reviewed-on: https://chromium-review.googlesource.com/1067759 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#560720} [modify] https://crrev.com/fe1286b42460af10112b9667e33c17f1f92e257f/ash/system/network/network_icon.cc
,
Sep 28
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
,
Nov 8
|
||
►
Sign in to add a comment |
||
Comment 1 by est...@chromium.org
, May 22 2018