New issue
Advanced search Search tips

Issue 844748 link

Starred by 2 users
Status: Duplicate
Merged: issue 640365
Owner:
est...@chromium.org
Closed: Jul 18
Cc:
mustash-bugs@google.com
sky@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640365



Sign in to add a comment

Fix the browser's immersive fullscreen mode in mash

Project Member Reported by afakhry@chromium.org, May 18 2018 
Hovering over the top of the screen doesn't reveal the browser's top view.

I added two new browser tests [1] to make sure caption buttons are able to receive events when the top view is revealed. They currently fail in mash_browser_tests.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1065020

Comment 1 by est...@chromium.org, Jul 18

Owner: est...@chromium.org
Status: Started (was: Untriaged)
This now works (not sure when it was fixed), although pressing restore on the reveal widget doesn't work properly in Mash.

Comment 2 by est...@chromium.org, Jul 18

Cc: sky@chromium.org
How is this bug distinct from  bug 640365  I wonder?

Comment 3 by sky@chromium.org, Jul 18

Mergedinto: 640365
Status: Duplicate (was: Started)
I think you're right, it's a dup.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b78ad2575f1449648fa7f3f64d0657a15bc83fd7

commit b78ad2575f1449648fa7f3f64d0657a15bc83fd7
Author: Evan Stade <estade@chromium.org>
Date: Fri Jul 20 16:38:07 2018

OopAsh: leave fullscreen w/restore button on immersive reveal widget

Observe aura::client::kShowStateKey instead of ash::kWindowStateTypeKey.

Bug:  844748 , 640365 
Change-Id: I06306988084cc7b6cafd0553447b7491301cbab2
Reviewed-on: https://chromium-review.googlesource.com/1141994
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576899}
[modify] https://crrev.com/b78ad2575f1449648fa7f3f64d0657a15bc83fd7/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
►

Sign in to add a comment