New issue
Advanced search Search tips

Issue 844745 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK failure in num_imported_functions() <= index in wasm-code-manager.h

Project Member Reported by ClusterFuzz, May 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5344986275774464

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  num_imported_functions() <= index in wasm-code-manager.h
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=53255:53256

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5344986275774464

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 18 2018

Labels: Test-Predator-Auto-Owner
Owner: clemensh@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/6d87fbc756561cb0920382534fbe3132795fc0f0 ([wasm] Don't store imported WasmCode pointers in code table).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: titzer@chromium.org mstarzinger@chromium.org
Components: -Blink>JavaScript Blink>JavaScript>WebAssembly
Project Member

Comment 3 by sheriffbot@chromium.org, May 19 2018

Labels: Pri-1

Comment 4 by mmoroz@chromium.org, May 21 2018

Labels: M-68 Security_Impact-Head

Comment 5 by mmoroz@chromium.org, May 21 2018

titzer@, clemensh@ seems to be OOO till June, please help to find a new owner, if this needs to be fixed sooner than that.
Project Member

Comment 6 by sheriffbot@chromium.org, May 21 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by titzer@chromium.org, May 22 2018

Labels: -Security_Severity-High -ReleaseBlock-Stable
Owner: titzer@chromium.org
Status: Started (was: Assigned)
Removing Release blocker, since this only occurs with --print-code.

Project Member

Comment 8 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/27ad0c849503f0c98014ac848cf9babe2f4f5511

commit 27ad0c849503f0c98014ac848cf9babe2f4f5511
Author: Ben L. Titzer <titzer@chromium.org>
Date: Tue May 22 13:36:31 2018

[wasm] Do not log imported function code

The wrappers for imports are not accessible through the code() accessor,
so avoid tracing them for now.

BUG= chromium:844745 
R=ahaas@chromium.org

Change-Id: I63fe447091ba3c202e3ffcfddfa645049a0b83cf
Reviewed-on: https://chromium-review.googlesource.com/1068739
Commit-Queue: Ben Titzer <titzer@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53280}
[modify] https://crrev.com/27ad0c849503f0c98014ac848cf9babe2f4f5511/src/wasm/wasm-objects.cc

Comment 9 by titzer@chromium.org, May 22 2018

Status: Fixed (was: Started)
Project Member

Comment 10 by sheriffbot@chromium.org, May 22 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 11 by ClusterFuzz, May 23 2018

ClusterFuzz has detected this issue as fixed in range 53279:53280.

Detailed report: https://clusterfuzz.com/testcase?key=5344986275774464

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  num_imported_functions() <= index in wasm-code-manager.h
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=53255:53256
Fixed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=53279:53280

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5344986275774464

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, May 23 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5344986275774464 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Type-Bug-Security -Restrict-View-SecurityNotify -Security_Impact-Head Type-Bug
Removing security labels based on c#7 (just cleaning up some bugs with missing labels).

Sign in to add a comment