New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844742 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Right click => Search google for this image substitutes bad background color for transparent background images

Project Member Reported by diamondstone@google.com, May 18 2018

Issue description

Chrome Version       : 66.0.3359.181
OS Version: Probably all desktop OSes. Reproduces on OSX and Goobuntu.
URLs (if applicable) : https://www.theknifemedia.com/wp-content/themes/theknife/assets/images/logo.png


What steps will reproduce the problem?
1. Navigate to https://www.theknifemedia.com/
2. Right click on logo image (https://www.theknifemedia.com/wp-content/themes/theknife/assets/images/logo.png) and select "search by image" 

What is the expected result?
Search by image is given the unaltered image.

What happens instead of that?
Search by image is given a mangled image with the background replaced with black, which is useless since the result is an all-black image.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36



 

Comment 1 Deleted

Comment 2 by woxxom@gmail.com, May 18 2018

The Google Image Search server - https://www.google.com/imghp - can handle transparent images uploaded via the page UI, but the built-in search command sends a JPG thumbnail [1] of the image to the server, completely ignoring the transparency of the image thus mangling the result. This has always worked this way since 2013 when the feature was added [2].

Some thoughts:
* There should be no need to re-encode small images such as the reported png because the resultant jpg may easily have a larger file size.
* In case re-encoding is unavoidable and the image has transparency, it would make sense to force a white background color.
* WebP encoder supports lossy mode with transparency would be a better choice - if the encoder is built-in.

  [1]: https://cs.chromium.org/chromium/src/chrome/browser/ui/tab_contents/core_tab_helper.cc?l=119&rcl=55afbe42e3931c4835c53104ea805e41ac8e0f18
  [2]: https://chromiumcodereview.appspot.com/21323003/diff/88001/chrome/browser/renderer_host/chrome_render_view_host_observer.cc#pair-216

Labels: Needs-Triage-M66
Cc: vamshi.kommuri@chromium.org
Components: UI>Browser>Search
Labels: -Pri-3 M-68 Triaged-ET FoundIn-68 Target-68 OS-Mac OS-Windows Pri-2
Status: Untriaged (was: Unconfirmed)
Thanks for filing the issue!

Able to reproduce the issue on reported chrome version 66.0.3359.181 and on the latest canary 68.0.3436.0 using Ubuntu 14.04, Mac 10.13.1 and Windows 10.  As the issue is seen from M60(60.0.3112.0) considering it as Non-Regression and marking it as Untriaged.
Note: Tentatively adding component "UI>Browser>Search", please change if this isn't apt.
woxxom@,

is there a component we can assign this bug to so it won't be lost?  Or at least some explicit CCs?  This doesn't feel like an ordinary UI>Browser>Search bug...

Comment 6 by woxxom@gmail.com, May 22 2018

IDK, I've only checked the source code. Maybe UI>Browser>Contextual>Search in addition to the existing component.
Cc: w...@chromium.org nigeltao@chromium.org injae@chromium.org
Components: UI>Browser>Search>ContextualSearch
CCing some people who touched relevant code recently; maybe they know who owns this / can improve this

Sign in to add a comment