New issue
Advanced search Search tips

Issue 844665 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: inline value previews may disappear when stepping

Project Member Reported by l...@chromium.org, May 18 2018

Issue description

What steps will reproduce the problem?
(1) Pause the DevTools debugger within a function with nearby variables
(2) Step over multiple times within 1sec

What is the expected result?
Inline value previews should not disappear

What happens instead?
With DevTools on DevTools open, inline previews are frequently cleared without any interaction.

See: https://imgur.com/a/rDnzGiv
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc546d851efadcfae2f35c0f8fb4f468d445e7f6

commit dc546d851efadcfae2f35c0f8fb4f468d445e7f6
Author: Erik Luo <luoe@chromium.org>
Date: Mon Jul 09 21:00:19 2018

DevTools: fix clearing of value preview widgets in Sources

Stepping multiple times within 1000ms while paused can result in multiple
setTimeouts scheduled to clear the inline value previews. This may result in
disappearing value previews.

Also, we need to clear stale value widgets after generating new ones, to
ensure that values are shown for the current scope only.

This CL ensures there is only one 'clear' setTimeout at any time, and that
we properly clear old ones before rendering new ones.

Screenshot: https://imgur.com/a/rDnzGiv

Bug:  844665 
Change-Id: I86178a0d825ebae2820170d666b85f3b6d09a745
Reviewed-on: https://chromium-review.googlesource.com/1066708
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573443}
[add] https://crrev.com/dc546d851efadcfae2f35c0f8fb4f468d445e7f6/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-frames-expected.txt
[add] https://crrev.com/dc546d851efadcfae2f35c0f8fb4f468d445e7f6/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-frames.js
[modify] https://crrev.com/dc546d851efadcfae2f35c0f8fb4f468d445e7f6/third_party/blink/renderer/devtools/front_end/sources/DebuggerPlugin.js

Status: Fixed (was: Assigned)

Sign in to add a comment