Sure! Nice to see that chromium has gotten somewhere with their code coverage. We should try that out.

Let us know if you have questions. Please give coverage.py a try locally and once your test target works, submit a cl adding your test suite to test_suite.txt.

I'm playing around with this!

I can see content_browsertests and browsertests etc are already in the list, so that gives good coverage for WebRTC chromium code. What would it take to get this running on standalone WebRTC? Do we need to instantiate a webrtc-coverage.appspot.com and set up a bot or two?

To run locally, I wrote the following script for generating a command line that runs all our default linux targets:

import sys

tests = [
  'rtc_unittests',
  'video_capture_tests',
  'webrtc_nonparallel_tests',
  'video_engine_tests',
  'tools_unittests',
  'test_support_unittests',
  'system_wrappers_unittests',
  'rtc_unittests',
  'rtc_stats_unittests',
  'rtc_pc_unittests',
  'rtc_media_unittests',
  'peerconnection_unittests',
  'ortc_unittests',
  'modules_unittests',
  'modules_tests',
  'low_bandwidth_audio_test',
  'common_video_unittests',
  'common_audio_unittests',
  'audio_decoder_unittests'
]

cmd = ([sys.executable, 'tools/code_coverage/coverage.py'] + tests +
       ['-b out/coverage', '-o out/report'] +
       ['-c \'out/coverage/%s\'' % t for t in tests])
print ' '.join(cmd)

I'll get back tomorrow with the results of the run, but the coverage script appeared to work for rtc_unittests for instance.

Addendum to #4: I had to copy tools/ from chromium since we don't map that into a WebRTC checkout (we can either start doing that or fork the coverage script I guess)

(fixed a typo)

That sounds exciting! Looking forward to having those in the suite.

Re: having a separate WebRTC dashboard, yes, you would need to create a Google Cloud project, set up a bot or few of them, create a GCS bucket, create an App Engine project, customize the dashboard and deploy it. I can't say that it's easy to do as of now, but looks like there is a demand for additional dashboards, so I'll think about how it can be done. Filed issue 845903.

Re #8: SGTM, no rush, we'll look at that in Q3 earliest. I've added it to our plans. I'll try to generate some one-off reports for now, that's still useful info for our devs.

Sounds good to put it formally in Q3 okrs, thanks a lot!

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/317c1b8fcc64bb591e87bf3838c068ef979488c3

commit 317c1b8fcc64bb591e87bf3838c068ef979488c3
Author: Patrik Höglund <phoglund@webrtc.org>
Date: Mon May 28 14:46:29 2018

Add script for generating coverage.py commands.

It's only correct for Linux for now.

Bug: chromium:844647
Change-Id: I8fce28d88a4d060553e30fe0862d34815988ba61
Reviewed-on: https://webrtc-review.googlesource.com/79149
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23418}
[add] https://crrev.com/317c1b8fcc64bb591e87bf3838c068ef979488c3/tools_webrtc/coverage/generate_coverage_command.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/316df9add71ee84385b702f002fef1bda7ceda7b

commit 316df9add71ee84385b702f002fef1bda7ceda7b
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue May 29 13:04:26 2018

Roll src/third_party/webrtc/ b3085b288..2aae2733a (23 commits)

https://webrtc.googlesource.com/src.git/+log/b3085b288b17..2aae2733a70c

$ git log b3085b288..2aae2733a --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:844647,chromium:845158,chromium:794608,chromium:None,chromium:None,chromium:None,chromium:845158


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8a13060bf81727a06eb046ff9c6ef9b18b4a9876
Reviewed-on: https://chromium-review.googlesource.com/1075864
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562399}
[modify] https://crrev.com/316df9add71ee84385b702f002fef1bda7ceda7b/DEPS

FYI, some existing tests relying on WebRTC are failing on the coverage bot, so I guess some of the new ones may also fail ( issue 847106 ). However, that should get fixed after https://webrtc-review.googlesource.com/c/src/+/79187 lands.

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a61fa6ea363ce9eefd1b02aa38ad38ed47b6f52d

commit a61fa6ea363ce9eefd1b02aa38ad38ed47b6f52d
Author: Max Moroz <mmoroz@chromium.org>
Date: Wed May 30 04:28:28 2018

Rely on use_fuzzing_engine && optimize_for_fuzzing to define WEBRTC_UNSAFE_FUZZER_MODE.

Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1074830.

Bug:  chromium:847106 ,  chromium:646404 , chromium:844647
Change-Id: I401d518646e032e24989d343c00c307563e23ddf
Reviewed-on: https://webrtc-review.googlesource.com/79187
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23438}
[modify] https://crrev.com/a61fa6ea363ce9eefd1b02aa38ad38ed47b6f52d/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c256b85606bf30beee3e7a00fac38ed7739d9f11

commit c256b85606bf30beee3e7a00fac38ed7739d9f11
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 30 08:39:19 2018

Roll src/third_party/webrtc 183f4d9..700fc84 (3 commits)

https://webrtc.googlesource.com/src.git/+log/183f4d9..700fc84


git log 183f4d9..700fc84 --date=short --no-merges --format='%ad %ae %s'
2018-05-29 buildbot@webrtc.org Roll chromium_revision 577ba36372..9d94097261 (562638:562745)
2018-05-28 mmoroz@chromium.org Rely on use_fuzzing_engine && optimize_for_fuzzing to define WEBRTC_UNSAFE_FUZZER_MODE.
2018-05-29 buildbot@webrtc.org Roll chromium_revision eb7233cee8..577ba36372 (562409:562638)

Created with:
  gclient setdep -r src/third_party/webrtc@700fc84

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:847106,chromium:646404,chromium:844647,chromium:None

TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8d7165af747083d3b3952b81d86d49ab7c347e6e
Reviewed-on: https://chromium-review.googlesource.com/1078073
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562764}
[modify] https://crrev.com/c256b85606bf30beee3e7a00fac38ed7739d9f11/DEPS

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/ea5b76f7f2e4b499eb2bdd58fcfab53e81bc272a

commit ea5b76f7f2e4b499eb2bdd58fcfab53e81bc272a
Author: Artem Titarenko <artit@webrtc.org>
Date: Tue Sep 11 15:06:50 2018

Excluded tests and test utils from code coverage by generate_coverage_command.py

Bug: chromium:844647
Change-Id: I3b99cfcbeae99794f9600f232b560c47efeebc57
Reviewed-on: https://webrtc-review.googlesource.com/99682
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24692}
[modify] https://crrev.com/ea5b76f7f2e4b499eb2bdd58fcfab53e81bc272a/tools_webrtc/coverage/generate_coverage_command.py

Can anyone please add the tests mentioned in c#4 to https://cs.chromium.org/chromium/src/tools/code_coverage/test_suite.txt ?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd99b7d4a8c6321fa370190a6e1d0e8e23b16f81

commit bd99b7d4a8c6321fa370190a6e1d0e8e23b16f81
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Sep 12 00:37:47 2018

Roll src/third_party/webrtc 375d35e01b11..bfd412ef716c (9 commits)

https://webrtc.googlesource.com/src.git/+log/375d35e01b11..bfd412ef716c


git log 375d35e01b11..bfd412ef716c --date=short --no-merges --format='%ad %ae %s'
2018-09-11 benwright@webrtc.org Adds integration of the FrameEncryptor/FrameDecryptor into the MediaChannel.
2018-09-11 buildbot@webrtc.org Roll chromium_revision de6484608c..8952ae0039 (589477:590303)
2018-09-11 artit@webrtc.org Excluded tests and test utils from code coverage by generate_coverage_command.py
2018-09-11 nisse@webrtc.org Use SdpVideoFormat in VideoReceiveStream::Decoder
2018-09-11 danilchap@webrtc.org Allow nullptr retransmition rate limiter
2018-09-11 kthelgason@webrtc.org Remove unused file.
2018-09-11 kthelgason@webrtc.org Remove RTCUIApplicationStatusObserver.
2018-09-11 perkj@webrtc.org Reland "Decrease complexity of RtpPacketHistory::GetBestFittingPacket.""
2018-09-11 ssilkin@webrtc.org Fix target frame rate of spatial layer.


Created with:
  gclient setdep -r src/third_party/webrtc@bfd412ef716c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:844647,chromium:None,chromium:None,chromium:882358
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2319c5745080bd3de25d4aabd7e9bc5f0f9cf214
Reviewed-on: https://chromium-review.googlesource.com/1220237
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590554}
[modify] https://crrev.com/bd99b7d4a8c6321fa370190a6e1d0e8e23b16f81/DEPS

Friendly ping re c#18 just in case it got hidden by the bugdroid comments:

> Can anyone please add the tests mentioned in c#4 to https://cs.chromium.org/chromium/src/tools/code_coverage/test_suite.txt ?

Sorry for the late response.
Sure, I will do it.
Just one question: one of our tests ("modules_unittests") require xvfb. How can we run it in your suite?

Good question! We run all of the tests using xvfb :)

Thank you, artit@!

mmoroz@, I have discussed addition of webrtc tests (i.e. build targets) to chromium build with phoglund@ and we agreed that this would require a lot more of building in chromium repo and would bring additional brittleness to its build configuration.

Anyway these projects are separate now and it is better to set up our own coverage dashboard like you've written in c#8. Probably we will do it in Q4.

I thought that those test targets (e.g. from c#4) are buildable in Chromium checkout. Was I mistaken?

No, they are not buildable any more, they were excluded to speed-up building of chromium. Including them in regular builds again will noticeably increase build time, and building it occasionally (only for getting code coverage) will be not enough to spot problems quickly.

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/207cfdfbd8896e093f7088123eb729df174614d3

commit 207cfdfbd8896e093f7088123eb729df174614d3
Author: Artem Titarenko <artit@webrtc.org>
Date: Thu Sep 20 07:27:55 2018

Added support of getting coverage on mac

Bug: chromium:844647
Change-Id: Ia358d3a1dfc9a53149d68f811652f38245a0b408
Reviewed-on: https://webrtc-review.googlesource.com/101041
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24779}
[modify] https://crrev.com/207cfdfbd8896e093f7088123eb729df174614d3/sdk/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/355216f49193e50ee4817a659a1a343932368896

commit 355216f49193e50ee4817a659a1a343932368896
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Sep 20 12:21:46 2018

Roll src/third_party/webrtc ee002e61857b..207cfdfbd889 (1 commits)

https://webrtc.googlesource.com/src.git/+log/ee002e61857b..207cfdfbd889


git log ee002e61857b..207cfdfbd889 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 artit@webrtc.org Added support of getting coverage on mac


Created with:
  gclient setdep -r src/third_party/webrtc@207cfdfbd889

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:844647
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I392429d4014348877087de19a4812632cbad9f38
Reviewed-on: https://chromium-review.googlesource.com/1235837
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592769}
[modify] https://crrev.com/355216f49193e50ee4817a659a1a343932368896/DEPS

re c#25:

> No, they are not buildable any more, they were excluded to speed-up building of chromium. Including them in regular builds again will noticeably increase build time, and building it occasionally (only for getting code coverage) will be not enough to spot problems quickly.


Excluding from a regular build makes sense, but I don't get your point regarding "building it occasionally ... will be not enough to spot problems quickly.". We aren't trying to catch any problems / regressions from individual CLs (at least with the current state of things), but rather have a high level overview of which parts of the codebase miss test coverage or seem to be a dead code. For that purpose, our current capacity (a several reports per day published on https://chromium-coverage.appspot.com/) helps quite well. I can share a bunch of examples of developers either improving the tests or removing unused code which they identified using the coverage dashboard.

I think that "problems" here means actual build problems, not coverage problems. Only some parts of WebRTC are supported for being built with Chromium, and others are not even part of "all". So if we find some special way to build those targets only for the purposes of coverage, it is possible that they will just be broken because they are not otherwise continuously built with Chromium.

Yes, I mean that we will not be able to quickly spot the moment that chromium coverage stops building because of any build error. It would be harder for us to maintain this "build-ability" for all major webrtc build targets inside chromium.

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/ee414728e9ca2eed87bc479016c5e66f7e5a6ced

commit ee414728e9ca2eed87bc479016c5e66f7e5a6ced
Author: Artem Titarenko <artit@webrtc.org>
Date: Mon Sep 24 08:59:41 2018

Revert "Added support of getting coverage on mac"

This reverts commit 207cfdfbd8896e093f7088123eb729df174614d3.

Reason for revert: Triaging  bug chromium:888061 

Original change's description:
> Added support of getting coverage on mac
> 
> Bug: chromium:844647
> Change-Id: Ia358d3a1dfc9a53149d68f811652f38245a0b408
> Reviewed-on: https://webrtc-review.googlesource.com/101041
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Artem Titarenko <artit@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24779}

TBR=phoglund@webrtc.org,artit@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:844647
Change-Id: Icd4708d57ac3d0c8d13127c8bc263069d6d2b44c
Reviewed-on: https://webrtc-review.googlesource.com/101540
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24788}
[modify] https://crrev.com/ee414728e9ca2eed87bc479016c5e66f7e5a6ced/sdk/BUILD.gn

oprypin@ and artit@, thanks for clarifying!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76346c9b0afb2febbf2bf3c8d2785ce342e8ad0e

commit 76346c9b0afb2febbf2bf3c8d2785ce342e8ad0e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Sep 24 23:40:00 2018

Roll src/third_party/webrtc 645512ba5966..a36631cdb571 (26 commits)

https://webrtc.googlesource.com/src.git/+log/645512ba5966..a36631cdb571


git log 645512ba5966..a36631cdb571 --date=short --no-merges --format='%ad %ae %s'
2018-09-24 danilchap@webrtc.org Expect late delayed task is deleted.
2018-09-24 buildbot@webrtc.org Roll chromium_revision c92470b71e..695c43e432 (593506:593611)
2018-09-24 niklas.enbom@webrtc.org Revert "Bug in histogram metric reporting."
2018-09-24 srte@webrtc.org Don't reset initial constraints in congestion controller.
2018-09-24 orphis@webrtc.org Add dummy implementation for SetCodecPReferences.
2018-09-24 terelius@webrtc.org Add helper class to process RtcEventLog events in order.
2018-09-24 yvesg@webrtc.org ResultsContainer: Initialize fields.
2018-09-24 yvesg@webrtc.org Auto roller: [unittest cleanup] Proper patching mechanism.
2018-09-24 kwiberg@webrtc.org TestStereo: Don't rely on the ACM to create encoders
2018-09-24 gustaf@webrtc.org AEC3: Delay estimator adapts even when estimated echo saturates
2018-09-24 kron@webrtc.org Refactor to remove direct memory dependency on kMaxId
2018-09-24 aleloi@webrtc.org Bug in histogram metric reporting.
2018-09-24 buildbot@webrtc.org Roll chromium_revision a7544fa319..c92470b71e (592771:593506)
2018-09-24 sprang@webrtc.org Revert "Reland "Enable simulcast screenshare by default""
2018-09-24 phensman@webrtc.org Include stringutils to allow build on chromium
2018-09-24 devicentepena@webrtc.org AEC3: Bounding the nearend spectrum used as input for the suppressor gain computation
2018-09-24 artit@webrtc.org Disabled TestPacketBuffer.SeqNumWrapOneFrame test due to clang update
2018-09-24 nisse@webrtc.org Delete unused Url class.
2018-09-24 nisse@webrtc.org Delete unused HttpData methods.
2018-09-24 kwiberg@webrtc.org AudioCodingModuleTest.TestStereo: Delete write-only variables
2018-09-24 mflodman@webrtc.org Don't throttle key-frame requests per layer.
2018-09-24 jonasolsson@webrtc.org Make fewer copies when using StringBuilder.
2018-09-24 asapersson@webrtc.org Android: Add maxFramerate to RtpParameters.
2018-09-24 artit@webrtc.org Revert "Added support of getting coverage on mac"
2018-09-24 phensman@webrtc.org Add WriteVideoToFile to video_file_reader.
2018-09-24 henrika@webrtc.org Ensures that ADM unittest uses default audio devices for all platforms.


Created with:
  gclient setdep -r src/third_party/webrtc@a36631cdb571

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:755660,chromium:855108,chromium:None,chromium:690537,chromium:887464,chromium:844647
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I906ee8f2b3f7798a61aef95bce71fbcbe0d81221
Reviewed-on: https://chromium-review.googlesource.com/1241517
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593747}
[modify] https://crrev.com/76346c9b0afb2febbf2bf3c8d2785ce342e8ad0e/DEPS

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/17ad64e41f43e2ee5722d74acb35e92a0832b60d

commit 17ad64e41f43e2ee5722d74acb35e92a0832b60d
Author: Artem Titarenko <artit@webrtc.org>
Date: Tue Sep 25 08:31:30 2018

Reland "Added support of getting coverage on mac"

This is a reland of 207cfdfbd8896e093f7088123eb729df174614d3
This was not a cause of  bug chromium:888061 

Original change's description:
> Added support of getting coverage on mac
>
> Bug: chromium:844647
> Change-Id: Ia358d3a1dfc9a53149d68f811652f38245a0b408
> Reviewed-on: https://webrtc-review.googlesource.com/101041
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Artem Titarenko <artit@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24779}

Bug: chromium:844647
Change-Id: I14ecd48f2c6e5cf4978110b6aefae02222d3ff1e
Reviewed-on: https://webrtc-review.googlesource.com/101780
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24817}
[modify] https://crrev.com/17ad64e41f43e2ee5722d74acb35e92a0832b60d/sdk/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ecd5b10d9d60a0627666c34e36649017a7424bc

commit 1ecd5b10d9d60a0627666c34e36649017a7424bc
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Sep 25 13:23:47 2018

Roll src/third_party/webrtc a36631cdb571..bacfd87b3be2 (9 commits)

https://webrtc.googlesource.com/src.git/+log/a36631cdb571..bacfd87b3be2


git log a36631cdb571..bacfd87b3be2 --date=short --no-merges --format='%ad %ae %s'
2018-09-25 oprypin@webrtc.org Revert "Use new internal trybot in commit queue"
2018-09-25 oprypin@webrtc.org Use new internal trybot in commit queue
2018-09-25 titovartem@webrtc.org Cleanup: remove deprecated class shortcuts.
2018-09-25 artit@webrtc.org Reland "Added support of getting coverage on mac"
2018-09-25 kwiberg@webrtc.org Remove the delay_test binary
2018-09-25 buildbot@webrtc.org Roll chromium_revision 271a2fecb1..06f028f7d6 (593721:593823)
2018-09-24 kron@webrtc.org Potential bug in RTP packet.
2018-09-24 kron@webrtc.org Add sanity checks to UpdateDelayStatistics and patch unit tests.
2018-09-24 buildbot@webrtc.org Roll chromium_revision 695c43e432..271a2fecb1 (593611:593721)


Created with:
  gclient setdep -r src/third_party/webrtc@bacfd87b3be2

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:844647,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic7f737b58471ec92f69057476be226d8560490c5
Reviewed-on: https://chromium-review.googlesource.com/1242327
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593912}
[modify] https://crrev.com/1ecd5b10d9d60a0627666c34e36649017a7424bc/DEPS

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/84d282711b94dab342c71665581bba2f544c2ec6

commit 84d282711b94dab342c71665581bba2f544c2ec6
Author: Artem Titarenko <artit@webrtc.org>
Date: Tue Oct 16 10:26:11 2018

Add generate_ios_coverage_command.py script

This script simplifies getting iOS code coverage for real devices
and simulators. Although getting coverage for real devices is not
fully automated.

Bug: chromium:844647
Change-Id: Ib58173a9a6f61408ac1f8c7eaea712517b78e0ea
Reviewed-on: https://webrtc-review.googlesource.com/c/105663
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25202}
[add] https://crrev.com/84d282711b94dab342c71665581bba2f544c2ec6/tools_webrtc/coverage/generate_ios_coverage_command.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f41a24342cf15e0139141d33c61346bea80d1c5d

commit f41a24342cf15e0139141d33c61346bea80d1c5d
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 16 21:57:53 2018

Roll src/third_party/webrtc 1927dfafabc0..9b1d67982f26 (23 commits)

https://webrtc.googlesource.com/src.git/+log/1927dfafabc0..9b1d67982f26


git log 1927dfafabc0..9b1d67982f26 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 mbonadei@webrtc.org Remove 'iOS32 Sim Debug (iOS 9.0)' from client.webrtc.
2018-10-16 niklas.enbom@webrtc.org Revert "Remove the HighPassFilter interface"
2018-10-16 peah@webrtc.org Avoids creating empty call_order file when no call order data is written
2018-10-16 danilchap@webrtc.org Calculate max payload size for an rtp packet to fit full video frame
2018-10-16 srte@webrtc.org Don't send max allocation probe unless allocation changed.
2018-10-16 terelius@webrtc.org Update proto for new event log format.
2018-10-16 nisse@webrtc.org Delete wrappers for snprintf and vsnprintf
2018-10-16 magjed@webrtc.org Use color aligning in video quality analysis tool
2018-10-16 peah@webrtc.org AEC3: Changes to initial behavior and handling of saturated echo
2018-10-16 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 3).
2018-10-16 srte@webrtc.org Using more specific dependencies in rtc_base.
2018-10-16 danilchap@webrtc.org Always verify packet wasn't resend recently before resending it.
2018-10-16 brandtr@webrtc.org Remove |hw_encoder| and |hw_decoder| from VideoCodecTestFixture::Config.
2018-10-16 nisse@webrtc.org Delete unused code in rtc_base/stringutils.*
2018-10-16 artit@webrtc.org Add generate_ios_coverage_command.py script
2018-10-16 srte@webrtc.org Removing unnecessary dependencies on socket.h.
2018-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0cecb6ce10..f8cad916e6 (599821:599923)
2018-10-16 saza@webrtc.org Remove AECM comfort noise setting from API
2018-10-16 saza@webrtc.org Remove the HighPassFilter interface
2018-10-16 peterhanspers@webrtc.org Adding support for logging severity LS_NONE.
2018-10-16 nisse@webrtc.org Implement test class LoopbackMediaTransport
2018-10-16 asapersson@webrtc.org Add test that verifies that VideoEncoderConfig max_framerate is reported to source.
2018-10-16 srte@webrtc.org Removes Clock instance from RoundRobinPacketQueue.


Created with:
  gclient setdep -r src/third_party/webrtc@9b1d67982f26

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:894434, chromium:895435 , chromium:895431 ,chromium:None,chromium:844647,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic49f27d148d1b629d7599b62fd91ba2a28e30935
Reviewed-on: https://chromium-review.googlesource.com/c/1284010
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600142}
[modify] https://crrev.com/f41a24342cf15e0139141d33c61346bea80d1c5d/DEPS

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/34fc346a0c77e21bffb6a6631e265a707e6e4ae2

commit 34fc346a0c77e21bffb6a6631e265a707e6e4ae2
Author: Artem Titarenko <artit@webrtc.org>
Date: Tue Nov 06 15:18:51 2018

Add support for computing iOS code coverage

Also disable failing PosixSignalDeliveryTest* tests for iOS

Bug: chromium:844647
Change-Id: I64bb233bef2f06f6778f2d475b6d3ad685fb9143
Reviewed-on: https://webrtc-review.googlesource.com/c/105641
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25524}
[modify] https://crrev.com/34fc346a0c77e21bffb6a6631e265a707e6e4ae2/examples/BUILD.gn
[copy] https://crrev.com/34fc346a0c77e21bffb6a6631e265a707e6e4ae2/examples/objc/AppRTCMobile/tests/main.mm
[modify] https://crrev.com/34fc346a0c77e21bffb6a6631e265a707e6e4ae2/rtc_base/physicalsocketserver_unittest.cc
[modify] https://crrev.com/34fc346a0c77e21bffb6a6631e265a707e6e4ae2/sdk/BUILD.gn
[rename] https://crrev.com/34fc346a0c77e21bffb6a6631e265a707e6e4ae2/sdk/objc/unittests/main.mm
[modify] https://crrev.com/34fc346a0c77e21bffb6a6631e265a707e6e4ae2/test/BUILD.gn
[add] https://crrev.com/34fc346a0c77e21bffb6a6631e265a707e6e4ae2/test/ios/coverage_util_ios.h
[add] https://crrev.com/34fc346a0c77e21bffb6a6631e265a707e6e4ae2/test/ios/coverage_util_ios.mm
[modify] https://crrev.com/34fc346a0c77e21bffb6a6631e265a707e6e4ae2/test/ios/test_support.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6da50dd260c13e130e8afdcaf2ba7caa4c7a5a5

commit c6da50dd260c13e130e8afdcaf2ba7caa4c7a5a5
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Nov 06 20:19:07 2018

Roll src/third_party/webrtc 277b6ea8508e..34fc346a0c77 (1 commits)

https://webrtc.googlesource.com/src.git/+log/277b6ea8508e..34fc346a0c77


git log 277b6ea8508e..34fc346a0c77 --date=short --no-merges --format='%ad %ae %s'
2018-11-06 artit@webrtc.org Add support for computing iOS code coverage


Created with:
  gclient setdep -r src/third_party/webrtc@34fc346a0c77

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:844647
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I398b9a5ae3193c1b8e2ef91eba91e9eb0dd8acf1
Reviewed-on: https://chromium-review.googlesource.com/c/1320409
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605801}
[modify] https://crrev.com/c6da50dd260c13e130e8afdcaf2ba7caa4c7a5a5/DEPS