New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 844620 link

Starred by 2 users
Status: Fixed
Owner:
e...@chromium.org
Closed: May 2018
Cc:
█ egdaniel@chromium.org
npm@chromium.org
e...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.5% regression in thread_times.key_silk_cases at 558783:558872

Project Member Reported by npm@chromium.org, May 18 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 18 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=844620

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b19cfb685961c7a06fe105efab6895f39858a6227d9113575def95c346396cb1


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 20 2018

Cc: e...@chromium.org egdaniel@chromium.org
Owner: egdaniel@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/16e71d8c240000

[LayoutNG] Fix border/background painting for multi-line by eae@chromium.org
https://chromium.googlesource.com/chromium/src/+/71426b9aa50bd9faebb73540dcbcf55d315620e4

Fix up DCHECKS for ids returned from GetGLTextureIDFromSkImage in viz gl_renderer. by egdaniel@chromium.org
https://chromium.googlesource.com/chromium/src/+/82036716dcb9a75c34df572e535cad675bb09853

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by egdaniel@chromium.org, May 21 2018

Owner: e...@chromium.org
Passing to eae. Looking at the pinpoint graph in #3, it looks like that is the change which caused the big jump. Also my change shouldn't have functionality change, it just fixed a DCHECK assert

Comment 5 by e...@chromium.org, May 25 2018

Status: Fixed (was: Assigned)
It was indeed and the change has since been reverted.
►

Sign in to add a comment