New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844612 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

14%-18% regression in blink_perf.dom at 558246:558543

Project Member Reported by npm@chromium.org, May 18 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 18 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=844612

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e7751abd8a4ff95a2f82331d23da4bcc66235d08d9e19506b62b7d2afeea8b61


Bot(s) for this bug's original alert(s):

android-one
chromium-rel-mac11-air
chromium-rel-mac11-pro
linux-perf
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 20 2018

Cc: farahcharab@google.com erikc...@chromium.org alancutter@chromium.org hirosh...@chromium.org chrishtr@chromium.org futhark@chromium.org kpaulhamus@chromium.org pbos@chromium.org tsepez@chromium.org smcgruer@chromium.org penghuang@chromium.org
Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 11 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14a8db8c240000

Add features for SkiaRenderer and SkiaDDL by penghuang@chromium.org
https://chromium.googlesource.com/chromium/src/+/da645cda5ad43bc5568737459876536c14235fde

Tracing: Add capability to trace the priority of the tasks executed. by farahcharab@google.com
https://chromium.googlesource.com/chromium/src/+/6c7d9b546a3b722f062eae0643cf84049e8b6045

Add PageActionIconContainer interface by alancutter@chromium.org
https://chromium.googlesource.com/chromium/src/+/2cce5382f0df68d9f8c19a3660a920917643e458

CalculateAnimationUpdate - track previous/current css-animation-playstate by smcgruer@chromium.org
https://chromium.googlesource.com/chromium/src/+/2fb2fc1f681816489bb92cb94a128b3bf2f4f0bb

Use scoped FPDF types in pdfium_engine.h by tsepez@chromium.org
https://chromium.googlesource.com/chromium/src/+/b3a42ee2c7960c335ebfdecc0c006124b23730b5

[Squad] Immutable style for LayoutMenuList inner_block. by futhark@chromium.org
https://chromium.googlesource.com/chromium/src/+/16a2164f7370d08a07206bcb2001668e56269af5

Implement the caBLE registration and authentication extensions. by kpaulhamus@chromium.org
https://chromium.googlesource.com/chromium/src/+/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a

[IOv2] Add a feature for turning on IntersectionObserverGeometryMapper. by chrishtr@chromium.org
https://chromium.googlesource.com/chromium/src/+/b21e6f6ae3433d0a328c7ae27c4b62672a78de8c

Add a Touchable Material Refresh mode by pbos@chromium.org
https://chromium.googlesource.com/chromium/src/+/756745ddcb1990a9dba4ad95ed5906fbd27a95f9

Make WebLocalFrame::ExecuteScriptInIsolatedWorld() single-script-only by hiroshige@chromium.org
https://chromium.googlesource.com/chromium/src/+/e1352e6aff1cd10be78e0f85d54fb46f2d799936

Delay sending TabDetachedAt and TabClosingAt observer notifications. by erikchen@chromium.org
https://chromium.googlesource.com/chromium/src/+/f64c33d60de88b6b0d1a3d65860a710ab37dafac

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -futhark@chromium.org
Owner: futhark@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/439e345b11104f36f63a906d141c7c7844103a50

commit 439e345b11104f36f63a906d141c7c7844103a50
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue May 22 11:24:25 2018

[Squad] Fix LayoutMenuList performance regression.

We only need to update the style of LayoutMenuList from option style
when we actually have an option_style_. If we deselect an option, we
would still not modify the ComputedStyle to remove any direction or
unicode-bidi from the previously selected option in AdjustInnerStyle.

Bug:  844612 ,  844604 
Change-Id: Ie8180b5e68d913afeb97b3a07bdba3cf310ea5d2
Reviewed-on: https://chromium-review.googlesource.com/1068867
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560534}
[modify] https://crrev.com/439e345b11104f36f63a906d141c7c7844103a50/third_party/blink/renderer/core/layout/layout_menu_list.cc

Status: Fixed (was: Started)

Sign in to add a comment