New issue
Advanced search Search tips

Issue 844609 link

Starred by 2 users
Status: Fixed
Owner:
ftirelo@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"Manage addresses..." shown at the dropdown footer even when there is no address field

Project Member Reported by ftirelo@chromium.org, May 18 2018 
Chrome Version: M68
OS: desktop

In the new dropdow, we show a "Manage addresses..." option in the footer for personal information fields, even if when there is no address in the form (for example, a signup form when the user only enters the name and the email).

We should show "Manage..." instead in those cases.
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2b2903ccf1714c0bc855635fae12fe6ea537dda

commit c2b2903ccf1714c0bc855635fae12fe6ea537dda
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Tue May 22 15:31:59 2018

[af] Only offer to manage addresses on address-related contexts

This makes "manage" string in the dropdown footer depend on the
form context for name/email/phone number.

The following rules are to be applied:
1. If field corresponds to a credit card, show
  "Manage payment methods...";
2. If field corresponds to name/email/phone:
   a. Show "Manage addresses..." if there is at least one address
      field in the form;
   b. Show "Manage..." otherwise;
3. Show "Manage addresses..." if the current field corresponds to
   an address.

Screenshots: https://drive.google.com/open?id=1AYRPnldIbIuxXNDMGIa2dMrvU5_MLOI9

Bug:  844609 
Change-Id: I1dd416f5d3f24e7bf1d6f33f8b0520ce6b67827e
Reviewed-on: https://chromium-review.googlesource.com/1064545
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560603}
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/chrome/browser/ui/autofill/autofill_popup_controller_impl_mac.mm
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/autofill/core/browser/autofill_external_delegate.h
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/autofill/core/browser/autofill_popup_delegate.h
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/autofill/core/browser/autofill_test_utils.h
[add] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/autofill/core/browser/popup_types.h
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/c2b2903ccf1714c0bc855635fae12fe6ea537dda/components/password_manager/core/browser/password_autofill_manager.h

Comment 2 by ftirelo@chromium.org, May 22 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment