New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844592 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CrOS fuzzing: make base/test/fuzzed_data_provider.h available in libchrome

Project Member Reported by jorgelo@chromium.org, May 18 2018

Issue description

FuzzedDataProvider is pretty useful to write more elaborate fuzzers that need to do more than just pass a chunk of bytes to a parsing function. Let's add it to libchrome (I don't think it's there yet).

+Luis to see who's maintaining libchrome nowadays.
 
Cc: hidehiko@chromium.org ejcaruso@chromium.org
+more co-maintainers.

hidehiko@ is going to try to uprev libchrome to last week's build Real Soon Now.
Status: Available (was: Unconfirmed)
But even if we were not uprev'ing, we would still need to modify the ebuild or something to install the new headers, right?
There's also the plan of switching to gn, which might do it automagically for us (not sure).
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libchrome/+/913f89fda814b25f6ae0be970e455042b0d34d05

commit 913f89fda814b25f6ae0be970e455042b0d34d05
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Thu May 24 15:44:44 2018

libchrome: Add FuzzedDataProvider.

Chrome OS is ramping up the use of fuzzing for increased stability and
security. We published a fuzzing guide at
https://chromium.googlesource.com/chromiumos/docs/+/master/fuzzing.md
and now it's time to start writing fuzzers.

FuzzedDataProvider simplifies writing fuzzers that test more than just
functions that take a |char*|. It makes it a lot easier to test APIs by
allowing the fuzzer to use the data provided by the fuzzing scaffolding
to make higher level decisions.

Add FuzzedDataProvider to libchrome to allow Chrome OS fuzzers to use
it.

Revision in chromium/src of added files:
cd328f417239bb2743040789247be04f78f31ae1, r433652
Mon May 21

BUG= chromium:844592 
TEST=Compiles, fuzzer can use FuzzedDataProvider.

Change-Id: Icf7add7508d17e36c66c204dd72066c4f211ca85
Reviewed-on: https://chromium-review.googlesource.com/1069002
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/913f89fda814b25f6ae0be970e455042b0d34d05/SConstruct
[add] https://crrev.com/913f89fda814b25f6ae0be970e455042b0d34d05/base/test/fuzzed_data_provider.cc
[add] https://crrev.com/913f89fda814b25f6ae0be970e455042b0d34d05/base/test/fuzzed_data_provider.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b5c54f68e0d1eead4ed89751377c193d5775e17d

commit b5c54f68e0d1eead4ed89751377c193d5775e17d
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Thu May 24 22:44:31 2018

libchrome: Add FuzzedDataProvider.

Chrome OS is ramping up the use of fuzzing for increased stability and
security. We published a fuzzing guide at
https://chromium.googlesource.com/chromiumos/docs/+/master/fuzzing.md
and now it's time to start writing fuzzers.

FuzzedDataProvider simplifies writing fuzzers that test more than just
functions that take a |char*|. It makes it a lot easier to test APIs by
allowing the fuzzer to use the data provided by the fuzzing scaffolding
to make higher level decisions.

Add FuzzedDataProvider to libchrome to allow Chrome OS fuzzers to use
it.

This is a cherry-pick of CL:1069002

BUG= chromium:844592 
TEST=Compiles, fuzzer can use FuzzedDataProvider.

Change-Id: Ib7686122ee42add55691bf69574a2cbf4a5812f0
Reviewed-on: https://chromium-review.googlesource.com/1070435
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[add] https://crrev.com/b5c54f68e0d1eead4ed89751377c193d5775e17d/chromeos-base/libchrome/files/libchrome-395517-Add-FuzzedDataProvider.patch
[modify] https://crrev.com/b5c54f68e0d1eead4ed89751377c193d5775e17d/chromeos-base/libchrome/libchrome-395517.ebuild
[rename] https://crrev.com/b5c54f68e0d1eead4ed89751377c193d5775e17d/chromeos-base/libchrome/libchrome-395517-r31.ebuild

Owner: jorgelo@chromium.org
Status: Started (was: Available)
Status: Fixed (was: Started)

Sign in to add a comment