gl_tests and gl_unittests don't run on linux_chromium_rel_ng |
||
Issue descriptionhttps://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/95491 gl_unittests has just a single failure: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8946335391278577056%2F%2B%2Fsteps%2Fgl_unittests__with_patch_%2F0%2Flogs%2FGLContextGLXTest.DoNotDestroyOnFailedMakeCurrent%2F0 [ RUN ] GLContextGLXTest.DoNotDestroyOnFailedMakeCurrent ../../ui/gl/gl_context_glx_unittest.cc:29: Failure Value of: xdisplay Actual: false Expected: true Stack trace: #0 0x00000047e25c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x00000047dc39 testing::internal::AssertHelper::operator=() #2 0x0000003792d3 gl::GLContextGLXTest_DoNotDestroyOnFailedMakeCurrent_Test::TestBody() [ FAILED ] GLContextGLXTest.DoNotDestroyOnFailedMakeCurrent (0 ms) Maybe that particular test should be in gl_tests instead? gl_tests has many failures like that. It probably needs to run on real hardware, like done in bug 830659 for the memory bots. Since linux_chromium_rel_ng is on the default cq, maybe we don't have resources for that though? Disabling these two test suites on the main waterfall for now.
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a commit 589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a Author: Nico Weber <thakis@chromium.org> Date: Sat May 19 02:58:46 2018 Reduce number of different test suite configurations. - Remove all the "non_clang" and "_fyi" configs -- the clang waterfall and the FYI waterfall should default to running the same tests as the real waterfalls unless explicitly opted out. Deviations here were very likely not intentional. - This requires running chrome_cleaner_unittests on the regular win bots, which seems like a good change anyhow. - Just include angle_unittests in chromium_gtests instead of spuriously adding it here and there (but on all platforms). We've had issues with this test unintentionally running on too few bots. - Rename aura_gtests to non_android_and_mac_gtests - Include gl_tests in the normal chromium_linux_gtests and chromium_android_gtests suites instead of having separate _and_gl configs - Add gcm_unit_tests to chromium_gtests since it effectively ran everywhere already, this allows deleting non_android_and_cast_chromium_gtests. Use similar tactics to remove non_android_and_cast_and_chromeos_chromium_gtests. - Address most "TODO: merge back to X" TODOs The main effect is that this adds many tests to the chromium.clang waterfall, making it more consistent with the main waterfall. It also adds a couple of binaries to other waterfalls. Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 ,831999, 844582 TBR=disabled test owners Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I67c3980009fc07897f1f6bab424ef6c5f11d4830 Reviewed-on: https://chromium-review.googlesource.com/1061795 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560147} [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/media/cast/receiver/audio_decoder_unittest.cc [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.android.fyi.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.android.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.clang.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.gpu.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.linux.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.mac.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.memory.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/chromium.win.json [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/test_suites.pyl [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/third_party/libjingle_xmpp/README.chromium [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/third_party/libjingle_xmpp/task_runner/task_unittest.cc [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/tools/battor_agent/battor_connection_impl_unittest.cc [modify] https://crrev.com/589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a/ui/compositor/layer_unittest.cc
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3b15b26491f649cffaccae05a4370f8367ddbcf commit e3b15b26491f649cffaccae05a4370f8367ddbcf Author: Pavel Feldman <pfeldman@chromium.org> Date: Sat May 19 20:57:11 2018 Revert "Reduce number of different test suite configurations." This reverts commit 589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a. Reason for revert: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/11941 Original change's description: > Reduce number of different test suite configurations. > > - Remove all the "non_clang" and "_fyi" configs -- the clang > waterfall and the FYI waterfall should default to running the > same tests as the real waterfalls unless explicitly opted out. > Deviations here were very likely not intentional. > - This requires running chrome_cleaner_unittests on the regular > win bots, which seems like a good change anyhow. > - Just include angle_unittests in chromium_gtests instead of > spuriously adding it here and there (but on all platforms). > We've had issues with this test unintentionally running on too > few bots. > - Rename aura_gtests to non_android_and_mac_gtests > - Include gl_tests in the normal chromium_linux_gtests and > chromium_android_gtests suites instead of having separate > _and_gl configs > - Add gcm_unit_tests to chromium_gtests since it effectively > ran everywhere already, this allows deleting > non_android_and_cast_chromium_gtests. Use similar tactics to > remove non_android_and_cast_and_chromeos_chromium_gtests. > - Address most "TODO: merge back to X" TODOs > > The main effect is that this adds many tests to the chromium.clang > waterfall, making it more consistent with the main waterfall. > It also adds a couple of binaries to other waterfalls. > > Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 ,831999, 844582 > TBR=disabled test owners > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I67c3980009fc07897f1f6bab424ef6c5f11d4830 > Reviewed-on: https://chromium-review.googlesource.com/1061795 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560147} TBR=thakis@chromium.org,dpranke@chromium.org,kbr@chromium.org Change-Id: I645e08d0ae374f181836e5d3749f39e17e54d9f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 , 831999, 844582 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1067052 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560158} [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/media/cast/receiver/audio_decoder_unittest.cc [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.android.fyi.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.android.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.clang.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.gpu.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.linux.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.mac.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.memory.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.win.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/test_suites.pyl [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/third_party/libjingle_xmpp/README.chromium [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/third_party/libjingle_xmpp/task_runner/task_unittest.cc [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/tools/battor_agent/battor_connection_impl_unittest.cc [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/ui/compositor/layer_unittest.cc
,
Jun 8 2018
Now that the GPU-specific generate_buildbot_json script has been merged into the main one in src/testing/buildbot in Issue 844815 , we should consider cleanups and merges of the various GPU-related tests, too, to make them easier to maintain. Issue 850252 has been filed for more general cleanups; feel free to file more bugs, reopen this one, or add suggestions to that bug. |
||
►
Sign in to add a comment |
||
Comment 1 by kbr@chromium.org
, May 18 2018Status: WontFix (was: Untriaged)