[Macviews] Hotkeys don't work when permission dialog is showing. |
||
Issue description1) Navigate to https://googlechrome.github.io/samples/permissions/ 2) Click on "geolocation" 3) Click cmd+W to close the tab. Expected results: tab closes Actual results: nothing happens. cmd+t also doesn't work. hotkey dispatch in general is broken.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8b301d1cf2685e29c1c6d6dacad7aacac8995d0 commit d8b301d1cf2685e29c1c6d6dacad7aacac8995d0 Author: erikchen <erikchen@chromium.org> Date: Wed May 30 16:56:13 2018 MacViews: Fix broken hotkeys when permission dialog is showing. BubbleDialogDelegate was failing to call SetAlwaysRenderAsActive() if the anchor was set after the visibility callback. This caused -[NativeWidgetMacNSWindow hasKeyAppearance] of the parent window to return NO if a bubble window was key. This caused -[CommandDispatcher bubbleParent] to return nil. And this caused keyEquivalents sent to bubbles to fail to propagate to the parent window. Bug: 844571 Change-Id: I20179a1f432a0cd363b334d6eede30736875f6f7 Reviewed-on: https://chromium-review.googlesource.com/1067860 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#562872} [add] https://crrev.com/d8b301d1cf2685e29c1c6d6dacad7aacac8995d0/chrome/browser/ui/views/permission_bubble/permission_bubble_views_interactive_uitest_mac.mm [modify] https://crrev.com/d8b301d1cf2685e29c1c6d6dacad7aacac8995d0/chrome/test/BUILD.gn [modify] https://crrev.com/d8b301d1cf2685e29c1c6d6dacad7aacac8995d0/ui/views/bubble/bubble_dialog_delegate.cc [modify] https://crrev.com/d8b301d1cf2685e29c1c6d6dacad7aacac8995d0/ui/views/bubble/bubble_dialog_delegate.h [modify] https://crrev.com/d8b301d1cf2685e29c1c6d6dacad7aacac8995d0/ui/views/bubble/bubble_dialog_delegate_unittest.cc
,
May 31 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by tapted@chromium.org
, May 22 2018