Add ANGLE apk build to official chrome build |
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36 Steps to reproduce the problem: Want to add an ANGLE apk to the official build process. Build target: third_party/angle:angle_apk What is the expected behavior? What went wrong? NA Did this work before? N/A Chrome version: 66.0.3359.181 Channel: stable OS Version: Flash Version:
,
May 21 2018
The issue seems to be a feature request. Hence, marking it as untriaged for further inputs from dev team. Thanks...!!
,
May 21 2018
Courtney is this something different than issue angleproject:2573 ?
,
May 21 2018
Yes, angleproject:2573 is the same. I logged the request there first and then found out I should log it on chromium bug tracker.
,
May 21 2018
Can you provide a bit more description of what you need?
,
May 21 2018
I would like the chrome official build to include an ANGLE apk for Android. This apk would then be used in subsequent Android builds and Play Store integration. Very similar, I believe, to AndroidWebView apk. Build target would be: third_party/angle:angle_apk Release build args I use (need to verify this is correct for official builds): target_os = "android" target_cpu = "arm64" is_debug = false android32_ndk_api_level = 26 android64_ndk_api_level = 26 build_angle_deqp_tests = true ffmpeg_branding = "Chrome" is_component_build = false proprietary_codecs = true symbol_level = 1 angle_enable_vulkan = true angle_enable_vulkan_validation_layers = false angle_libs_suffix = "_angle" build_apk_secondary_abi = true
,
May 21 2018
,
May 21 2018
Create an initial CL in https://crrev.com/i/629070, but it won't let me add coutneygo@ to the reviewers.
,
May 22 2018
Re #6: some of these seem to be unnecessary. Courtney, can you confirm if your use cases still work with: target_os = "android" target_cpu = "arm64" is_debug = false android32_ndk_api_level = 26 android64_ndk_api_level = 26 symbol_level = 1 angle_enable_vulkan_validation_layers = false angle_libs_suffix = "_angle" build_apk_secondary_abi = true Also worth mentioning that we need the apk in 64 bit build, but it should include 32 bit libraries inside it as well. That's what 'target_cpu = "arm64" build_apk_secondary_abi = true' are for.
,
May 22 2018
,
May 23 2018
Yes, I have confirmed that the ANGLE apk builds and runs as expected with these args.
,
May 24 2018
Thanks, Courtney! mmoss@, could you please update https://crrev.com/i/629070 with what I wrote in #9 about flags and architectures?
,
May 30 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/fda7bfe22ff3b31e6c01f7fa40a79136fbe88724 commit fda7bfe22ff3b31e6c01f7fa40a79136fbe88724 Author: Michael Moss <mmoss@google.com> Date: Wed May 30 16:27:36 2018
,
May 30 2018
This should show up in tonight's builds.
,
Jun 7 2018
Looking at official-arm_64 build 3279, "stdio" link in "Archive out/Release/apks/AngleLibraries.apk" points to a page that is not found. Also, it's missing "Unsigned Bucket" link. The apk does appear in the cloud storage, which is great, thanks! Whom should we contact to fix the links from the bot page? |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by krajshree@chromium.org
, May 20 2018