New issue
Advanced search Search tips

Issue 844566 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Add ANGLE apk build to official chrome build

Project Member Reported by courtneygo@google.com, May 18 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36

Steps to reproduce the problem:
Want to add an ANGLE apk to the official build process.

Build target: third_party/angle:angle_apk

What is the expected behavior?

What went wrong?
NA

Did this work before? N/A 

Chrome version: 66.0.3359.181  Channel: stable
OS Version: 
Flash Version:
 
Labels: Needs-Triage-M66
Components: Internals>GPU>ANGLE Build
Labels: M-68 Triaged-ET FoundIn-68 Target-68
Status: Untriaged (was: Unconfirmed)
The issue seems to be a feature request. Hence, marking it as untriaged for further inputs from dev team.

Thanks...!!
Courtney is this something different than  issue angleproject:2573  ?
Yes, angleproject:2573 is the same. I logged the request there first and then found out I should log it on chromium bug tracker.
Can you provide a bit more description of what you need?
I would like the chrome official build to include an ANGLE apk for Android.
This apk would then be used in subsequent Android builds and Play Store integration. Very similar, I believe, to AndroidWebView apk.
Build target would be: third_party/angle:angle_apk

Release build args I use (need to verify this is correct for official builds):
target_os = "android"
target_cpu = "arm64"
is_debug = false
android32_ndk_api_level = 26
android64_ndk_api_level = 26
build_angle_deqp_tests = true
ffmpeg_branding = "Chrome"
is_component_build = false
proprietary_codecs = true
symbol_level = 1
angle_enable_vulkan = true
angle_enable_vulkan_validation_layers = false
angle_libs_suffix = "_angle"
build_apk_secondary_abi = true


Comment 7 by mmoss@chromium.org, May 21 2018

Cc: mmoss@chromium.org jbudorick@chromium.org

Comment 8 by mmoss@chromium.org, May 21 2018

Create an initial CL in https://crrev.com/i/629070, but it won't let me add coutneygo@ to the reviewers.
Labels: -OS-Linux OS-Android
Re #6: some of these seem to be unnecessary.

Courtney, can you confirm if your use cases still work with:

target_os = "android"
target_cpu = "arm64"
is_debug = false
android32_ndk_api_level = 26
android64_ndk_api_level = 26
symbol_level = 1
angle_enable_vulkan_validation_layers = false
angle_libs_suffix = "_angle"
build_apk_secondary_abi = true

Also worth mentioning that we need the apk in 64 bit build, but it should include 32 bit libraries inside it as well. That's what 'target_cpu = "arm64" build_apk_secondary_abi = true' are for.
Cc: courtneygo@google.com
Yes, I have confirmed that the ANGLE apk builds and runs as expected with these args.
Cc: -mmoss@chromium.org
Owner: mmoss@chromium.org
Status: Assigned (was: Untriaged)
Thanks, Courtney!
mmoss@, could you please update https://crrev.com/i/629070 with what I wrote in #9 about flags and architectures?
Project Member

Comment 13 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/fda7bfe22ff3b31e6c01f7fa40a79136fbe88724

commit fda7bfe22ff3b31e6c01f7fa40a79136fbe88724
Author: Michael Moss <mmoss@google.com>
Date: Wed May 30 16:27:36 2018

Comment 14 by mmoss@google.com, May 30 2018

Status: Fixed (was: Assigned)
This should show up in tonight's builds.
Looking at official-arm_64 build 3279, "stdio" link in "Archive out/Release/apks/AngleLibraries.apk" points to a page that is not found.
Also, it's missing "Unsigned Bucket" link.
The apk does appear in the cloud storage, which is great, thanks!

Whom should we contact to fix the links from the bot page?

Sign in to add a comment