WebUI: change cr-radio-button to inline-flex |
|||
Issue descriptionnative radio-buttons are inline, paper-radio-button used to be inline, so cr-radio-button should be inline too. remember to go back to https://chromium-review.googlesource.com/c/chromium/src/+/1059866 and check that all the places where display:block is specified should be added back.
,
Oct 21
Is it ok if i take this issue?
,
Oct 24
Isn't inline the default for the outer display?
,
Oct 25
@scottchen: Are there any known regressions because of this change? Do we even need to do anything here?
,
Nov 9
I think there's nothing broken right now, since when I swapped paper-radio-button to cr-, I did style everything correctly based on flex, but I think during a discussion we said it's best to match the native radio-button as much as possible so future users aren't surprised.
,
Nov 9
I tested a bit locally and found out there's more cr-radio-button instances now we're assuming are *not* inline, so gonna close this bug as obsolete. |
|||
►
Sign in to add a comment |
|||
Comment 1 by benhenry@chromium.org
, Aug 2