New issue
Advanced search Search tips

Issue 844540 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
AOM
Team-Accessibility

Blocking:
issue 746523



Sign in to add a comment

Implement ARIA reflection

Project Member Reported by dmazz...@chromium.org, May 18 2018

Issue description

The Accessibility Object Model (AOM) spec now depends on reflecting all non-deprecated ARIA attributes on HTML elements.

The proposed spec change is here:
https://github.com/w3c/aria/pull/708/files

 
Blocking: 746523
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82875786730504c91154dca8bcc974d514d8f2f6

commit 82875786730504c91154dca8bcc974d514d8f2f6
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue May 22 05:19:38 2018

Reflect all non-deprecated ARIA attributes.

The Accessibility Object Model (AOM) spec now depends on
reflecting all non-deprecated ARIA attributes. The
proposed spec is here:
https://github.com/w3c/aria/pull/708/files

Keep this behind the AccessibilityObjectModel
feature flag.

Bug:  844540 

Change-Id: Id05908fc27cd2e8ff4f67136e6f5859d5f63a097
Reviewed-on: https://chromium-review.googlesource.com/1066320
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560488}
[add] https://crrev.com/82875786730504c91154dca8bcc974d514d8f2f6/third_party/WebKit/LayoutTests/accessibility/aria-reflection.html
[modify] https://crrev.com/82875786730504c91154dca8bcc974d514d8f2f6/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/82875786730504c91154dca8bcc974d514d8f2f6/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/82875786730504c91154dca8bcc974d514d8f2f6/third_party/blink/renderer/core/core_idl_files.gni
[add] https://crrev.com/82875786730504c91154dca8bcc974d514d8f2f6/third_party/blink/renderer/core/dom/accessibility_role.idl
[add] https://crrev.com/82875786730504c91154dca8bcc974d514d8f2f6/third_party/blink/renderer/core/dom/aria_attributes.idl

Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a07b9c5c8a7b58ba066c0bcf6baf0feeb36510a

commit 8a07b9c5c8a7b58ba066c0bcf6baf0feeb36510a
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu May 31 02:35:50 2018

Update url for ARIA IDL spec.

The implementation was based on a PR that has now been merged.

TBR=aboxhall@chromium.org,haraken@chromium.org

Bug:  844540 
Change-Id: I9daec3930c465428c38c52cfc1c107b30005721e
Reviewed-on: https://chromium-review.googlesource.com/1080216
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563127}
[modify] https://crrev.com/8a07b9c5c8a7b58ba066c0bcf6baf0feeb36510a/third_party/blink/renderer/core/dom/accessibility_role.idl
[modify] https://crrev.com/8a07b9c5c8a7b58ba066c0bcf6baf0feeb36510a/third_party/blink/renderer/core/dom/aria_attributes.idl

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e8eec5964420475612df2c2a1895597366d2f6e

commit 7e8eec5964420475612df2c2a1895597366d2f6e
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Jun 18 09:08:57 2018

Fix ARIA reflection of aria-pressed and aria-readonly.

They were accidentally mixed up in both the IDL and the tests.
(I used a macro to generate the tests from the IDL, so the same
bug crept into both.)

Bug:  844540 
Change-Id: I04023b609402e2b795a69a785c7f04af3c9459f7
Reviewed-on: https://chromium-review.googlesource.com/1103447
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567955}
[modify] https://crrev.com/7e8eec5964420475612df2c2a1895597366d2f6e/third_party/WebKit/LayoutTests/accessibility/aria-reflection.html
[modify] https://crrev.com/7e8eec5964420475612df2c2a1895597366d2f6e/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/7e8eec5964420475612df2c2a1895597366d2f6e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7e8eec5964420475612df2c2a1895597366d2f6e/third_party/blink/renderer/core/dom/aria_attributes.idl

Status: Fixed (was: Started)
PTAL at bug 914469 - r560488 above incorrectly defines several properties.

Sign in to add a comment