<foreignObject> can now composite, which breaks some content |
||||||||||
Issue descriptionExample attached. This is a breakout bug from issue 842668 .
,
May 18 2018
Tagging as "RBS" for M67 per offline chat with chrishtr@.
,
May 18 2018
Assigning to chrishtr@ who is working on simple fix - https://chromium-review.googlesource.com/c/chromium/src/+/1066403.
,
May 18 2018
(I understand this is a Chromium issue and not with other browsers)
,
May 18 2018
Yes this is a Chromium issue.
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1112dc78a874f228a78a7ab4d484e32e46f360f1 commit 1112dc78a874f228a78a7ab4d484e32e46f360f1 Author: Chris Harrelson <chrishtr@chromium.org> Date: Fri May 18 23:20:32 2018 [ForeignObject] Don't allow <foreignObject> to composite in SPv1 mode. This reduces the instance of broken content due to the fundamental compositing bug. Bug: 844538 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie8841d3cccf58d4b7760366bb6537cfdb3c55d82 Reviewed-on: https://chromium-review.googlesource.com/1066403 Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560094} [add] https://crrev.com/1112dc78a874f228a78a7ab4d484e32e46f360f1/third_party/WebKit/LayoutTests/compositing/foreign-object-not-composited-expected.html [add] https://crrev.com/1112dc78a874f228a78a7ab4d484e32e46f360f1/third_party/WebKit/LayoutTests/compositing/foreign-object-not-composited.html [modify] https://crrev.com/1112dc78a874f228a78a7ab4d484e32e46f360f1/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
,
May 19 2018
Pls update the bug with canary result on Monday morning and request a merge to M67 if change looks safe to merge. Thank you.
,
May 19 2018
I have just checked on Version 68.0.3435.0 (Official Build) canary (64-bit) / MacOS 10.13.4. Both the attached test case fo2.html and the application https://app.moqups.com work correctly in the latest build. Chris, thank you so much for addressing this!
,
May 20 2018
Verified on 68.0.3435.0. This is a safe CL to merge.
,
May 20 2018
This bug requires manual review: We are only 8 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 20 2018
Approving merge to M67 branch 3396 based on comment #8 and #9. Please merge and mark bug as fixed if nothing else is pending. Thank you.
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be04d70aae75a33d165ff42d01d1f97f2c80272e commit be04d70aae75a33d165ff42d01d1f97f2c80272e Author: Chris Harrelson <chrishtr@chromium.org> Date: Mon May 21 03:40:45 2018 [ForeignObject] Don't allow <foreignObject> to composite in SPv1 mode. This reduces the instance of broken content due to the fundamental compositing bug. Bug: 844538 TBR=chrishtr@chromium.org (cherry picked from commit 1112dc78a874f228a78a7ab4d484e32e46f360f1) Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie8841d3cccf58d4b7760366bb6537cfdb3c55d82 Reviewed-on: https://chromium-review.googlesource.com/1066403 Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#560094} Reviewed-on: https://chromium-review.googlesource.com/1067238 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#655} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [add] https://crrev.com/be04d70aae75a33d165ff42d01d1f97f2c80272e/third_party/WebKit/LayoutTests/compositing/foreign-object-not-composited-expected.html [add] https://crrev.com/be04d70aae75a33d165ff42d01d1f97f2c80272e/third_party/WebKit/LayoutTests/compositing/foreign-object-not-composited.html [modify] https://crrev.com/be04d70aae75a33d165ff42d01d1f97f2c80272e/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
,
May 21 2018
,
May 21 2018
The NextAction date has arrived: 2018-05-21 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by chrishtr@chromium.org
, May 18 2018