New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844532 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

SmartLock is broken (unavailable) on CrOS signin

Project Member Reported by jhawkins@chromium.org, May 18 2018

Issue description

Looks like a regression in the native signin implementation, as SmartLock works when switching to the WebUI version.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9ea11d6beb1685ab6cc65d21e2cc6725e606403

commit f9ea11d6beb1685ab6cc65d21e2cc6725e606403
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon May 21 18:58:16 2018

LoginDisplayHostMojo: Wire up (more) SmartLock.

This fixes a regression in the sense that Views login recently became
the default for some set of users, and SmartLock probably never worked
for login on Views (but it did work on WebUI login).

R=jdufault@chromium.org

Bug:  844532 
Test: none yet, need to write E2E
Change-Id: I736f2ea3e8b7fc4d961852c5fb649f03a904d333
Reviewed-on: https://chromium-review.googlesource.com/1066935
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560319}
[modify] https://crrev.com/f9ea11d6beb1685ab6cc65d21e2cc6725e606403/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc

Status: Fixed (was: Started)

Sign in to add a comment