New issue
Advanced search Search tips

Issue 844529 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Footer not rendered according to spec

Project Member Reported by ftirelo@chromium.org, May 18 2018

Issue description

Chrome Version: M68
OS: desktop

A few minor issues with the footer:
 - not all footer items have a separator at the top;
 - there is a white padding at the bottom of the dropdown, below the last footer item.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dfefe12fd3cdda36726ebc86111e4e32167ff40

commit 9dfefe12fd3cdda36726ebc86111e4e32167ff40
Author: Tommy Martino <tmartino@chromium.org>
Date: Wed May 23 22:40:09 2018

[Autofill Views] Fixing footer and separators

This CL addresses a few visual issues, mostly surrounding the footer:
- Each footer item should have a border at the top. These should not
  carry any extra padding.
- The model should not send a separator before the footer, since it
  would now be redundant.
- The gray background on the footer should extend all the way to the
  bottom of the popup. This is accomplished by removing the padding
  at the root level and adding it to a new container around the footer
  elements.

This also introduces the structure we will need when we later re-enable
scrolling, so that the "content" rows (non-footer) can scroll while the
footer remains "sticky."

Change-Id: I54b07c6a76dc07e230ec03e1762c09f77397ed6f
Bug:  844529 
Reviewed-on: https://chromium-review.googlesource.com/1062708
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561287}
[modify] https://crrev.com/9dfefe12fd3cdda36726ebc86111e4e32167ff40/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/9dfefe12fd3cdda36726ebc86111e4e32167ff40/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc
[modify] https://crrev.com/9dfefe12fd3cdda36726ebc86111e4e32167ff40/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/9dfefe12fd3cdda36726ebc86111e4e32167ff40/components/autofill/core/browser/autofill_external_delegate_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment