Add test for header.js |
||
Issue descriptionI am not very familiar with UI code in general. There is a review comment to the changes I made in crrev.vom/c/1056494 that tests are missing for header in general. Hence I created this bug to track this issue. We can mark it closed if tests already exist.
,
May 23 2018
Sounds good. Thanks, Rebekah.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27b08932c9aa63098cdd0547843196ce65f28f8b commit 27b08932c9aa63098cdd0547843196ce65f28f8b Author: rbpotter <rbpotter@chromium.org> Date: Thu May 24 22:27:56 2018 Print Preview Componentization: Add unit tests for print-preview-header Bug: 844513 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic00f1af465b742a23701a85aad2f0d68d22f8808 Reviewed-on: https://chromium-review.googlesource.com/1071071 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#561655} [modify] https://crrev.com/27b08932c9aa63098cdd0547843196ce65f28f8b/chrome/browser/resources/print_preview/new/header.js [add] https://crrev.com/27b08932c9aa63098cdd0547843196ce65f28f8b/chrome/test/data/webui/print_preview/header_test.js [modify] https://crrev.com/27b08932c9aa63098cdd0547843196ce65f28f8b/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
,
May 25 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rbpotter@chromium.org
, May 23 2018Labels: -Pri-3 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Owner: rbpotter@chromium.org
Status: Assigned (was: Untriaged)