New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 844508 link

Starred by 2 users
Status: Fixed
Owner:
alexilin@chromium.org
Closed: Jun 2018
Cc:
mattcary@chromium.org
█ jdmuys@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 845985
Blocking:
issue 795291



Sign in to add a comment

media/audio shared memory refactor

Project Member Reported by alexilin@chromium.org, May 18 2018 
The deprecated SharedMemoryHandle is used across several classes. There are two types of audio streams: input and output. They should be converted into ReadOnly and Unsafe regions correspondingly.

There are a producer and a client of audio steams for both input and output. It's possible to make this conversion gradually, modifying one side of the mojo communication channel after another. The main producer classes are AudioInputSyncWriter and AudioSyncReader. I'm proposing to start this change from them.

There is one inconvenient moment on the consumer side: AudioDeviceThread::Callback is a base class for Audio{Output,Input}Device::AudioThreadCallback that holds a shared memory that should be read-only or writable depending on whether it's output or input device. This class structure should be refactored because in the new shmem API read-only and writable shared memory are represented by different classes.

Comment 1 by alexilin@chromium.org, May 22 2018

Status: Started (was: Untriaged)

Comment 2 by alexilin@chromium.org, May 22 2018

Cc: -alexilin@chromium.org
Owner: alexilin@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4140c71c376fc9815d68099f2673e8e286ec5d94

commit 4140c71c376fc9815d68099f2673e8e286ec5d94
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Wed May 23 08:00:00 2018

Convert media::AudioSyncReader to the new shared memory API

This CL changes use of base::SharedMemory and base::SharedMemoryHandle
classes in favor of base::UnsafeSharedMemoryRegion in media::AudioSyncReader
and all dependent classes.

Since mojo::SharedBufferHandle can be converted to/from the both APIs
classes, media.mojo.AudioDataPipe interface can stay unchanged until both
sides of a data pipe are converted. Later handle<shared_buffer> should be
replaced by more specific mojo_base.mojom.UnsafeSharedMemoryRegion.

Bug:  844508 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icaf7f873799192433b6413f5b24f260e278929d3
Reviewed-on: https://chromium-review.googlesource.com/1068928
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560999}
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/content/browser/renderer_host/media/audio_output_delegate_impl.cc
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/content/browser/renderer_host/media/old_render_frame_audio_output_stream_factory_unittest.cc
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/media/DEPS
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/media/audio/BUILD.gn
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/media/audio/audio_output_delegate.h
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/media/audio/audio_output_device_unittest.cc
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/media/audio/audio_sync_reader.cc
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/media/audio/audio_sync_reader.h
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/media/audio/audio_sync_reader_unittest.cc
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/media/mojo/services/mojo_audio_output_stream.cc
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/media/mojo/services/mojo_audio_output_stream.h
[modify] https://crrev.com/4140c71c376fc9815d68099f2673e8e286ec5d94/media/mojo/services/mojo_audio_output_stream_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ede01197c12dba181344762d2d121bedbe307f51

commit ede01197c12dba181344762d2d121bedbe307f51
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Wed May 23 17:11:12 2018

Convert media::AudioInputSyncWriter to the new shared memory API

This CL changes use of base::SharedMemory and base::SharedMemoryHandle classes
in favor of base::ReadOnlySharedMemoryRegion in media::AudioInputSyncWriter and
all dependent classes.

Since mojo::SharedBufferHandle can be converted to/from the both APIs
classes, media.mojo.AudioDataPipe interface can stay unchanged until both
sides of a data pipe are converted. Later handle<shared_buffer> should be
replaced by more specific mojo_base.mojom.ReadOnlySharedMemoryRegion.

Bug:  844508 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ieca7c7f22513d0578f92c60d543101b58b4d48bb
Reviewed-on: https://chromium-review.googlesource.com/1067923
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561131}
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/content/browser/renderer_host/media/audio_input_delegate_impl.cc
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/content/browser/renderer_host/media/audio_input_delegate_impl_unittest.cc
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/content/browser/renderer_host/media/audio_input_stream_handle_unittest.cc
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/content/browser/renderer_host/media/old_render_frame_audio_input_stream_factory_unittest.cc
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/media/audio/audio_input_delegate.h
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/media/audio/audio_input_sync_writer.cc
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/media/audio/audio_input_sync_writer.h
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/media/audio/audio_input_sync_writer_unittest.cc
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/media/mojo/services/mojo_audio_input_stream.cc
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/media/mojo/services/mojo_audio_input_stream.h
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/media/mojo/services/mojo_audio_input_stream_unittest.cc
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/services/audio/input_stream.cc
[modify] https://crrev.com/ede01197c12dba181344762d2d121bedbe307f51/services/audio/loopback_stream.cc

Comment 5 by alexilin@chromium.org, May 23 2018

Blockedon: 845985
Project Member

Comment 6 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb0ab8d4593693f42717ea53543e3404152d5eb8

commit cb0ab8d4593693f42717ea53543e3404152d5eb8
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Thu May 24 07:47:11 2018

Return a shmem region from media::AudioSyncReader by value

AudioSyncReader::shared_memory_region() is never called more than once. If we
return a region from this function by value, we don't have to duplicate the
region.

This is a follow-up to https://crrev.com/c/1068928

Bug:  844508 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I22ac7f9bae926ed418c025ac0a8487b98659817a
Reviewed-on: https://chromium-review.googlesource.com/1069352
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561411}
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/content/browser/renderer_host/media/audio_output_delegate_impl.cc
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/content/browser/renderer_host/media/old_render_frame_audio_output_stream_factory_unittest.cc
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/media/audio/audio_output_delegate.h
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/media/audio/audio_output_device_unittest.cc
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/media/audio/audio_sync_reader.cc
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/media/audio/audio_sync_reader.h
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/media/audio/audio_sync_reader_unittest.cc
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/media/mojo/services/mojo_audio_output_stream.cc
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/media/mojo/services/mojo_audio_output_stream.h
[modify] https://crrev.com/cb0ab8d4593693f42717ea53543e3404152d5eb8/media/mojo/services/mojo_audio_output_stream_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20f2841cfd45283617f59666033ade0c6f40119c

commit 20f2841cfd45283617f59666033ade0c6f40119c
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Fri Jun 01 11:56:18 2018

Convert media audio output classes to the new shared memory API.

This CL replaces base::SharedMemory and base::SharedMemoryHandle classes by the
base::UnsafeSharedMemoryRegion in the code related to the audio output on the
renderer side. The dependency chain starts from the content::MojoAudioOutputIPC.

Bug:  844508 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I03b92dcf929fdf050029f8d97b56343ecf7b3a27
Reviewed-on: https://chromium-review.googlesource.com/1076547
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563596}
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/media/audio_output_ipc_factory_unittest.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/media/mojo_audio_output_ipc.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/media/mojo_audio_output_ipc_unittest.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/pepper/audio_helper.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/pepper/audio_helper.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/pepper/pepper_audio_output_host.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/pepper/pepper_audio_output_host.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/pepper/pepper_platform_audio_output.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/pepper/pepper_platform_audio_output.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/pepper/pepper_platform_audio_output_dev.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/pepper/pepper_platform_audio_output_dev.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/pepper/ppb_audio_impl.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/content/renderer/pepper/ppb_audio_impl.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/media/DEPS
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/media/audio/BUILD.gn
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/media/audio/audio_device_thread.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/media/audio/audio_device_thread.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/media/audio/audio_input_device.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/media/audio/audio_output_device.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/media/audio/audio_output_device.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/media/audio/audio_output_device_unittest.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/media/audio/audio_output_ipc.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/ppapi/proxy/audio_output_resource.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/ppapi/proxy/audio_output_resource.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/ppapi/proxy/plugin_dispatcher_unittest.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/ppapi/proxy/ppb_audio_proxy.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/ppapi/proxy/ppb_audio_proxy.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/ppapi/shared_impl/ppb_audio_shared.cc
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/ppapi/shared_impl/ppb_audio_shared.h
[modify] https://crrev.com/20f2841cfd45283617f59666033ade0c6f40119c/ppapi/thunk/ppb_audio_api.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/002a9a285af1aeae5ea32b72bf11d29973c28d41

commit 002a9a285af1aeae5ea32b72bf11d29973c28d41
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Fri Jun 01 13:32:18 2018

Convert media audio input classes to the shared memory API

This CL replaces base::SharedMemory and base::SharedMemoryHandle classes by the
base::ReadOnlySharedMemoryRegion in the code related to the audio input on the
renderer side, notably AudioInputDevice and PepperAudioInputHost.

Bug:  844508 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifb3acc771cb9efcda8f22b2647ceca880451d453
Reviewed-on: https://chromium-review.googlesource.com/1078817
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563608}
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/content/renderer/media/mojo_audio_input_ipc.cc
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/content/renderer/media/mojo_audio_input_ipc_unittest.cc
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/content/renderer/pepper/pepper_audio_input_host.cc
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/content/renderer/pepper/pepper_audio_input_host.h
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/content/renderer/pepper/pepper_platform_audio_input.cc
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/content/renderer/pepper/pepper_platform_audio_input.h
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/media/audio/audio_input_device.cc
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/media/audio/audio_input_device.h
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/media/audio/audio_input_device_unittest.cc
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/media/audio/audio_input_ipc.h
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/media/base/audio_bus.cc
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/media/base/audio_bus.h
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/ppapi/proxy/audio_input_resource.cc
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/ppapi/proxy/audio_input_resource.h
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/services/audio/public/cpp/input_ipc.cc
[modify] https://crrev.com/002a9a285af1aeae5ea32b72bf11d29973c28d41/services/audio/public/cpp/input_ipc_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7525cf0e51a5d9087864bc38859ee56f215e3314

commit 7525cf0e51a5d9087864bc38859ee56f215e3314
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Mon Jun 04 17:17:54 2018

Use the new shared memory API in media.mojom.AudioDataPipe interface

This CL is a final step of the media/audio shared memory refactoring.

The CL changes media.mojom.AudioDataPipe interface so that it uses base shared
memory types directly instead of handle<shared_buffer>. Since input and output
data pipes use different shared memory classes, the AudioDataPipe interface is
split into two interfaces: AudioInputDataPipe and AudioOutputDataPipe.

Bug:  844508 
Change-Id: I10ff396d955c132d500c035c5d81a1a052c7f46b
Reviewed-on: https://chromium-review.googlesource.com/1082534
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564131}
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/media/audio_input_stream_broker.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/media/audio_input_stream_broker.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/media/audio_input_stream_broker_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/media/audio_loopback_stream_broker.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/media/audio_loopback_stream_broker.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/media/audio_loopback_stream_broker_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/media/audio_output_stream_broker.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/media/audio_output_stream_broker.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/media/audio_output_stream_broker_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/renderer_host/media/audio_input_stream_handle.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/renderer_host/media/audio_input_stream_handle.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/renderer_host/media/audio_input_stream_handle_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/renderer_host/media/old_render_frame_audio_input_stream_factory_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/renderer_host/media/old_render_frame_audio_output_stream_factory_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/browser/renderer_host/media/render_frame_audio_input_stream_factory_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/common/media/renderer_audio_input_stream_factory.mojom
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/renderer/media/mojo_audio_input_ipc.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/renderer/media/mojo_audio_input_ipc.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/renderer/media/mojo_audio_input_ipc_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/renderer/media/mojo_audio_output_ipc.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/renderer/media/mojo_audio_output_ipc.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/content/renderer/media/mojo_audio_output_ipc_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/media/mojo/interfaces/audio_data_pipe.mojom
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/media/mojo/interfaces/audio_output_stream.mojom
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/media/mojo/services/mojo_audio_input_stream.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/media/mojo/services/mojo_audio_input_stream.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/media/mojo/services/mojo_audio_input_stream_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/media/mojo/services/mojo_audio_output_stream.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/media/mojo/services/mojo_audio_output_stream.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/media/mojo/services/mojo_audio_output_stream_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/input_stream.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/input_stream.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/input_stream_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/loopback_stream.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/loopback_stream.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/loopback_stream_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/output_stream.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/output_stream.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/output_stream_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/public/cpp/input_ipc.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/public/cpp/input_ipc.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/public/cpp/input_ipc_unittest.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/public/mojom/stream_factory.mojom
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/sync_reader.cc
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/sync_reader.h
[modify] https://crrev.com/7525cf0e51a5d9087864bc38859ee56f215e3314/services/audio/sync_reader_unittest.cc

Comment 10 by alexilin@chromium.org, Jun 5 2018

Status: Fixed (was: Started)
►

Sign in to add a comment