New issue
Advanced search Search tips

Issue 844500 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

send have_context as argument to OnWillDestroyStub

Project Member Reported by liber...@chromium.org, May 18 2018

Issue description

during stub destruction, the stub tries to make the context current. 
 OnWillDestroyStub isn't told whether that succeeds or fails.

we should send that info in.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7

commit ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7
Author: liberato@chromium.org <liberato@chromium.org>
Date: Fri May 18 17:12:43 2018

Pass |have_context| to OnWillDestroyStub.

Notify the observers whether or not the GL context is current during
stub destruction.  This allows them to skip any platform GL cleanup
if there's no context.

Bug:  844500 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If53d558be84af8cf2758de3fdf77b8f9c475a8ae
Reviewed-on: https://chromium-review.googlesource.com/1060279
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559932}
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/gpu/ipc/service/command_buffer_stub.h
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/gpu/ipc/service/stream_texture_android.cc
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/gpu/ipc/service/stream_texture_android.h
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/android/command_buffer_stub_wrapper.h
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/android/command_buffer_stub_wrapper_impl.cc
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/android/command_buffer_stub_wrapper_impl.h
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/android/mock_command_buffer_stub_wrapper.cc
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/android/mock_command_buffer_stub_wrapper.h
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/android/texture_pool.cc
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/android/texture_pool.h
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/android/texture_pool_unittest.cc
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/android/video_frame_factory_impl.cc
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/android/video_frame_factory_impl.h
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/command_buffer_helper.cc
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7/media/gpu/ipc/service/gpu_video_decode_accelerator.h

Status: Fixed (was: Started)

Sign in to add a comment