New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844475 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add support for display name

Project Member Reported by zentaro@chromium.org, May 18 2018

Issue description

Add the plumbing needed to support a display name as well as the canonicalized URL.

Currently the files app shows the same string as the mount path, but it should support a custom/prettier name too.

This doesn't include the UI work to allow the user to customize it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bea1688044bf0aae1ed5ce606f23c84fc7ca19c

commit 9bea1688044bf0aae1ed5ce606f23c84fc7ca19c
Author: Adolfo Victoria <adokar@google.com>
Date: Fri Jun 01 20:02:15 2018

Add File Share name to SmbHandler

This change adds File Share name as an argument that is passed from
the Add Smb Share Dialog box to the Smb Browser Proxy to SmbHandler.
The change allows users to customize the display name of the file share.
If the user decides to leave the field blank, the mount url is
displayed.

BUG= chromium:844475 
TEST=CrSettingsSmbPageTest.All and verified on test device (cave)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id1aee9aedf961a4eccec721459878e6fa0d97847
Reviewed-on: https://chromium-review.googlesource.com/1079960
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Adolfo Higueros <adokar@google.com>
Cr-Commit-Position: refs/heads/master@{#563766}
[modify] https://crrev.com/9bea1688044bf0aae1ed5ce606f23c84fc7ca19c/chrome/app/settings_strings.grdp
[modify] https://crrev.com/9bea1688044bf0aae1ed5ce606f23c84fc7ca19c/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
[modify] https://crrev.com/9bea1688044bf0aae1ed5ce606f23c84fc7ca19c/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.js
[modify] https://crrev.com/9bea1688044bf0aae1ed5ce606f23c84fc7ca19c/chrome/browser/resources/settings/downloads_page/smb_browser_proxy.js
[modify] https://crrev.com/9bea1688044bf0aae1ed5ce606f23c84fc7ca19c/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc
[modify] https://crrev.com/9bea1688044bf0aae1ed5ce606f23c84fc7ca19c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/9bea1688044bf0aae1ed5ce606f23c84fc7ca19c/chrome/test/data/webui/settings/smb_shares_page_tests.js

Comment 2 by adokar@google.com, Jun 1 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment