[Payments] Terms of service are not updated on Android |
|||||||||||||
Issue descriptionRepro steps: 1. #enable-autofill-credit-card-upload from chrome://flags 2. enable-autofill-credit-card-upload-update-prompt-explanation from chrome://flags 3. enable #enable-autofill-credit-card-upload-google-pay-on-android-branding in chrome://flags Steps: 1. Launch Browser 2. Sign into Chrome 3. Enable the above flags 4. https://dump-truck.appspot.com/usecase-address_then_cc_text_with_suburb/cc.html (fill with default values, and submit) 5. Observe the permission bubble prompt (see screenshot) Observed: The description message is not updated to "To pay faster next time, save your card **and billing address** to your Google Account and to this device."
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c9d3a0a6361d0a048d4cef03359b6a8caaca691 commit 2c9d3a0a6361d0a048d4cef03359b6a8caaca691 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Fri May 18 17:13:58 2018 [AF] Updates the save CC prompt message on mobile Updates the prompt message on mobile to take into account the AutofillUpstreamUpdatePromptExplanation experiment similar to Desktop Bug: 844472 Change-Id: I24bbabbb1af5f1d559196b6dccca5e600aff13ad Reviewed-on: https://chromium-review.googlesource.com/1066212 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#559933} [modify] https://crrev.com/2c9d3a0a6361d0a048d4cef03359b6a8caaca691/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
,
May 18 2018
,
May 18 2018
,
May 18 2018
Requesting to merge this into M67 (after verifying the change on Canary).
,
May 18 2018
,
May 18 2018
This bug requires manual review: We are only 10 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 21 2018
Is this issue a regression in M67?
,
May 21 2018
It's the Android implementation for Issue 836908, which is taking the Fast Path launch process.
,
May 22 2018
This issue is still reproducible on latest M67-67.0.3396.55 and M68- 68.0.3437.0
,
May 22 2018
dknandiraju: Please put a screenshot of what you're seeing, so that we can review.
,
May 22 2018
,
May 22 2018
Updated the instructions, PTAL again.
,
May 22 2018
Yep to clarify, that testing screenshot is missing Kumar's change that uses the brand new Chrome Upstream on Android credit card save infobar. However, I think the flag for that is "#enable-autofill-credit-card-upload-google-pay-on-android-branding", not what Mathieu added in the description? Kumar, can you confirm?
,
May 22 2018
,
May 22 2018
Description updated, again :)
,
May 23 2018
Re-tested with below 3 flags: 1.#enable-autofill-credit-card-upload from chrome://flags 2. enable-autofill-credit-card-upload-update-prompt-explanation from chrome://flags 3. enable #enable-autofill-credit-card-upload-google-pay-on-android-branding in chrome://flags Here is testing screenshot
,
May 23 2018
The message looks good.
,
May 23 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fda0bf62e8b16780446092f2bf118e7ab12c34b commit 5fda0bf62e8b16780446092f2bf118e7ab12c34b Author: Mathieu Perreault <mathp@chromium.org> Date: Wed May 23 19:50:51 2018 [AF] Updates the save CC prompt message on mobile Updates the prompt message on mobile to take into account the AutofillUpstreamUpdatePromptExplanation experiment similar to Desktop TBR=mahmadi@chromium.org (cherry picked from commit 2c9d3a0a6361d0a048d4cef03359b6a8caaca691) Bug: 844472 Change-Id: I24bbabbb1af5f1d559196b6dccca5e600aff13ad Reviewed-on: https://chromium-review.googlesource.com/1066212 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#559933} Reviewed-on: https://chromium-review.googlesource.com/1070484 Cr-Commit-Position: refs/branch-heads/3396@{#687} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/5fda0bf62e8b16780446092f2bf118e7ab12c34b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
,
May 23 2018
Let's verify on the next M67 release.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c7c132a3e5564fa63c40e1a5935267817fe5c2c commit 0c7c132a3e5564fa63c40e1a5935267817fe5c2c Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu May 24 17:07:17 2018 [AF] Field trial for the new save card infobar explanation for mobile Bug: 844472 Change-Id: I3a90de7feef9f7f0829e17110f51c5376bc4df1b Reviewed-on: https://chromium-review.googlesource.com/1070514 Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561532} [modify] https://crrev.com/0c7c132a3e5564fa63c40e1a5935267817fe5c2c/testing/variations/fieldtrial_testing_config.json
,
May 24 2018
Verified in M67 and able to see expected info-bar. When we tap on save button on info-bar-> Is this credit-card will save under Autofill and Payments?
,
May 24 2018
Yes; if it's the infobar with the GPay logo in the top-left, the credit card will be saved to payments.google.com as well as Chrome Autofill.
,
May 26 2018
Ok Thanks!! Unable to save credit cards with my test account, looks like it is blocked by the Risk team I will try with sandbox scenario with different test account
,
May 28 2018
Thank you kravula@. No need to test saving of credit cards as long as the messaging is as expected.
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5e2fe6729a7534871cb08c8517f520d4c0dcd09 commit f5e2fe6729a7534871cb08c8517f520d4c0dcd09 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Jun 13 16:04:56 2018 [AF][IOS] Adds entry to chrome://flags for CC inforbar's new prompt message Bug: 844472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5730eec078efe8de37be6acce002d15bfeaa7212 Reviewed-on: https://chromium-review.googlesource.com/1099051 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#566852} [modify] https://crrev.com/f5e2fe6729a7534871cb08c8517f520d4c0dcd09/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/f5e2fe6729a7534871cb08c8517f520d4c0dcd09/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/f5e2fe6729a7534871cb08c8517f520d4c0dcd09/ios/chrome/browser/ios_chrome_flag_descriptions.h
,
Jun 13 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26fa58f588118633c901b1ae756dfa78728e9816 commit 26fa58f588118633c901b1ae756dfa78728e9816 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Jun 13 18:22:10 2018 [AF][IOS] Adds entry to chrome://flags for CC inforbar's new prompt message TBR=mahmadi@chromium.org (cherry picked from commit f5e2fe6729a7534871cb08c8517f520d4c0dcd09) Bug: 844472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5730eec078efe8de37be6acce002d15bfeaa7212 Reviewed-on: https://chromium-review.googlesource.com/1099051 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566852} Reviewed-on: https://chromium-review.googlesource.com/1099562 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#336} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/26fa58f588118633c901b1ae756dfa78728e9816/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/26fa58f588118633c901b1ae756dfa78728e9816/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/26fa58f588118633c901b1ae756dfa78728e9816/ios/chrome/browser/ios_chrome_flag_descriptions.h
,
Jun 20 2018
Verified in : App Version: 68.0.3440.33 beta Devices: iPhone 7 Plus, iPhone 8 Plus, iPad Mini iOS Versions: 10.3.3, 11.4, 11.4.1 beta 2 #enable-autofill-credit-card-upload-update-prompt-explanation flag is available under chrome://flags & enabling the flag, new prompt message has been displayed for CC infobar |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by ma...@chromium.org
, May 18 2018101 KB
101 KB View Download