Delete obsolete tests after launching OOP-D. |
|
Issue descriptionDelete tests for code that is going to be deleted when OOP-D is launched on all platforms. These tests should early out when OOP-D is enabled until they can be deleted. if (base::FeatureList::IsEnabled(features::kVizDisplayCompositor)) return;
,
May 23 2018
And: RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface
,
May 23 2018
And: RenderWidgetHostViewAuraSurfaceSynchronizationTest.CompositorFrameSinkChange RenderWidgetHostViewAuraSurfaceSynchronizationTest.DiscardDelegatedFrames RenderWidgetHostViewAuraSurfaceSynchronizationTest.DropFallbackWhenHidden RenderWidgetHostViewAuraSurfaceSynchronizationTest.SurfaceChanges RenderWidgetHostViewAuraTest.BackgroundColorMatchesCompositorFrame RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithLocking RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithMemoryPressure RenderWidgetHostViewAuraTest.ForwardsBeginFrameAcks RenderWidgetHostViewAuraTest.HitTestRegionListSubmitted RenderWidgetHostViewAuraTest.OutputSurfaceIdChange RenderWidgetHostViewAuraTest.ForwardsBeginFrameAcks RenderWidgetHostViewAuraTest.TwoOutputSurfaces
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59d82432704fb58507671b44b0e1428efb129afb commit 59d82432704fb58507671b44b0e1428efb129afb Author: kylechar <kylechar@chromium.org> Date: Mon May 28 19:53:19 2018 viz: Fix ImageTransportFactory tests with OOP-D. For ImageTransportFactoryBrowserTest.TestLostContext to make it compatible with OOP-D. The test doesn't need to use GLHelper / OwnedMailbox to check if observers are notified about context loss. For ImageTransportFactoryTearDownBrowserTest.LoseOnTearDown just early exit for OOP-D. The test makes sure that ContextLossObservers get OnContextLost() called on ImageTransportFactory destruction. This is related to GLHelper so it's not needed with OOP-D. Also don't compile the tests on macOS. They're disabled there anyways. Bug: 785268 , 844469 Change-Id: I1c0513e0535bb841b4e8b843ebb54a97dcfe4ad8 Reviewed-on: https://chromium-review.googlesource.com/1066274 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#562302} [modify] https://crrev.com/59d82432704fb58507671b44b0e1428efb129afb/content/browser/compositor/image_transport_factory_browsertest.cc [modify] https://crrev.com/59d82432704fb58507671b44b0e1428efb129afb/content/test/BUILD.gn [modify] https://crrev.com/59d82432704fb58507671b44b0e1428efb129afb/testing/buildbot/filters/viz.content_browsertests.filter
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/374ee4c2d84c4e347a0b65859ecdcfc00de234c9 commit 374ee4c2d84c4e347a0b65859ecdcfc00de234c9 Author: Saman Sami <samans@chromium.org> Date: Tue Jun 19 02:13:16 2018 content/viz: Fix and re-enable some tests Some tests that were disabled for being irrelevant to viz are not actually that irrelevant; they just need some minor adjustments. - RenderWidgetHostViewAuraSurfaceSynchronizationTest.DiscardDelegatedFrames - RenderWidgetHostViewAuraSurfaceSynchronizationTest.DropFallbackWhenHidden - RenderWidgetHostViewAuraSurfaceSynchronizationTest.SurfaceChanges - RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithLocking - RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithMemoryPressure - RenderWidgetHostViewChildFrameTest.SwapCompositorFrame Bug: 844469 Change-Id: Iddc1fdf6ebdb984afa277d537b326e7005ab1777 Reviewed-on: https://chromium-review.googlesource.com/1105312 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#568301} [modify] https://crrev.com/374ee4c2d84c4e347a0b65859ecdcfc00de234c9/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/374ee4c2d84c4e347a0b65859ecdcfc00de234c9/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/374ee4c2d84c4e347a0b65859ecdcfc00de234c9/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/306b51ebfdaaaabccc3fcce55a71209932aa243b commit 306b51ebfdaaaabccc3fcce55a71209932aa243b Author: Saman Sami <samans@chromium.org> Date: Tue Jun 19 17:35:02 2018 Move code from SubmitCompositorFrame to OnFirstSurfaceActivation Also clean up the code and re-enable RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface. Bug: 730193, 844469 Change-Id: I20f17fda6094b1ffb6bbb1482ccd14f6c20175ea Reviewed-on: https://chromium-review.googlesource.com/1104798 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568514} [modify] https://crrev.com/306b51ebfdaaaabccc3fcce55a71209932aa243b/content/browser/browser_plugin/browser_plugin_guest.cc [modify] https://crrev.com/306b51ebfdaaaabccc3fcce55a71209932aa243b/content/browser/browser_plugin/browser_plugin_guest.h [modify] https://crrev.com/306b51ebfdaaaabccc3fcce55a71209932aa243b/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/306b51ebfdaaaabccc3fcce55a71209932aa243b/content/browser/frame_host/render_widget_host_view_guest.h [modify] https://crrev.com/306b51ebfdaaaabccc3fcce55a71209932aa243b/content/browser/frame_host/render_widget_host_view_guest_unittest.cc [modify] https://crrev.com/306b51ebfdaaaabccc3fcce55a71209932aa243b/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/306b51ebfdaaaabccc3fcce55a71209932aa243b/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/306b51ebfdaaaabccc3fcce55a71209932aa243b/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by jonr...@chromium.org
, May 23 2018Status: Assigned (was: Available)