When use-zoom-for-dsf enabled, page wasn't zoom correctly when navigate to new site |
|||
Issue descriptionOS: Android What steps will reproduce the problem? (1) enable use-zoom-for dsf (2) open a website (e.g. google.com) (3) navigate to a second website by entering address in address bar(e.g. crbug.com) What is the expected result? both page should be zoomed by device scale What happens instead? the 2nd website wasn't scaled
,
May 19 2018
Actually this is the same issue mentioned in crbug.com/737777#c37 and was fixed in crrev.com/c/690415. And later in crrev.com/c/925682 the added code in WebViewImpl broke the fix. Still investigating how to properly fix it.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d06c10d5f0f8a4b8b69d8113d24ab0ff07be1bf commit 6d06c10d5f0f8a4b8b69d8113d24ab0ff07be1bf Author: Ella Ge <eirage@chromium.org> Date: Thu May 31 14:56:39 2018 remove a return in SetZoomFactorForDeviceScaleFactor The return in SetZoomFactorForDeviceScaleFactor breaks the fix in crrev.com/c/690415: updates zoom-for-dsf navigation. Because WebView DSF wasn't changed when navigation, the early return is preventing propagating the zoom to the newly navigated frames. Bug: 844463 Change-Id: I719116218e2e6d809700624cb5bcf2ade7df2c90 Reviewed-on: https://chromium-review.googlesource.com/1065234 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#563229} [modify] https://crrev.com/6d06c10d5f0f8a4b8b69d8113d24ab0ff07be1bf/content/public/test/render_view_test.cc [modify] https://crrev.com/6d06c10d5f0f8a4b8b69d8113d24ab0ff07be1bf/content/public/test/render_view_test.h [modify] https://crrev.com/6d06c10d5f0f8a4b8b69d8113d24ab0ff07be1bf/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/6d06c10d5f0f8a4b8b69d8113d24ab0ff07be1bf/third_party/blink/renderer/core/exported/web_view_impl.cc
,
May 31 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by eirage@chromium.org
, May 18 2018Components: Blink>Layout