New issue
Advanced search Search tips

Issue 844461 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 737777



Sign in to add a comment

image document is not zoom when use-zoom-for-dsf enabled

Project Member Reported by eirage@chromium.org, May 18 2018

Issue description

OS: Android

What steps will reproduce the problem?
(1) open any image in new tab
(2) Change device display scale.
(3) Notice the image size doesn't change

What is the expected result?
image should be resized when device scale changed.

What happens instead?
image wasn't scaled



 

Comment 1 by eirage@chromium.org, May 18 2018

Blocking: 737777
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62e790d79814eada990712d4ee4300bc765ce897

commit 62e790d79814eada990712d4ee4300bc765ce897
Author: Ella Ge <eirage@chromium.org>
Date: Thu May 31 03:51:03 2018

Image document size apply page zoom on android

Apply PageZoomFactor to image div width for use-zoom-for-dsf
When use-zoom-for-dsf enabled, the visual viewport doesn't have
the device scale factor (DSF) applied, so we need to apply
PageZoomFactor when decide image container size.

This change doesn't need to be under the flag, because when the flag
is disabled, PageZoomFactor is 1.

Bug:  844461 
Change-Id: I1e23cafdef387b97f2c446438668a500225c0deb
Reviewed-on: https://chromium-review.googlesource.com/1065145
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563144}
[modify] https://crrev.com/62e790d79814eada990712d4ee4300bc765ce897/third_party/blink/renderer/core/html/image_document.cc
[modify] https://crrev.com/62e790d79814eada990712d4ee4300bc765ce897/third_party/blink/renderer/core/html/image_document.h
[modify] https://crrev.com/62e790d79814eada990712d4ee4300bc765ce897/third_party/blink/renderer/core/html/image_document_test.cc

Comment 3 by eirage@chromium.org, May 31 2018

Status: Fixed (was: Assigned)

Sign in to add a comment