Link to the logs of it failing on Mac Pro 10.11 Perf:  https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FMac_Pro_10.11_Perf%2F2490%2F%2B%2Frecipes%2Fsteps%2Fsystem_health.memory_desktop_Dashboard_Upload%2F0%2Fstdout


Traceback (most recent call last):
  File "/b/c/b/Mac_Pro_10_11_Perf/src/third_party/catapult/tracing/bin/add_reserved_diagnostics", line 84, in <module>
    sys.exit(main())
  File "/b/c/b/Mac_Pro_10_11_Perf/src/third_party/catapult/tracing/bin/add_reserved_diagnostics", line 72, in main
    dicts, names_to_values)
  File "/b/c/b/Mac_Pro_10_11_Perf/src/third_party/catapult/tracing/tracing/value/diagnostics/add_reserved_diagnostics.py", line 114, in AddReservedDiagnostics
    dicts_across_repeats = _MergeHistogramSetByPath(hs)
  File "/b/c/b/Mac_Pro_10_11_Perf/src/third_party/catapult/tracing/tracing/value/diagnostics/add_reserved_diagnostics.py", line 80, in _MergeHistogramSetByPath
    reserved_infos.TEST_PATH.name,))
  File "/b/c/b/Mac_Pro_10_11_Perf/src/third_party/catapult/tracing/tracing/value/merge_histograms.py", line 33, in MergeHistograms
    str(result.returncode))
Exception: vinn merge_histograms_cmdline.html returned -12
Sending result 2 of 2 to dashboard.
Error uploading histogram data: HTTP Response 400: Bad Request
step returned non-zero exit code: 1

Ethan is out, and this is pretty important. Ben, you're the most familiar with this code, mind taking a look?

 Issue 844480  has been merged into this issue.

I'm able to run this fine on linux, but I get a similar crash on my macbook in vinn.

We build vinn right? How can I tell if they're at the same version?

vinn uses d8 binary which is checked in catapult/ directly. The versions are described in https://github.com/catapult-project/catapult/tree/master/third_party/vinn/third_party/v8

Rolling d8 on mac fixes the issue, sending out the new binary for review now.

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e69d81cbf972cb991e029a3cd41ecde94775cc67

commit e69d81cbf972cb991e029a3cd41ecde94775cc67
Author: Ben Hayden <benjhayden@chromium.org>
Date: Fri May 18 20:37:27 2018

Roll d8 on mac from 5.9 to 6.6.

add_reserved_diagnostics is pushing 44MB json through v8 and hitting segv. This
new version of v8 seems to be able to handle it.

Bug: chromium:844460
Change-Id: I3ef5455a5f715a87558a673a3ea51bb65ba39a94
Reviewed-on: https://chromium-review.googlesource.com/1066507
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/e69d81cbf972cb991e029a3cd41ecde94775cc67/third_party/vinn/third_party/v8/README.chromium
[modify] https://crrev.com/e69d81cbf972cb991e029a3cd41ecde94775cc67/third_party/vinn/third_party/v8/mac/x86_64/d8

eyaich: Does anything need to be re-enabled? This should be fixed now.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3eb3340504ad20735a45fea15170ce7cd907d9ce

commit 3eb3340504ad20735a45fea15170ce7cd907d9ce
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat May 19 00:22:23 2018

Roll src/third_party/catapult/ e2506237b..18ba341db (10 commits)

https://chromium.googlesource.com/catapult.git/+log/e2506237bc2c..18ba341dbc65

$ git log e2506237b..18ba341db --date=short --no-merges --format='%ad %ae %s'
2018-05-18 benjhayden Add paper-tabs to third_party/polymer2.
2018-05-18 benjhayden Add paper-dialog to third_party/polymer2.
2018-05-18 benjhayden Roll d8 on mac from 5.9 to 6.6.
2018-05-18 dtu [pinpoint] Improve error messaging for histograms not found.
2018-05-18 dtu [pinpoint] Remove `assert self.completed` when getting result_values.
2018-05-18 dtu [dashboard] Only pass optional Pinpoint args if they're needed.
2018-05-18 dtu [pinpoint] Improve error messaging for invalid patch URL.
2018-05-18 simonhatch Dashboard - Don't pass None as scope to ServiceAccountHttp
2018-05-18 perezju [soundwave] Fix bug in code to parse test_paths
2018-05-18 dtu [dashboard] Fix OAuth 2.0 scope argument handling.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:844460


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ib1989d22aa409672e9d42d8713f57ee10518f592
Reviewed-on: https://chromium-review.googlesource.com/1066851
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560116}
[modify] https://crrev.com/3eb3340504ad20735a45fea15170ce7cd907d9ce/DEPS

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/5616030be79e0524db4467a92fedced502d988b8

commit 5616030be79e0524db4467a92fedced502d988b8
Author: nednguyen <nednguyen@google.com>
Date: Sat May 19 01:10:02 2018