New issue
Advanced search Search tips

Issue 844453 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 764009
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 764009



Sign in to add a comment

mash: Add GetDisplayIdForNewWindows

Project Member Reported by jamescook@chromium.org, May 18 2018

Issue description

Code in chrome reaches into ash to call Shell::GetRootWindowForNewWindows(). With out-of-process ash it can't do that directly. But it can use Screen, which has a mojo impl to ash/window service.

I think display::GetDisplayIdForNewWindow() could be implemented this way:

ash::Shell (or an OnWindowActivated observer) ->
//services/ui/ws2/window_service.cc ->
ScreenProviderMus ->
(mojo)
ScreenMus

It could follow SetFrameDecorationValues. Maybe it should have its own mojo method to avoid sending the whole display list every time a window activates.

 
Blocking: 764009
I looked at adding GetDisplayForNewWindows() to display::Screen. It felt wrong - Screen is cross-platform and we only need/use this on ash. It's also a bit more complex than I thought it would be.

After chatting with sky, I'm going to look at a Chrome-accessible mirror of this state.

Summary: mash: Add GetDisplayIdForNewWindows (was: mash: Add Screen::GetDisplayIdForNewWindows)
Mergedinto: 764009
Status: Duplicate (was: Started)
Folding back into original bug.

Sign in to add a comment