Issue metadata
Sign in to add a comment
|
kexec-tools does not build on amd64 with clang |
||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36
Steps to reproduce the problem:
$ emerge amd64-generic kexec-tools
What is the expected behavior?
Package should build successfully
What went wrong?
Compilation fails:
...
/build/amd64-generic/tmp/portage/sys-apps/kexec-tools-2.0.9-r1/work/kexec-tools-2.0.9/purgatory/arch/i386/entry32-16.S:23:2: error: unknown directive
.arch i386
^
/build/amd64-generic/tmp/portage/sys-apps/kexec-tools-2.0.9-r1/work/kexec-tools-2.0.9/purgatory/arch/i386/entry32-16.S:115:11: error: unknown token in expression
ljmp %cs:*(realdest - entry16)
^
make: *** [Makefile:119: purgatory/arch/i386/entry32-16.o] Error 1
Did this work before? No
Chrome version: 66.0.3359.117 Channel: n/a
OS Version:
Flash Version:
,
May 21 2018
Manoj, can you take a look at this? why did this start failing? I guess disabling integrated assembler should work?
,
May 21 2018
i think it's always been broken w/clang, we just haven't normally built it
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/43dea5447841df56e0726834e5b7c8d7a89614b5 commit 43dea5447841df56e0726834e5b7c8d7a89614b5 Author: Andrew Bresticker <abrestic@waymo.com> Date: Tue May 22 07:21:32 2018 kexec-tools: Build with GCC kexec-tools does not build with clang, at least on amd64: ./purgatory/arch/i386/entry32-16.S:23:2: error: unknown directive .arch i386 ^ ./purgatory/arch/i386/entry32-16.S:115:11: error: unknown token in expression ljmp %cs:*(realdest - entry16) ^ BUG= chromium:844451 TEST=emerge-metis kexec-tools Change-Id: I4cf657030b2bec3372a4874e2f230c3a57ccce7e Signed-off-by: Andrew Bresticker <abrestic@waymo.com> Reviewed-on: https://chromium-review.googlesource.com/1062328 Commit-Ready: Andrew Bresticker <abrestic@chromium.org> Tested-by: Andrew Bresticker <abrestic@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/43dea5447841df56e0726834e5b7c8d7a89614b5/chromeos/config/env/sys-apps/kexec-tools
,
May 22 2018
Manoj has CL for this. https://chromium-review.googlesource.com/1067942
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/2013edad5287b0f9d23f19f6dfbd612baa6c9f10 commit 2013edad5287b0f9d23f19f6dfbd612baa6c9f10 Author: Manoj Gupta <manojgupta@google.com> Date: Wed May 23 08:25:38 2018 kexec-tools: Update to 2.0.17. Update to upstream version 2.0.17. Changes: KEYWORDS -> * CQ-DEPEND=CL:1069407 BUG= chromium:844451 TEST=kexec-tools builds wih clang. Change-Id: I2cdadd1407f20e5e7df64422f44cd8c6f27b0e6e Reviewed-on: https://chromium-review.googlesource.com/1067942 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/2013edad5287b0f9d23f19f6dfbd612baa6c9f10/sys-apps/kexec-tools/Manifest [rename] https://crrev.com/2013edad5287b0f9d23f19f6dfbd612baa6c9f10/sys-apps/kexec-tools/kexec-tools-2.0.17.ebuild [delete] https://crrev.com/bccff9815befe5f4080f875e528b9e3c8f77854a/sys-apps/kexec-tools/files/kexec.init-2.0.4-r2 [add] https://crrev.com/2013edad5287b0f9d23f19f6dfbd612baa6c9f10/sys-apps/kexec-tools/files/kexec.init-2.0.13-r1 [delete] https://crrev.com/bccff9815befe5f4080f875e528b9e3c8f77854a/sys-apps/kexec-tools/files/kexec-tools-2.0.9-hardened.patch
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/261e5f997a186549ab8d79a5e2bbbfe83e11f69e commit 261e5f997a186549ab8d79a5e2bbbfe83e11f69e Author: Manoj Gupta <manojgupta@google.com> Date: Wed May 23 08:25:38 2018 kexec-tools: Fix build with clang. Disable integrated assembler to make kexec-tools build with clang. BUG= chromium:844451 TEST=kexec-tools builds wih clang. Change-Id: I0f118205f7fa66255c6d17ece07c5e81bf88a63f Reviewed-on: https://chromium-review.googlesource.com/1069407 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/261e5f997a186549ab8d79a5e2bbbfe83e11f69e/chromeos/config/env/sys-apps/kexec-tools
,
May 25 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vapier@chromium.org
, May 21 2018Status: Available (was: Unconfirmed)