New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 842145



Sign in to add a comment

xvfb.run_executable(...) doesn't output to stdoutfile if xvfb is enabled on Linux

Project Member Reported by nednguyen@chromium.org, May 18 2018

Issue description

In https://chromium-review.googlesource.com/c/chromium/src/+/1063996, I added the functionality to output benchmark's stdout to a file. The try run on https://ci.chromium.org/buildbot/tryserver.chromium.perf/obbs_fyi/331 was failing.

At first, I couldn't reproduce this locally. Once I dig more into it, it turns out because the obbs_fyi bot use "--xvfb" flag, which trigger a slightly different code path. In particular, when xvfb flag is enabled on Linux, xvfb.run_executable() method recursively run xvfb.py (see https://cs.chromium.org/chromium/src/testing/xvfb.py?rcl=eb9f60d092af8ebfdce0a6e507bb7509460b1b2b&l=87) and doesn't pass stdoutfile param through with that recursive call.

I will make a change to make sure xvfb.run_executable(..) passes stdoutfile through in that case
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d72c068b398673a7f6a4c7723c2c9952323bd435

commit d72c068b398673a7f6a4c7723c2c9952323bd435
Author: nednguyen <nednguyen@google.com>
Date: Fri May 18 20:24:39 2018

Make sure that xvfb.run_executable writes command output to stdoutfile when xvfb is enabled on linux

Bug:  844448 
Change-Id: I1431022bacb0977979317962c2147e506820f38b
Reviewed-on: https://chromium-review.googlesource.com/1065573
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#560009}
[modify] https://crrev.com/d72c068b398673a7f6a4c7723c2c9952323bd435/testing/xvfb.py

Status: Fixed (was: Started)

Sign in to add a comment