New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844432 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 845505



Sign in to add a comment

Investigate warnings from the bots

Project Member Reported by mmoroz@chromium.org, May 18 2018

Issue description



with DCHECK configurable:

dumps/unit_tests/dump.15637601757318935466_1.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)

with DCHECK configurable + batch size=2:

warning: dumps/layout_tests/dump.18395753314869171706_6.profraw: Counter overflow
warning: dumps/layout_tests/dump.7114866835069606434_0.profraw: Counter overflow



Another instance with DCHECK configurable:

$ egrep -r 'counter mismatch' 559568/
559568/chrome_app_unittests.log:dumps/chrome_app_unittests/dump.3720661661596840874_2.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/sync_integration_tests.log:dumps/sync_integration_tests/dump.5496747970460447658_1.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/sync_integration_tests.log:dumps/sync_integration_tests/dump.5496747970460447658_3.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/sync_integration_tests.log:dumps/sync_integration_tests/dump.5496747970460447658_2.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/sync_integration_tests.log:dumps/sync_integration_tests/dump.5496747970460447658_0.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/sync_integration_tests.log:dumps/sync_integration_tests/dump.5496747970460447658_5.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/sync_integration_tests.log:dumps/sync_integration_tests/dump.5496747970460447658_7.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/sync_integration_tests.log:dumps/sync_integration_tests/dump.5496747970460447658_6.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/sync_integration_tests.log:dumps/sync_integration_tests/dump.5496747970460447658_4.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/interactive_ui_tests.log:dumps/interactive_ui_tests/dump.10884822079606364883_3.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/interactive_ui_tests.log:dumps/interactive_ui_tests/dump.10884822079606364883_5.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/interactive_ui_tests.log:dumps/interactive_ui_tests/dump.10884822079606364883_7.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/interactive_ui_tests.log:dumps/interactive_ui_tests/dump.10884822079606364883_4.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/interactive_ui_tests.log:dumps/interactive_ui_tests/dump.10884822079606364883_6.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/interactive_ui_tests.log:dumps/interactive_ui_tests/dump.10884822079606364883_2.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/interactive_ui_tests.log:dumps/interactive_ui_tests/dump.10884822079606364883_0.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/interactive_ui_tests.log:dumps/interactive_ui_tests/dump.10884822079606364883_1.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/browser_tests.log:dumps/browser_tests/dump.11916076867182195626_5.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/browser_tests.log:dumps/browser_tests/dump.11916076867182195626_7.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/browser_tests.log:dumps/browser_tests/dump.11916076867182195626_1.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/browser_tests.log:dumps/browser_tests/dump.11916076867182195626_6.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/browser_tests.log:dumps/browser_tests/dump.11916076867182195626_2.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/browser_tests.log:dumps/browser_tests/dump.11916076867182195626_0.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/browser_tests.log:dumps/browser_tests/dump.11916076867182195626_3.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/browser_tests.log:dumps/browser_tests/dump.11916076867182195626_4.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/unit_tests.log:dumps/unit_tests/dump.15637601757318935466_1.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/unit_tests.log:dumps/unit_tests/dump.15637601757318935466_3.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/unit_tests.log:dumps/unit_tests/dump.15637601757318935466_2.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/unit_tests.log:dumps/unit_tests/dump.15637601757318935466_0.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/unit_tests.log:dumps/unit_tests/dump.15637601757318935466_5.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/unit_tests.log:dumps/unit_tests/dump.15637601757318935466_4.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/unit_tests.log:dumps/unit_tests/dump.15637601757318935466_7.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/unit_tests.log:dumps/unit_tests/dump.15637601757318935466_6.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/pdf_unittests.log:dumps/pdf_unittests/dump.9124511344874550186_3.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/pdf_unittests.log:dumps/pdf_unittests/dump.9124511344874550186_2.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/pdf_unittests.log:dumps/pdf_unittests/dump.9124511344874550186_0.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/pdf_unittests.log:dumps/pdf_unittests/dump.9124511344874550186_6.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/pdf_unittests.log:dumps/pdf_unittests/dump.9124511344874550186_5.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/pdf_unittests.log:dumps/pdf_unittests/dump.9124511344874550186_7.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/headless_browsertests.log:dumps/headless_browsertests/dump.3778204692788341084_1.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/headless_browsertests.log:dumps/headless_browsertests/dump.3778204692788341084_2.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/headless_browsertests.log:dumps/headless_browsertests/dump.3778204692788341084_0.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/headless_browsertests.log:dumps/headless_browsertests/dump.3778204692788341084_3.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/headless_browsertests.log:dumps/headless_browsertests/dump.3778204692788341084_5.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/headless_browsertests.log:dumps/headless_browsertests/dump.3778204692788341084_6.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/headless_browsertests.log:dumps/headless_browsertests/dump.3778204692788341084_4.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
559568/headless_browsertests.log:dumps/headless_browsertests/dump.3778204692788341084_7.profraw: SkFloatToDecimal.cpp:_ZL5pow10i: Function basic block count change detected (counter mismatch)
 

Comment 1 by mmoroz@chromium.org, May 18 2018

Also I've seen another one:

+ REVISION=559539
<...>
+ merge_dumps
+ /chromium/src/third_party/llvm-build/Release+Asserts/bin/llvm-profdata merge -sparse  <....>
/chromium/src/dumps/layout_tests/dump.profdata: _ZNK2v88internal10HandleBasedeEv: Counter overflow
warning: /chromium/src/dumps/skia_unittests/dump.profdata: Counter overflow


Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/code-coverage/+/4f1d574c454b66c5d6f9e3288788dbc11b370956

commit 4f1d574c454b66c5d6f9e3288788dbc11b370956
Author: Abhishek Arya <aarya@google.com>
Date: Fri May 18 14:36:00 2018

Comment 3 by mmoroz@chromium.org, May 18 2018

Actually, I don't see any of these when we didn't use dcheck_is_configurable. We're reverting that change right now, but let's keep this issue open until we confirm that we don't see any warnings.
Project Member

Comment 4 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/code-coverage/+/293f6c0cc04786c513c1000697439a3e6d41302d

commit 293f6c0cc04786c513c1000697439a3e6d41302d
Author: Max Moroz <mmoroz@google.com>
Date: Fri May 18 15:20:36 2018

Comment 5 by mmoroz@chromium.org, May 19 2018

Another issue (noticed in https://chromium-coverage.appspot.com/reports/559927/linux/metadata/_bot.log):


+ merge_dumps
+ /chromium/src/third_party/llvm-build/Release+Asserts/bin/llvm-profdata merge -sparse <....> -o /chromium/src/dumps/tests_only.profdata
....
/chromium/src/dumps/layout_tests/dump.profdata: _ZNSt3__114numeric_limitsIiE3maxEv: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZN8tcmalloc6Static7sizemapEv: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZNKSt3__117__compressed_pairINS_12basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEE5__repES5_E5firstEv: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZNSt3__17forwardIDnEEOT_RNS_16remove_referenceIS1_E4typeE: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: allocator_shim.cc:_ZN12_GLOBAL__N_112GetChainHeadEv: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZNK8tcmalloc11ThreadCache8FreeList10max_lengthEv: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZN8tcmalloc7MaskPtrEPv: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZN10MallocHook10GetNewHookEv: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZN11PackedCacheILi36EmE4HashEm: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZNK13scoped_refptrIKN4base8internal13WeakReference4FlagEEcvbEv: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZN8tcmalloc11ThreadCache13GetThreadHeapEv: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZN8tcmalloc17KernelSupportsTLSEv: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: debugallocation_shim.cc:_ZN12_GLOBAL__N_19do_mallocEm: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: _ZN8tcmalloc7SizeMap16ByteSizeForClassEm: Counter overflow
/chromium/src/dumps/layout_tests/dump.profdata: debugallocation_shim.cc:_ZN12_GLOBAL__N_121do_free_with_callbackEPvPFvS0_E: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZNSt3__114numeric_limitsIiE3maxEv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZNK8tcmalloc11ThreadCache8FreeList10max_lengthEv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: debugallocation_shim.cc:_ZN12_GLOBAL__N_19do_mallocEm: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZNSt3__114numeric_limitsIiE6lowestEv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZN8tcmalloc7MaskPtrEPv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZNKSt3__117__compressed_pairINS_12basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEE5__repES5_E5firstEv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZNSt3__123__libcpp_numeric_limitsIiLb1EE6lowestEv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZNSt3__17forwardIDnEEOT_RNS_16remove_referenceIS1_E4typeE: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZN10MallocHook10GetNewHookEv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZN8tcmalloc7SizeMap16ByteSizeForClassEm: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZN8tcmalloc11ThreadCache13GetThreadHeapEv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZNK13scoped_refptrIKN4base8internal13WeakReference4FlagEEcvbEv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: allocator_shim.cc:_ZN12_GLOBAL__N_112GetChainHeadEv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZN11PackedCacheILi36EmE4HashEm: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZN8tcmalloc17KernelSupportsTLSEv: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: debugallocation_shim.cc:_ZN12_GLOBAL__N_121do_free_with_callbackEPvPFvS0_E: Counter overflow
/chromium/src/dumps/viz_unittests/dump.profdata: _ZN8tcmalloc6Static7sizemapEv: Counter overflow
warning: /chromium/src/dumps/viz_unittests/dump.profdata: Counter overflow

Comment 6 Deleted

Blockedon: 845505
Project Member

Comment 8 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5811afaaad758aa61280b6ebae5499d70b04856

commit e5811afaaad758aa61280b6ebae5499d70b04856
Author: Abhishek Arya <inferno@chromium.org>
Date: Thu May 24 03:56:01 2018

Coverage: Add merge output in verbose mode.

Merge output is important to see any counter overflow warnings.
On coverage bot, this is already captured. So, support similar
functionality in verbose mode.

R=mmoroz@chromium.org,liaoyuke@chromium.org

Bug:  844432 
Change-Id: I5bffb5c8d1c5b0748c66ebed3e4becca7619a3eb
Reviewed-on: https://chromium-review.googlesource.com/1070997
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561381}
[modify] https://crrev.com/e5811afaaad758aa61280b6ebae5499d70b04856/tools/code_coverage/coverage.py

Status: Fixed (was: Started)
No more warnings with DCHECK configurable, it was just  bug 845505 .

Sign in to add a comment