Issue metadata
Sign in to add a comment
|
MacViews: Resizing windows is broken on macOS <= 10.11.* |
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3434.0 OS: macOS 10.11.6 What steps will reproduce the problem? (1) Open Chromium, enable #views-browser-windows (2) Try to resize browser window by dragging on the side or an edge What is the expected result? Window is resized but stays in place. What happens instead? Window is simultaneously resized and moved. This is caused by: https://chromium-review.googlesource.com/c/chromium/src/+/1000212 and more specifically by -[BrowserWindowFrame mouseDown:]: https://chromium-review.googlesource.com/c/chromium/src/+/1000212/14/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm -- it gets a mouseDown: when trying to resize a window. Bisect on a macOS 10.11 machine gave this range: https://chromium.googlesource.com/chromium/src/+log/f617d01a04196951c9dfbc5234bf3b2b61b751fc..c2913b9855db00283818286085a19ba122d09c9b
,
May 22 2018
Triage: Assigning to sdy@ who has been looking into window resizing recently.
,
Jun 11 2018
,
Jun 28 2018
Hi, I do a lot of testing on Chrome, using a Mac with OS X 10.10.3. Is there an estimated time this bug will be looked at? I noticed it's a P3/not time critical, so I'm curious, is this because it doesn't affect the latest OS X versions?
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/725947f86744da7eed4a28b760a6ae51d56e2a9e commit 725947f86744da7eed4a28b760a6ae51d56e2a9e Author: Sidney San Martín <sdy@chromium.org> Date: Tue Jul 10 21:45:18 2018 Reland "Make all MacViews windows potentially draggable." This is a reland of 330fc4a13c739591b9a1cf438b6b82a8e8cde96d with some changes: - |[super mouseDown:]| is called from each subclass rather than the shared NSView category, so that it uses the direct superclass implementation instead of NSResponder :/. - If a mouse event would result in a resize, don't start a drag. I verified that this method exists back to 10.9. NSThemeFrame does this check, too, when movableByWindowBackground is set on its window, but it's missing from the frame view class which borderless windows use. For simplicity, I'm using the workaround for both. - Our theme frame subclasses override -usesCustomDrawing to return NO to avoid AppKit breakage (like the title not redrawing when it should). Original change's description: > Make all MacViews windows potentially draggable. > > This fixes the PiP window not being draggable on Mac. > > Bug: 849983 > Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75 > Reviewed-on: https://chromium-review.googlesource.com/1121145 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572038} Bug: 849983 , 844417 , 859820 , 859829 Change-Id: I3e596bed04312617edf658e0e652e1491374b9aa Reviewed-on: https://chromium-review.googlesource.com/1125099 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573926} [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/chrome/browser/ui/views/frame/native_widget_mac_frameless_nswindow.mm [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/ui/views/cocoa/native_widget_mac_nswindow.h [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/ui/views/cocoa/native_widget_mac_nswindow.mm
,
Jul 11
Unable to reproduce the issue on reported version 68.0.3434.0 on Mac 10.12.6.This issue seems to be specific to Mac 10.11.6. sdy@ /reporter@ - Request you to kindly help in verifying the fix on the latest canary 69.0.3488.0 on Mac 10.11.6. Thanks.!
,
Jul 11
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mblsha.y...@gmail.com
, May 18 20186.2 MB
6.2 MB View Download